diff --git a/src/scrobbler/subsonicscrobbler.cpp b/src/scrobbler/subsonicscrobbler.cpp index c368eca58..421fa5471 100644 --- a/src/scrobbler/subsonicscrobbler.cpp +++ b/src/scrobbler/subsonicscrobbler.cpp @@ -52,10 +52,6 @@ SubsonicScrobbler::SubsonicScrobbler(Application *app, QObject *parent) : Scrobb } -SubsonicScrobbler::~SubsonicScrobbler() { - -} - void SubsonicScrobbler::ReloadSettings() { QSettings s; @@ -106,13 +102,9 @@ void SubsonicScrobbler::Scrobble(const Song &song) { } -void SubsonicScrobbler::DoSubmit() { - -} - void SubsonicScrobbler::Submit() { - qLog(Debug) << "SubsonicScrobbler: Submitting scrobble for " << song_playing_.song_id(); + qLog(Debug) << "SubsonicScrobbler: Submitting scrobble for" << song_playing_.artist() << song_playing_.title(); submitted_ = false; if (app_->scrobbler()->IsOffline()) return; diff --git a/src/scrobbler/subsonicscrobbler.h b/src/scrobbler/subsonicscrobbler.h index 053c0221a..51b5f265d 100644 --- a/src/scrobbler/subsonicscrobbler.h +++ b/src/scrobbler/subsonicscrobbler.h @@ -40,7 +40,6 @@ class SubsonicScrobbler : public ScrobblerService { public: explicit SubsonicScrobbler(Application *app, QObject *parent = nullptr); - ~SubsonicScrobbler() override; static const char *kName; @@ -54,7 +53,7 @@ class SubsonicScrobbler : public ScrobblerService { void Scrobble(const Song &song) override; void Error(const QString &error, const QVariant &debug = QVariant()) override; - void DoSubmit() override; + void DoSubmit() override {} void Submitted() override { submitted_ = true; } bool IsSubmitted() const override { return submitted_; } diff --git a/src/subsonic/subsonicscrobblerequest.cpp b/src/subsonic/subsonicscrobblerequest.cpp index 4f2116250..83bfc5c4f 100644 --- a/src/subsonic/subsonicscrobblerequest.cpp +++ b/src/subsonic/subsonicscrobblerequest.cpp @@ -45,9 +45,7 @@ SubsonicScrobbleRequest::SubsonicScrobbleRequest(SubsonicService *service, Subso url_handler_(url_handler), app_(app), scrobble_requests_active_(0) - { - -} + {} SubsonicScrobbleRequest::~SubsonicScrobbleRequest() { diff --git a/src/subsonic/subsonicservice.cpp b/src/subsonic/subsonicservice.cpp index 4ee84eb69..d4a004930 100644 --- a/src/subsonic/subsonicservice.cpp +++ b/src/subsonic/subsonicservice.cpp @@ -381,7 +381,7 @@ void SubsonicService::CheckConfiguration() { } -void SubsonicService::Scrobble(QString song_id, bool submission, QDateTime time) { +void SubsonicService::Scrobble(const QString &song_id, const bool submission, const QDateTime time) { if (!server_url().isValid() || username().isEmpty() || password().isEmpty()) { return; diff --git a/src/subsonic/subsonicservice.h b/src/subsonic/subsonicservice.h index 046dae682..452b4b7a2 100644 --- a/src/subsonic/subsonicservice.h +++ b/src/subsonic/subsonicservice.h @@ -81,7 +81,7 @@ class SubsonicService : public InternetService { QSortFilterProxyModel *songs_collection_sort_model() override { return collection_sort_model_; } void CheckConfiguration(); - void Scrobble(QString song_id, bool submission, QDateTime time); + void Scrobble(const QString &song_id, const bool submission, const QDateTime time); public slots: void ShowConfig() override;