Clang-Tidy and Clazy fixes

src/analyzer/analyzercontainer.cpp

@@ -19,6 +19,8 @@
 
 #include "config.h"
 
+#include <chrono>
+
 #include <QObject>
 #include <QWidget>
 #include <QVariant>
@@ -44,6 +46,8 @@
 #include "engine/enginebase.h"
 #include "engine/enginetype.h"
 
+using namespace std::chrono_literals;
+
 const char *AnalyzerContainer::kSettingsGroup = "Analyzer";
 const char *AnalyzerContainer::kSettingsFramerate = "framerate";
 
@@ -90,7 +94,7 @@ AnalyzerContainer::AnalyzerContainer(QWidget *parent)
   context_menu_->addSeparator();
 
   double_click_timer_->setSingleShot(true);
-  double_click_timer_->setInterval(250);
+  double_click_timer_->setInterval(250ms);
   QObject::connect(double_click_timer_, &QTimer::timeout, this, &AnalyzerContainer::ShowPopupMenu);
 
   Load();

src/analyzer/blockanalyzer.cpp

@@ -248,6 +248,8 @@ QColor ensureContrast(const QColor &bg, const QColor &fg, int amount) {
 
    private:
     const QColor &c;
+
+    Q_DISABLE_COPY(OutputOnExit)
   };
 
   OutputOnExit allocateOnTheStack(fg);

src/analyzer/fht.cpp

@@ -49,7 +49,7 @@ void FHT::makeCasTable(void) {
   float *sintab = tab_() + num_ / 2 + 1;
 
   for (int ul = 0; ul < num_; ul++) {
-    float d = M_PI * ul / (num_ / 2);
+    float d = M_PI * ul / (num_ / 2);  // NOLINT(bugprone-integer-division)
     *costab = *sintab = cos(d);
 
     costab += 2;

src/analyzer/rainbowanalyzer.cpp

@@ -56,7 +56,7 @@ const float Rainbow::RainbowAnalyzer::kPixelScale = 0.02f;
 
 Rainbow::RainbowAnalyzer::RainbowType Rainbow::RainbowAnalyzer::rainbowtype;
 
-Rainbow::RainbowAnalyzer::RainbowAnalyzer(const RainbowType &rbtype, QWidget *parent)
+Rainbow::RainbowAnalyzer::RainbowAnalyzer(const RainbowType rbtype, QWidget *parent)
     : Analyzer::Base(parent, 9),
       timer_id_(startTimer(kFrameIntervalMs)),
       frame_(0),
@@ -73,7 +73,7 @@ Rainbow::RainbowAnalyzer::RainbowAnalyzer(const RainbowType &rbtype, QWidget *pa
   memset(history_, 0, sizeof(history_));
 
   for (int i = 0; i < kRainbowBands; ++i) {
-    colors_[i] = QPen(QColor::fromHsv(i * 255 / kRainbowBands, 255, 255), kRainbowHeight[rainbowtype] / kRainbowBands, Qt::SolidLine, Qt::FlatCap, Qt::RoundJoin);
+    colors_[i] = QPen(QColor::fromHsv(i * 255 / kRainbowBands, 255, 255), kRainbowHeight[rainbowtype] / kRainbowBands, Qt::SolidLine, Qt::FlatCap, Qt::RoundJoin);  // NOLINT(bugprone-integer-division)
 
     // pow constants computed so that
     // | band_scale(0) | ~= .5 and | band_scale(5) | ~= 32

src/analyzer/rainbowanalyzer.h

@@ -50,7 +50,7 @@ class RainbowAnalyzer : public Analyzer::Base {
     Dash = 1 
   };
 
-  RainbowAnalyzer(const RainbowType &rbtype, QWidget *parent);
+  RainbowAnalyzer(const RainbowType rbtype, QWidget *parent);
 
  protected:
   void transform(Analyzer::Scope&) override;