Clang-Tidy and Clazy fixes

This commit is contained in:
Jonas Kvinge
2021-06-20 19:04:08 +02:00
parent 755abec636
commit 1295033fae
374 changed files with 1304 additions and 900 deletions

View File

@@ -68,7 +68,8 @@ void Console::RunQuery() {
while (query.isValid()) {
QSqlRecord record = query.record();
QStringList values;
QStringList values; // clazy:exclude=container-inside-loop
values.reserve(record.count());
for (int i = 0; i < record.count(); ++i) {
values.append(record.value(i).toString());
}

View File

@@ -148,7 +148,7 @@ EditTagDialog::EditTagDialog(Application *app, QWidget *parent)
QWidget *widget = label->buddy();
if (widget) {
// Store information about the field
fields_ << FieldData(label, widget, widget->objectName());
fields_ << FieldData(label, widget, widget->objectName()); // clazy:exclude=reserve-candidates
// Connect the edited signal
if (LineEdit *lineedit = qobject_cast<LineEdit*>(widget)) {
@@ -355,7 +355,8 @@ bool EditTagDialog::eventFilter(QObject *o, QEvent *e) {
break;
}
}
return false;
return QDialog::eventFilter(o, e);
}
@@ -555,7 +556,7 @@ void EditTagDialog::UpdateFieldValue(const FieldData &field, const QModelIndexLi
QVariant value;
if (ExtendedEditor *editor = dynamic_cast<ExtendedEditor*>(field.editor_)) {
value = editor->value();
value = editor->value(); // clazy:exclude=qt6-deprecated-api-fixes
}
else if (field.editor_) {
qLog(Error) << "Missing editor for" << field.editor_->objectName();

View File

@@ -314,7 +314,7 @@ void TrackSelectionDialog::accept() {
void TrackSelectionDialog::AcceptFinished() {
QFutureWatcher<void> *watcher = dynamic_cast<QFutureWatcher<void>*>(sender());
QFutureWatcher<void> *watcher = static_cast<QFutureWatcher<void>*>(sender());
if (!watcher) return;
watcher->deleteLater();