dryark/strawberry
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Clang-Tidy and Clazy fixes

Browse Source
This commit is contained in:
Jonas Kvinge
2021-06-20 19:04:08 +02:00
parent 755abec636
commit 1295033fae
374 changed files with 1304 additions and 900 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/qobuz/qobuzbaserequest.cpp
View File

@@ -84,9 +84,9 @@ QNetworkReply *QobuzBaseRequest::CreateRequest(const QString &ressource_name, co
}
void QobuzBaseRequest::HandleSSLErrors(QList<QSslError> ssl_errors) {
void QobuzBaseRequest::HandleSSLErrors(const QList<QSslError> &ssl_errors) {
for (QSslError &ssl_error : ssl_errors) {
for (const QSslError &ssl_error : ssl_errors) {
Error(ssl_error.errorString());
}

2
src/qobuz/qobuzbaserequest.h
View File

@@ -94,7 +94,7 @@ class QobuzBaseRequest : public QObject {
int login_attempts() { return service_->login_attempts(); }
private slots:
void HandleSSLErrors(QList<QSslError> ssl_errors);
void HandleSSLErrors(const QList<QSslError> &ssl_errors);
private:
QobuzService *service_;

2
src/qobuz/qobuzrequest.cpp
View File

@@ -510,7 +510,7 @@ void QobuzRequest::FlushArtistAlbumsRequests() {
}
void QobuzRequest::ArtistAlbumsReplyReceived(QNetworkReply *reply, const QString artist_id, const int offset_requested) {
void QobuzRequest::ArtistAlbumsReplyReceived(QNetworkReply *reply, const QString &artist_id, const int offset_requested) {
--artist_albums_requests_active_;
++artist_albums_received_;

2
src/qobuz/qobuzrequest.h
View File

@@ -77,7 +77,7 @@ class QobuzRequest : public QobuzBaseRequest {
void SongsReplyReceived(QNetworkReply *reply, const int limit_requested, const int offset_requested);
void SongsReceived(QNetworkReply *reply, const QString &artist_id_requested, const QString &album_id_requested, const int limit_requested, const int offset_requested, const QString &album_artist_requested = QString(), const QString &album_requested = QString());
void ArtistAlbumsReplyReceived(QNetworkReply *reply, const QString artist_id, const int offset_requested);
void ArtistAlbumsReplyReceived(QNetworkReply *reply, const QString &artist_id, const int offset_requested);
void AlbumSongsReplyReceived(QNetworkReply *reply, const QString &artist_id, const QString &album_id, const int offset_requested, const QString &album_artist, const QString &album);
void AlbumCoverReceived(QNetworkReply *reply, const QUrl &cover_url, const QString &filename);

8
src/qobuz/qobuzservice.cpp
View File

@@ -202,7 +202,7 @@ void QobuzService::Exit() {
void QobuzService::ExitReceived() {
QObject *obj = qobject_cast<QObject*>(sender());
QObject *obj = sender();
QObject::disconnect(obj, nullptr, this, nullptr);
qLog(Debug) << obj << "successfully exited.";
wait_for_exit_.removeAll(obj);
@@ -287,9 +287,9 @@ void QobuzService::SendLoginWithCredentials(const QString &app_id, const QString
}
void QobuzService::HandleLoginSSLErrors(QList<QSslError> ssl_errors) {
void QobuzService::HandleLoginSSLErrors(const QList<QSslError> &ssl_errors) {
for (QSslError &ssl_error : ssl_errors) {
for (const QSslError &ssl_error : ssl_errors) {
login_errors_ += ssl_error.errorString();
}
@@ -728,7 +728,7 @@ void QobuzService::GetStreamURL(const QUrl &url) {
}
void QobuzService::HandleStreamURLFinished(const QUrl &original_url, const QUrl &stream_url, const Song::FileType filetype, const int samplerate, const int bit_depth, const qint64 duration, QString error) {
void QobuzService::HandleStreamURLFinished(const QUrl &original_url, const QUrl &stream_url, const Song::FileType filetype, const int samplerate, const int bit_depth, const qint64 duration, const QString &error) {
QobuzStreamURLRequest *stream_url_req = qobject_cast<QobuzStreamURLRequest*>(sender());
if (!stream_url_req || !stream_url_requests_.contains(stream_url_req)) return;

4
src/qobuz/qobuzservice.h
View File

@@ -128,7 +128,7 @@ class QobuzService : public InternetService {
private slots:
void ExitReceived();
void HandleLoginSSLErrors(QList<QSslError> ssl_errors);
void HandleLoginSSLErrors(const QList<QSslError> &ssl_errors);
void HandleAuthReply(QNetworkReply *reply);
void ResetLoginAttempts();
void StartSearch();
@@ -145,7 +145,7 @@ class QobuzService : public InternetService {
void ArtistsUpdateProgressReceived(const int id, const int progress);
void AlbumsUpdateProgressReceived(const int id, const int progress);
void SongsUpdateProgressReceived(const int id, const int progress);
void HandleStreamURLFinished(const QUrl &original_url, const QUrl &stream_url, const Song::FileType filetype, const int samplerate, const int bit_depth, const qint64 duration, QString error);
void HandleStreamURLFinished(const QUrl &original_url, const QUrl &stream_url, const Song::FileType filetype, const int samplerate, const int bit_depth, const qint64 duration, const QString &error);
private:
typedef QPair<QString, QString> Param;

2
src/qobuz/qobuzurlhandler.cpp
View File

@@ -49,7 +49,7 @@ UrlHandler::LoadResult QobuzUrlHandler::StartLoading(const QUrl &url) {
}
void QobuzUrlHandler::GetStreamURLFinished(const QUrl &original_url, const QUrl &stream_url, const Song::FileType filetype, const int samplerate, const int bit_depth, const qint64 duration, QString error) {
void QobuzUrlHandler::GetStreamURLFinished(const QUrl &original_url, const QUrl &stream_url, const Song::FileType filetype, const int samplerate, const int bit_depth, const qint64 duration, const QString &error) {
if (task_id_ == -1) return;
CancelTask();

2
src/qobuz/qobuzurlhandler.h
View File

@@ -43,7 +43,7 @@ class QobuzUrlHandler : public UrlHandler {
void CancelTask();
private slots:
void GetStreamURLFinished(const QUrl &original_url, const QUrl &stream_url, const Song::FileType filetype, const int samplerate, const int bit_depth, const qint64 duration, QString error = QString());
void GetStreamURLFinished(const QUrl &original_url, const QUrl &stream_url, const Song::FileType filetype, const int samplerate, const int bit_depth, const qint64 duration, const QString &error = QString());
private:
Application *app_;