dryark/strawberry
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Clang-Tidy and Clazy fixes

Browse Source
This commit is contained in:
Jonas Kvinge
2021-06-20 19:04:08 +02:00
parent 755abec636
commit 1295033fae
374 changed files with 1304 additions and 900 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
tests/src/collectionbackend_test.cpp
View File

@@ -37,6 +37,8 @@
#include "collection/collectionbackend.h"
#include "collection/collection.h"
// clazy:excludeall=non-pod-global-static,returning-void-expression
namespace {
class CollectionBackendTest : public ::testing::Test {
@@ -58,8 +60,8 @@ class CollectionBackendTest : public ::testing::Test {
return ret;
}
std::shared_ptr<Database> database_;
std::unique_ptr<CollectionBackend> backend_;
std::shared_ptr<Database> database_; // NOLINT(cppcoreguidelines-non-private-member-variables-in-classes)
std::unique_ptr<CollectionBackend> backend_; // NOLINT(cppcoreguidelines-non-private-member-variables-in-classes)
};
TEST_F(CollectionBackendTest, EmptyDatabase) {
@@ -180,7 +182,7 @@ class SingleSong : public CollectionBackendTest {
EXPECT_EQ(1, list[0].directory_id());
}
Song song_;
Song song_; // NOLINT(cppcoreguidelines-non-private-member-variables-in-classes)
};
@@ -190,7 +192,7 @@ TEST_F(SingleSong, GetSongWithNoAlbum) {
AddDummySong(); if (HasFatalFailure()) return;
EXPECT_EQ(1, backend_->GetAllArtists().size());
CollectionBackend::AlbumList albums = backend_->GetAllAlbums();
//CollectionBackend::AlbumList albums = backend_->GetAllAlbums();
//EXPECT_EQ(1, albums.size());
//EXPECT_EQ("Artist", albums[0].artist);
//EXPECT_EQ("", albums[0].album);