From 1d9a05287031a728832c4af88ae13ce1f56a277d Mon Sep 17 00:00:00 2001 From: Jonas Kvinge Date: Sun, 2 Jul 2023 00:29:19 +0200 Subject: [PATCH] AlbumCoverChoiceController: Move result declaration --- src/covermanager/albumcoverchoicecontroller.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/covermanager/albumcoverchoicecontroller.cpp b/src/covermanager/albumcoverchoicecontroller.cpp index 35b34998d..36cd88c71 100644 --- a/src/covermanager/albumcoverchoicecontroller.cpp +++ b/src/covermanager/albumcoverchoicecontroller.cpp @@ -179,13 +179,13 @@ AlbumCoverImageResult AlbumCoverChoiceController::LoadImageFromFile(Song *song) QString cover_file = QFileDialog::getOpenFileName(this, tr("Load cover from disk"), GetInitialPathForFileDialog(*song, QString()), tr(kLoadImageFileFilter) + ";;" + tr(kAllFilesFilter)); if (cover_file.isEmpty()) return AlbumCoverImageResult(); - AlbumCoverImageResult result; QFile file(cover_file); if (!file.open(QIODevice::ReadOnly)) { qLog(Error) << "Failed to open cover file" << cover_file << "for reading:" << file.errorString(); emit Error(tr("Failed to open cover file %1 for reading: %2").arg(cover_file, file.errorString())); return AlbumCoverImageResult(); } + AlbumCoverImageResult result; result.image_data = file.readAll(); file.close(); if (result.image_data.isEmpty()) {