dryark/strawberry
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Unmap buffer references in error cases

Browse Source
This commit is contained in:
Jonas Kvinge
2020-05-24 23:21:26 +02:00
parent 8b86c79bf9
commit 1f45c78ebb
1 changed files with 2 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/engine/gstengine.cpp
View File

@@ -419,6 +419,7 @@ void GstEngine::ConsumeBuffer(GstBuffer *buffer, const int pipeline_id, const QS
// Schedule this to run in the GUI thread. The buffer gets added to the queue and unreffed by UpdateScope. // Schedule this to run in the GUI thread. The buffer gets added to the queue and unreffed by UpdateScope.
if (!QMetaObject::invokeMethod(this, "AddBufferToScope", Q_ARG(GstBuffer*, buffer), Q_ARG(int, pipeline_id), Q_ARG(QString, format))) { if (!QMetaObject::invokeMethod(this, "AddBufferToScope", Q_ARG(GstBuffer*, buffer), Q_ARG(int, pipeline_id), Q_ARG(QString, format))) {
qLog(Warning) << "Failed to invoke AddBufferToScope on GstEngine"; qLog(Warning) << "Failed to invoke AddBufferToScope on GstEngine";
gst_buffer_unref(buffer);
} }
} }
@@ -802,6 +803,7 @@ void GstEngine::UpdateScope(const int chunk_length) {
// In case a buffer doesn't arrive in time // In case a buffer doesn't arrive in time
if (scope_chunk_ >= scope_chunks_) { if (scope_chunk_ >= scope_chunks_) {
scope_chunk_ = 0; scope_chunk_ = 0;
gst_buffer_unmap(latest_buffer_, &map);
return; return;
} }