Add explicit

This commit is contained in:
Jonas Kvinge
2020-04-07 16:49:15 +02:00
parent 3efc496c41
commit 21b2193cd0
199 changed files with 337 additions and 342 deletions

View File

@@ -39,7 +39,7 @@ class AppearanceSettingsPage : public SettingsPage {
Q_OBJECT
public:
AppearanceSettingsPage(SettingsDialog *dialog);
explicit AppearanceSettingsPage(SettingsDialog *dialog);
~AppearanceSettingsPage();
static const char *kSettingsGroup;

View File

@@ -42,7 +42,7 @@ class BackendSettingsPage : public SettingsPage {
Q_OBJECT
public:
BackendSettingsPage(SettingsDialog *dialog);
explicit BackendSettingsPage(SettingsDialog *dialog);
~BackendSettingsPage();
static const char *kSettingsGroup;

View File

@@ -36,7 +36,7 @@ class BehaviourSettingsPage : public SettingsPage {
Q_OBJECT
public:
BehaviourSettingsPage(SettingsDialog *dialog);
explicit BehaviourSettingsPage(SettingsDialog *dialog);
~BehaviourSettingsPage();
static const char *kSettingsGroup;

View File

@@ -37,8 +37,8 @@ class Ui_CollectionSettingsPage;
class CollectionSettingsPage : public SettingsPage {
Q_OBJECT
public:
CollectionSettingsPage(SettingsDialog *dialog);
public:
explicit CollectionSettingsPage(SettingsDialog *dialog);
~CollectionSettingsPage();
static const char *kSettingsGroup;
@@ -63,7 +63,7 @@ public:
void Load();
void Save();
private slots:
private slots:
void Add();
void Remove();
@@ -71,7 +71,7 @@ private slots:
void DiskCacheEnable(int state);
void CoverSaveInAlbumDirChanged();
private:
private:
Ui_CollectionSettingsPage *ui_;
bool initialised_model_;

View File

@@ -39,7 +39,7 @@ class ContextSettingsPage : public SettingsPage {
Q_OBJECT
public:
ContextSettingsPage(SettingsDialog *dialog);
explicit ContextSettingsPage(SettingsDialog *dialog);
~ContextSettingsPage();
enum ContextSettingsOrder {

View File

@@ -33,7 +33,7 @@ class MoodbarSettingsPage : public SettingsPage {
Q_OBJECT
public:
MoodbarSettingsPage(SettingsDialog* dialog);
explicit MoodbarSettingsPage(SettingsDialog* dialog);
~MoodbarSettingsPage();
static const char *kSettingsGroup;

View File

@@ -34,15 +34,15 @@ class Ui_NetworkProxySettingsPage;
class NetworkProxySettingsPage : public SettingsPage {
Q_OBJECT
public:
NetworkProxySettingsPage(SettingsDialog* dialog);
public:
explicit NetworkProxySettingsPage(SettingsDialog* dialog);
~NetworkProxySettingsPage();
static const char *kSettingsGroup;
void Load();
void Save();
private:
private:
Ui_NetworkProxySettingsPage* ui_;
};

View File

@@ -39,19 +39,19 @@ class Ui_NotificationsSettingsPage;
class NotificationsSettingsPage : public SettingsPage {
Q_OBJECT
public:
NotificationsSettingsPage(SettingsDialog *dialog);
public:
explicit NotificationsSettingsPage(SettingsDialog *dialog);
~NotificationsSettingsPage();
static const char *kSettingsGroup;
void Load();
void Save();
protected:
protected:
void hideEvent(QHideEvent*);
void showEvent(QShowEvent*);
private slots:
private slots:
void NotificationTypeChanged();
void NotificationCustomTextChanged(bool enabled);
void PrepareNotificationPreview();
@@ -67,7 +67,7 @@ private slots:
void UpdatePopupVisible();
private:
private:
Ui_NotificationsSettingsPage *ui_;
OSDPretty *pretty_popup_;
};

View File

@@ -34,17 +34,15 @@ class Ui_PlaylistSettingsPage;
class PlaylistSettingsPage : public SettingsPage {
Q_OBJECT
public:
PlaylistSettingsPage(SettingsDialog* dialog);
public:
explicit PlaylistSettingsPage(SettingsDialog* dialog);
~PlaylistSettingsPage();
static const char *kSettingsGroup;
void Load();
void Save();
private slots:
private:
private:
Ui_PlaylistSettingsPage* ui_;
};

View File

@@ -58,8 +58,8 @@ class Ui_SettingsDialog;
class SettingsItemDelegate : public QStyledItemDelegate {
public:
SettingsItemDelegate(QObject *parent);
public:
explicit SettingsItemDelegate(QObject *parent);
QSize sizeHint(const QStyleOptionViewItem &option, const QModelIndex &index) const;
void paint(QPainter *painter, const QStyleOptionViewItem &option, const QModelIndex &index) const;
};
@@ -69,7 +69,7 @@ class SettingsDialog : public QDialog {
Q_OBJECT
public:
SettingsDialog(Application *app, QMainWindow *mainwindow, QWidget *parent = nullptr);
explicit SettingsDialog(Application *app, QMainWindow *mainwindow, QWidget *parent = nullptr);
~SettingsDialog();
enum Page {

View File

@@ -34,8 +34,8 @@ class SettingsDialog;
class SettingsPage : public QWidget {
Q_OBJECT
public:
SettingsPage(SettingsDialog *dialog);
public:
explicit SettingsPage(SettingsDialog *dialog);
// Return false to grey out the page's item in the list.
virtual bool IsEnabled() const { return true; }
@@ -49,10 +49,10 @@ public:
// The dialog that this page belongs to.
SettingsDialog *dialog() const { return dialog_; }
signals:
signals:
void NotificationPreview(OSD::Behaviour, QString, QString);
private:
private:
SettingsDialog *dialog_;
};

View File

@@ -44,7 +44,7 @@ class GlobalShortcutsSettingsPage : public SettingsPage {
Q_OBJECT
public:
GlobalShortcutsSettingsPage(SettingsDialog *dialog);
explicit GlobalShortcutsSettingsPage(SettingsDialog *dialog);
~GlobalShortcutsSettingsPage();
static const char *kSettingsGroup;

View File

@@ -34,8 +34,8 @@ class Ui_TranscoderSettingsPage;
class TranscoderSettingsPage : public SettingsPage {
Q_OBJECT
public:
TranscoderSettingsPage(SettingsDialog* dialog);
public:
explicit TranscoderSettingsPage(SettingsDialog* dialog);
~TranscoderSettingsPage();
static const char *kSettingsGroup;
@@ -43,7 +43,7 @@ public:
void Load();
void Save();
private:
private:
Ui_TranscoderSettingsPage* ui_;
};