Add explicit

This commit is contained in:
Jonas Kvinge
2020-04-07 16:49:15 +02:00
parent 3efc496c41
commit 21b2193cd0
199 changed files with 337 additions and 342 deletions

View File

@@ -44,7 +44,7 @@ class TranscodeDialog : public QDialog {
Q_OBJECT
public:
TranscodeDialog(QMainWindow *mainwindow, QWidget *parent = nullptr);
explicit TranscodeDialog(QMainWindow *mainwindow, QWidget *parent = nullptr);
~TranscodeDialog();
static const char *kSettingsGroup;

View File

@@ -40,7 +40,7 @@
#include "core/song.h"
struct TranscoderPreset {
TranscoderPreset() : type_(Song::FileType_Unknown) {}
explicit TranscoderPreset() : type_(Song::FileType_Unknown) {}
TranscoderPreset(Song::FileType type, const QString &name, const QString &extension, const QString &codec_mimetype, const QString &muxer_mimetype_ = QString());
Song::FileType type_;
@@ -55,7 +55,7 @@ class Transcoder : public QObject {
Q_OBJECT
public:
Transcoder(QObject *parent = nullptr, const QString &settings_postfix = "");
explicit Transcoder(QObject *parent = nullptr, const QString &settings_postfix = "");
static TranscoderPreset PresetForFileType(Song::FileType type);
static QList<TranscoderPreset> GetAllPresets();
@@ -92,7 +92,7 @@ class Transcoder : public QObject {
// State held by a job and shared across gstreamer callbacks - lives in the job's thread.
struct JobState {
JobState(const Job &job, Transcoder *parent)
explicit JobState(const Job &job, Transcoder *parent)
: job_(job),
parent_(parent),
pipeline_(nullptr),
@@ -110,7 +110,7 @@ class Transcoder : public QObject {
// Event passed from a GStreamer callback to the Transcoder when a job finishes.
struct JobFinishedEvent : public QEvent {
JobFinishedEvent(JobState *state, bool success);
explicit JobFinishedEvent(JobState *state, bool success);
static int sEventType;

View File

@@ -31,7 +31,7 @@ class Ui_TranscoderOptionsAAC;
class TranscoderOptionsAAC : public TranscoderOptionsInterface {
public:
TranscoderOptionsAAC(QWidget *parent = nullptr);
explicit TranscoderOptionsAAC(QWidget *parent = nullptr);
~TranscoderOptionsAAC();
void Load();

View File

@@ -31,7 +31,7 @@ class Ui_TranscoderOptionsASF;
class TranscoderOptionsASF : public TranscoderOptionsInterface {
public:
TranscoderOptionsASF(QWidget *parent = nullptr);
explicit TranscoderOptionsASF(QWidget *parent = nullptr);
~TranscoderOptionsASF();
void Load();

View File

@@ -39,7 +39,7 @@ class TranscoderOptionsDialog : public QDialog {
Q_OBJECT
public:
TranscoderOptionsDialog(Song::FileType type, QWidget *parent = nullptr);
explicit TranscoderOptionsDialog(Song::FileType type, QWidget *parent = nullptr);
~TranscoderOptionsDialog();
bool is_valid() const { return options_; }
@@ -51,7 +51,7 @@ class TranscoderOptionsDialog : public QDialog {
protected:
void showEvent(QShowEvent *e);
private:
private:
Ui_TranscoderOptionsDialog *ui_;
TranscoderOptionsInterface *options_;
};

View File

@@ -31,7 +31,7 @@ class Ui_TranscoderOptionsFLAC;
class TranscoderOptionsFLAC : public TranscoderOptionsInterface {
public:
TranscoderOptionsFLAC(QWidget *parent = nullptr);
explicit TranscoderOptionsFLAC(QWidget *parent = nullptr);
~TranscoderOptionsFLAC();
void Load();

View File

@@ -27,8 +27,8 @@
#include <QString>
class TranscoderOptionsInterface : public QWidget {
public:
TranscoderOptionsInterface(QWidget *parent) : QWidget(parent) {}
public:
explicit TranscoderOptionsInterface(QWidget *parent) : QWidget(parent) {}
virtual ~TranscoderOptionsInterface() {}
virtual void Load() = 0;

View File

@@ -35,17 +35,17 @@ class TranscoderOptionsMP3 : public TranscoderOptionsInterface {
Q_OBJECT
public:
TranscoderOptionsMP3(QWidget *parent = nullptr);
explicit TranscoderOptionsMP3(QWidget *parent = nullptr);
~TranscoderOptionsMP3();
void Load();
void Save();
private slots:
private slots:
void QualitySliderChanged(int value);
void QualitySpinboxChanged(double value);
private:
private:
static const char* kSettingsGroup;
Ui_TranscoderOptionsMP3 *ui_;

View File

@@ -31,13 +31,13 @@ class Ui_TranscoderOptionsOpus;
class TranscoderOptionsOpus : public TranscoderOptionsInterface {
public:
TranscoderOptionsOpus(QWidget *parent = nullptr);
explicit TranscoderOptionsOpus(QWidget *parent = nullptr);
~TranscoderOptionsOpus();
void Load();
void Save();
private:
private:
static const char* kSettingsGroup;
Ui_TranscoderOptionsOpus* ui_;

View File

@@ -31,13 +31,13 @@ class Ui_TranscoderOptionsSpeex;
class TranscoderOptionsSpeex : public TranscoderOptionsInterface {
public:
TranscoderOptionsSpeex(QWidget *parent = nullptr);
explicit TranscoderOptionsSpeex(QWidget *parent = nullptr);
~TranscoderOptionsSpeex();
void Load();
void Save();
private:
private:
static const char *kSettingsGroup;
Ui_TranscoderOptionsSpeex *ui_;

View File

@@ -31,13 +31,13 @@ class Ui_TranscoderOptionsVorbis;
class TranscoderOptionsVorbis : public TranscoderOptionsInterface {
public:
TranscoderOptionsVorbis(QWidget* parent = nullptr);
explicit TranscoderOptionsVorbis(QWidget* parent = nullptr);
~TranscoderOptionsVorbis();
void Load();
void Save();
private:
private:
static const char *kSettingsGroup;
Ui_TranscoderOptionsVorbis *ui_;

View File

@@ -30,13 +30,13 @@ class Ui_TranscoderOptionsWavPack;
class TranscoderOptionsWavPack : public TranscoderOptionsInterface {
public:
TranscoderOptionsWavPack(QWidget *parent = nullptr);
explicit TranscoderOptionsWavPack(QWidget *parent = nullptr);
~TranscoderOptionsWavPack();
void Load();
void Save();
private:
private:
static const char *kSettingsGroup;
Ui_TranscoderOptionsWavPack *ui_;