From 2657b80adb6c8ba1d300841d156f23fc646d204d Mon Sep 17 00:00:00 2001 From: Jonas Kvinge Date: Sun, 21 Jul 2019 15:12:28 +0200 Subject: [PATCH] Fix memory leak in tagreader --- ext/libstrawberry-tagreader/tagreader.cpp | 8 +++++++- ext/libstrawberry-tagreader/tagreader.h | 1 + 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/ext/libstrawberry-tagreader/tagreader.cpp b/ext/libstrawberry-tagreader/tagreader.cpp index 793dfd35b..5e2e009af 100644 --- a/ext/libstrawberry-tagreader/tagreader.cpp +++ b/ext/libstrawberry-tagreader/tagreader.cpp @@ -136,7 +136,13 @@ const char *kASF_OriginalYear_ID = "WM/OriginalReleaseYear"; TagReader::TagReader() : factory_(new TagLibFileRefFactory), network_(new QNetworkAccessManager), - kEmbeddedCover("(embedded)") {} + kEmbeddedCover("(embedded)") { +} + +TagReader::~TagReader() { + delete network_; + delete factory_; +} pb::tagreader::SongMetadata_FileType TagReader::GuessFileType(TagLib::FileRef *fileref) const { diff --git a/ext/libstrawberry-tagreader/tagreader.h b/ext/libstrawberry-tagreader/tagreader.h index 49937899e..fec657942 100644 --- a/ext/libstrawberry-tagreader/tagreader.h +++ b/ext/libstrawberry-tagreader/tagreader.h @@ -60,6 +60,7 @@ class FileRefFactory; class TagReader { public: TagReader(); + ~TagReader(); pb::tagreader::SongMetadata_FileType GuessFileType(TagLib::FileRef *fileref) const;