dryark/strawberry
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Support arbitrarily large EBU R 128 loudness normalization

Browse Source 
While i have fixed gstreamer's `volume` in
https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/5063
i did not see anything that followed after it was merged, namely, in
https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6222,
the feature was moved, `"volume"` was reverted to only handle `x10` gain,
and one needs to use `"volume-full-range"` instead to do arbitrary gain.
So let's do that.

This, of course, requires run-time detection of the version
of gstreamer base plugins that we are running with,
specifically, we need version `1.24`.
This commit is contained in:
Roman Lebedev
2025-03-12 11:17:42 +03:00
committed by Jonas Kvinge
parent cabf1cb78d
commit 2687dc31cc
2 changed files with 8 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/engine/gstenginepipeline.cpp
View File

@@ -122,6 +122,7 @@ GstEnginePipeline::GstEnginePipeline(QObject *parent)
rg_fallbackgain_(0.0), rg_fallbackgain_(0.0),
rg_compression_(true), rg_compression_(true),
ebur128_loudness_normalization_(false), ebur128_loudness_normalization_(false),
gstreamer_supports_volume_full_range_(false),
ebur128_loudness_normalizing_gain_db_(0.0), ebur128_loudness_normalizing_gain_db_(0.0),
segment_start_(0), segment_start_(0),
segment_start_received_(false), segment_start_received_(false),
@@ -190,6 +191,11 @@ GstEnginePipeline::GstEnginePipeline(QObject *parent)
timer_fader_timeout_->setSingleShot(true); timer_fader_timeout_->setSingleShot(true);
QObject::connect(timer_fader_timeout_, &QTimer::timeout, this, &GstEnginePipeline::FaderTimelineTimeout); QObject::connect(timer_fader_timeout_, &QTimer::timeout, this, &GstEnginePipeline::FaderTimelineTimeout);
guint gst_plugins_base_version_major;
guint gst_plugins_base_version_minor;
gst_plugins_base_version(&gst_plugins_base_version_major, &gst_plugins_base_version_minor, nullptr, nullptr);
gstreamer_supports_volume_full_range_ = (gst_plugins_base_version_major > 1 || (gst_plugins_base_version_major == 1 && gst_plugins_base_version_minor >= 24));
} }
GstEnginePipeline::~GstEnginePipeline() { GstEnginePipeline::~GstEnginePipeline() {
@@ -2040,7 +2046,7 @@ void GstEnginePipeline::UpdateEBUR128LoudnessNormalizingGaindB() {
if (volume_ebur128_) { if (volume_ebur128_) {
auto dB_to_mult = [](const double gain_dB) { return std::pow(10., gain_dB / 20.); }; auto dB_to_mult = [](const double gain_dB) { return std::pow(10., gain_dB / 20.); };
g_object_set(G_OBJECT(volume_ebur128_), "volume", dB_to_mult(ebur128_loudness_normalizing_gain_db_), nullptr); g_object_set(G_OBJECT(volume_ebur128_), gstreamer_supports_volume_full_range_ ? "volume-full-range" : "volume", dB_to_mult(ebur128_loudness_normalizing_gain_db_), nullptr);
} }
} }

1
src/engine/gstenginepipeline.h
View File

@@ -261,6 +261,7 @@ class GstEnginePipeline : public QObject {
// EBU R 128 Loudness Normalization // EBU R 128 Loudness Normalization
bool ebur128_loudness_normalization_; bool ebur128_loudness_normalization_;
bool gstreamer_supports_volume_full_range_;
// Spotify // Spotify
#ifdef HAVE_SPOTIFY #ifdef HAVE_SPOTIFY