Remove redundant check for isNull()

2020-10-02 19:27:47 +02:00
parent 8f42df209a
commit 287f0a3739
14 changed files with 20 additions and 19 deletions
--- a/ext/libstrawberry-tagreader/tagreader.cpp
+++ b/ext/libstrawberry-tagreader/tagreader.cpp
@@ -532,7 +532,8 @@ void TagReader::SetVorbisComments(TagLib::Ogg::XiphComment *vorbis_comments, con

 bool TagReader::SaveFile(const QString &filename, const pb::tagreader::SongMetadata &song) const {

-  if (filename.isNull() || filename.isEmpty()) return false;
+  if (filename.isEmpty()) return false;
+
  qLog(Debug) << "Saving tags to" << filename;
  std::unique_ptr<TagLib::FileRef> fileref(factory_->GetFileRef(filename));;
  if (!fileref || fileref->isNull()) return false;