dryark/strawberry
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove redundant check for isNull()

Browse Source
This commit is contained in:
Jonas Kvinge
2020-10-02 19:27:47 +02:00
parent 8f42df209a
commit 287f0a3739
14 changed files with 20 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/scrobbler/lastfmimport.cpp
View File

@@ -156,7 +156,7 @@ QByteArray LastFMImport::GetReplyData(QNetworkReply *reply) {
QJsonParseError json_error;
QJsonDocument json_doc = QJsonDocument::fromJson(data, &json_error);
int error_code = -1;
if (json_error.error == QJsonParseError::NoError && !json_doc.isNull() && !json_doc.isEmpty() && json_doc.isObject()) {
if (json_error.error == QJsonParseError::NoError && !json_doc.isEmpty() && json_doc.isObject()) {
QJsonObject json_obj = json_doc.object();
if (json_obj.contains("error") && json_obj.contains("message")) {
error_code = json_obj["error"].toInt();
@@ -190,7 +190,7 @@ QJsonObject LastFMImport::ExtractJsonObj(const QByteArray &data) {
Error("Reply from server missing Json data.", data);
return QJsonObject();
}
if (json_doc.isNull() || json_doc.isEmpty()) {
if (json_doc.isEmpty()) {
Error("Received empty Json document.", json_doc);
return QJsonObject();
}