Fix minor code issues

ext/libstrawberry-common/CMakeLists.txt

@@ -7,6 +7,10 @@ set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Wall")
 set(CMAKE_CXX_STANDARD 11)
 set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} --std=c++11 -U__STRICT_ANSI__ -Wall -Woverloaded-virtual -Wno-sign-compare -fpermissive")
 
+if ("${CMAKE_CXX_COMPILER_ID}" STREQUAL "GNU")
+  set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wextra -Wimplicit-fallthrough=0 -Wpedantic")
+endif()
+
 set(SOURCES
   core/closure.cpp
   core/logging.cpp

ext/libstrawberry-common/core/closure.h

@@ -54,7 +54,8 @@ class ClosureBase {
   ObjectHelper *helper_;
 
  private:
-  Q_DISABLE_COPY(ClosureBase);
+  Q_DISABLE_COPY(ClosureBase)
+
 };
 
 // QObject helper as templated QObjects do not work.
@@ -71,7 +72,8 @@ class ObjectHelper : public QObject {
 
  private:
   std::unique_ptr<ClosureBase> closure_;
-  Q_DISABLE_COPY(ObjectHelper);
+  Q_DISABLE_COPY(ObjectHelper)
+
 };
 
 // Helpers for unpacking a variadic template list.

ext/libstrawberry-common/core/logging.cpp

@@ -53,6 +53,9 @@ static QtMessageHandler sOriginalMessageHandler = nullptr;
 
 void GLog(const char *domain, int level, const char *message, void *user_data) {
 
+  Q_UNUSED(domain);
+  Q_UNUSED(user_data);
+
   switch (level) {
     case G_LOG_FLAG_RECURSION:
     case G_LOG_FLAG_FATAL:
@@ -69,6 +72,8 @@ void GLog(const char *domain, int level, const char *message, void *user_data) {
 
 static void MessageHandler(QtMsgType type, const QMessageLogContext &context, const QString &message) {
 
+  Q_UNUSED(context);
+
   if (strncmp(kMessageHandlerMagic, message.toLocal8Bit().data(), kMessageHandlerMagicLength) == 0) {
     fprintf(stderr, "%s\n", message.toLocal8Bit().data() + kMessageHandlerMagicLength);
     return;
@@ -90,6 +95,7 @@ static void MessageHandler(QtMsgType type, const QMessageLogContext &context, co
   if (type == QtFatalMsg) {
     abort();
   }
+
 }
 
 void Init() {

ext/libstrawberry-common/core/messagehandler.h

@@ -103,7 +103,7 @@ public:
 
 protected:
   // Called when a message is received from the socket.
-  virtual void MessageArrived(const MessageType &message) {}
+  virtual void MessageArrived(const MessageType &message) { Q_UNUSED(message); }
 
   // _MessageHandlerBase
   bool RawMessageArrived(const QByteArray &data);