Fix minor code issues

src/internet/internetcollectionviewcontainer.cpp

@@ -54,4 +54,4 @@ InternetCollectionViewContainer::InternetCollectionViewContainer(QWidget *parent
 
 InternetCollectionViewContainer::~InternetCollectionViewContainer() { delete ui_; }
 
-void InternetCollectionViewContainer::contextMenuEvent(QContextMenuEvent *e) {}
+void InternetCollectionViewContainer::contextMenuEvent(QContextMenuEvent *e) { Q_UNUSED(e); }

src/internet/internetsearch.cpp

@@ -221,6 +221,8 @@ int InternetSearch::LoadAlbumCoverAsync(const InternetSearch::Result &result) {
 
 void InternetSearch::AlbumCoverLoaded(const quint64 id, const QUrl &cover_url, const QImage &image) {
 
+  Q_UNUSED(cover_url);
+
   if (!cover_loader_tasks_.contains(id)) return;
   int orig_id = cover_loader_tasks_.take(id);
 

src/internet/internetsearchview.cpp

@@ -575,14 +575,17 @@ void InternetSearchView::SetGroupBy(const CollectionModel::Grouping &g) {
 }
 
 void InternetSearchView::SearchArtistsClicked(bool checked) {
+  Q_UNUSED(checked);
   SetSearchType(InternetSearch::SearchType_Artists);
 }
 
 void InternetSearchView::SearchAlbumsClicked(bool checked) {
+  Q_UNUSED(checked);
   SetSearchType(InternetSearch::SearchType_Albums);
 }
 
 void InternetSearchView::SearchSongsClicked(bool checked) {
+  Q_UNUSED(checked);
   SetSearchType(InternetSearch::SearchType_Songs);
 }
 

src/internet/internetservice.h

@@ -49,9 +49,9 @@ class InternetService : public QObject {
   virtual void InitialLoadSettings() {}
   virtual void ReloadSettings() {}
   virtual QIcon Icon() { return Song::IconForSource(source_); }
-  virtual const bool oauth() { return false; }
-  virtual const bool authenticated() { return false; }
-  virtual int Search(const QString &query, InternetSearch::SearchType type) { return 0; }
+  virtual bool oauth() { return false; }
+  virtual bool authenticated() { return false; }
+  virtual int Search(const QString &query, InternetSearch::SearchType type) { Q_UNUSED(query); Q_UNUSED(type); return 0; }
   virtual void CancelSearch() {}
 
   virtual CollectionBackend *artists_collection_backend() { return nullptr; }
@@ -133,6 +133,6 @@ class InternetService : public QObject {
   QString url_scheme_;
 
 };
-Q_DECLARE_METATYPE(InternetService*);
+Q_DECLARE_METATYPE(InternetService*)
 
 #endif

src/internet/internetsongsview.cpp

@@ -76,7 +76,7 @@ InternetSongsView::~InternetSongsView() { delete ui_; }
 
 void InternetSongsView::ReloadSettings() {}
 
-void InternetSongsView::contextMenuEvent(QContextMenuEvent *e) {}
+void InternetSongsView::contextMenuEvent(QContextMenuEvent *e) { Q_UNUSED(e); }
 
 void InternetSongsView::GetSongs() {
 

src/internet/internetsongsview.h

@@ -51,7 +51,7 @@ class InternetSongsView : public QWidget {
  private slots:
   void contextMenuEvent(QContextMenuEvent *e);
   void GetSongs();
-  void AbortGetSongs();;
+  void AbortGetSongs();
   void SongsFinished(const SongList &songs, const QString &error);
 
  private:

src/internet/internettabsview.cpp

@@ -177,8 +177,7 @@ InternetTabsView::~InternetTabsView() {
 
 void InternetTabsView::ReloadSettings() { ui_->search_view->ReloadSettings(); }
 
-void InternetTabsView::contextMenuEvent(QContextMenuEvent *e) {
-}
+void InternetTabsView::contextMenuEvent(QContextMenuEvent *e) { Q_UNUSED(e); }
 
 void InternetTabsView::GetArtists() {
 

src/internet/localredirectserver.cpp

@@ -298,7 +298,7 @@ void LocalRedirectServer::incomingConnection(qintptr socket_descriptor) {
 
 }
 
-void LocalRedirectServer::SSLErrors(const QList<QSslError> &errors) {}
+void LocalRedirectServer::SSLErrors(const QList<QSslError> &errors) { Q_UNUSED(errors); }
 
 void LocalRedirectServer::Encrypted() {}