Fix minor code issues

This commit is contained in:
Jonas Kvinge
2019-09-15 20:27:32 +02:00
parent 83e10aac27
commit 2d67279180
147 changed files with 644 additions and 329 deletions

View File

@@ -480,6 +480,9 @@ void SubsonicRequest::SongsFinishCheck() {
int SubsonicRequest::ParseSong(Song &song, const QJsonObject &json_obj, const qint64 artist_id_requested, const qint64 album_id_requested, const QString &album_artist) {
Q_UNUSED(artist_id_requested);
Q_UNUSED(album_id_requested);
if (
!json_obj.contains("id") ||
!json_obj.contains("title") ||

View File

@@ -193,6 +193,8 @@ void SubsonicService::HandlePingSSLErrors(QList<QSslError> ssl_errors) {
void SubsonicService::HandlePingReply(QNetworkReply *reply, const QUrl &url, const QString &username, const QString &password) {
Q_UNUSED(url);
reply->deleteLater();
if (reply->error() != QNetworkReply::NoError || reply->attribute(QNetworkRequest::HttpStatusCodeAttribute).toInt() != 200) {

View File

@@ -27,7 +27,9 @@
class Application;
SubsonicUrlHandler::SubsonicUrlHandler(Application *app, SubsonicService *service) : UrlHandler(service), service_(service) {}
SubsonicUrlHandler::SubsonicUrlHandler(Application *app, SubsonicService *service) : UrlHandler(service), service_(service) {
Q_UNUSED(app);
}
UrlHandler::LoadResult SubsonicUrlHandler::StartLoading(const QUrl &url) {

View File

@@ -54,8 +54,6 @@ class SubsonicUrlHandler : public UrlHandler {
typedef QPair<QByteArray, QByteArray> EncodedParam;
typedef QList<EncodedParam> EncodedParamList;
void Error(const QString &error, const QVariant &debug) {}
SubsonicService *service_;
};