dryark/strawberry
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Application: Use shared pointers

Browse Source 
Fixes #1239
This commit is contained in:
Jonas Kvinge
2023-07-21 05:55:24 +02:00
parent d6b53f78ab
commit 2e61235403
316 changed files with 2170 additions and 1643 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
tests/src/songplaylistitem_test.cpp
View File

@@ -30,8 +30,11 @@
#include "test_utils.h"
#include "core/scoped_ptr.h"
#include "playlist/songplaylistitem.h"
using std::make_unique;
// clazy:excludeall=non-pod-global-static
namespace {
@@ -49,7 +52,7 @@ class SongPlaylistItemTest : public ::testing::TestWithParam<const char*> {
song_.Init("Title", "Artist", "Album", 123);
song_.set_url(QUrl::fromLocalFile(absolute_file_name_));
item_ = std::make_unique<SongPlaylistItem>(song_);
item_ = make_unique<SongPlaylistItem>(song_);
if (!absolute_file_name_.startsWith('/'))
absolute_file_name_.prepend('/');
@@ -58,7 +61,7 @@ class SongPlaylistItemTest : public ::testing::TestWithParam<const char*> {
Song song_; // NOLINT(cppcoreguidelines-non-private-member-variables-in-classes)
QTemporaryFile temp_file_; // NOLINT(cppcoreguidelines-non-private-member-variables-in-classes)
QString absolute_file_name_; // NOLINT(cppcoreguidelines-non-private-member-variables-in-classes)
std::unique_ptr<SongPlaylistItem> item_; // NOLINT(cppcoreguidelines-non-private-member-variables-in-classes)
ScopedPtr<SongPlaylistItem> item_; // NOLINT(cppcoreguidelines-non-private-member-variables-in-classes)
};
INSTANTIATE_TEST_SUITE_P(RealFiles, SongPlaylistItemTest, testing::Values( // clazy:exclude=function-args-by-value,clazy-non-pod-global-static