dryark/strawberry
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Use const reference for AlbumCoverLoaderResult

Browse Source
This commit is contained in:
Jonas Kvinge
2023-04-09 22:26:17 +02:00
parent f8d2c7eba3
commit 2f17647cd3
37 changed files with 242 additions and 309 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
src/covermanager/coverfromurldialog.cpp
View File

@@ -21,8 +21,6 @@
#include "config.h"
#include <memory>
#include <QWidget>
#include <QDialog>
#include <QApplication>
@@ -54,11 +52,11 @@ CoverFromURLDialog::~CoverFromURLDialog() {
delete ui_;
}
AlbumCoverImageResultPtr CoverFromURLDialog::Exec() {
AlbumCoverImageResult CoverFromURLDialog::Exec() {
// reset state
ui_->url->setText("");
last_album_cover_.reset();
last_album_cover_ = AlbumCoverImageResult();
QClipboard *clipboard = QApplication::clipboard();
ui_->url->setText(clipboard->text());
@@ -92,17 +90,17 @@ void CoverFromURLDialog::LoadCoverFromURLFinished() {
return;
}
AlbumCoverImageResultPtr result = std::make_shared<AlbumCoverImageResult>();
result->image_data = reply->readAll();
result->image.loadFromData(result->image_data);
result->mime_type = Utilities::MimeTypeFromData(result->image_data);
AlbumCoverImageResult result;
result.image_data = reply->readAll();
result.image.loadFromData(result.image_data);
result.mime_type = Utilities::MimeTypeFromData(result.image_data);
if (!result->image.isNull()) {
if (result.image.isNull()) {
QMessageBox::information(this, tr("Fetching cover error"), tr("The site you requested is not an image!"));
}
else {
last_album_cover_ = result;
QDialog::accept();
}
else {
QMessageBox::information(this, tr("Fetching cover error"), tr("The site you requested is not an image!"));
}
}