Formatting

src/core/database.cpp

@@ -595,7 +595,8 @@ bool Database::IntegrityCheck(QSqlDatabase db) {
     if (message == "ok") {
       ok = true;
       break;
-    } else {
+    }
+    else {
       if (!error_reported) { app_->AddError(tr("Database corruption detected.")); }
       app_->AddError("Database: " + message);
       error_reported = true;
@@ -677,9 +678,9 @@ void Database::BackupFile(const QString &filename) {
   do {
     ret = sqlite3_backup_step(backup, 16);
     const int page_count = sqlite3_backup_pagecount(backup);
-    app_->task_manager()->SetTaskProgress(
-        task_id, page_count - sqlite3_backup_remaining(backup), page_count);
-  } while (ret == SQLITE_OK);
+    app_->task_manager()->SetTaskProgress(task_id, page_count - sqlite3_backup_remaining(backup), page_count);
+  }
+  while (ret == SQLITE_OK);
 
   if (ret != SQLITE_DONE) {
     qLog(Error) << "Database backup failed";

src/core/mainwindow.cpp

@@ -1321,7 +1321,7 @@ void MainWindow::AddToPlaylist(QAction *action) {
   }
 
   SongList songs;
-  for (const PlaylistItemPtr &item : items) {
+  for (const PlaylistItemPtr item : items) {
     songs << item->Metadata();
   }
 
@@ -1587,7 +1587,7 @@ void MainWindow::EditTracks() {
 
 void MainWindow::EditTagDialogAccepted() {
 
-  for (const PlaylistItemPtr &item : edit_tag_dialog_->playlist_items()) {
+  for (const PlaylistItemPtr item : edit_tag_dialog_->playlist_items()) {
     item->Reload();
   }
 
@@ -2256,7 +2256,7 @@ void MainWindow::AutoCompleteTags() {
 
 void MainWindow::AutoCompleteTagsAccepted() {
 
-  for (const PlaylistItemPtr &item : autocomplete_tag_items_) {
+  for (const PlaylistItemPtr item : autocomplete_tag_items_) {
     item->Reload();
   }
 

src/core/utilities.cpp

@@ -265,8 +265,6 @@ bool RemoveRecursive(const QString &path) {
 
   return dir.rmdir(path);
 
-  return true;
-
 }
 
 bool CopyRecursive(const QString &source, const QString &destination) {