dryark/strawberry
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add missing names for parameter variables

Browse Source
This commit is contained in:
Jonas Kvinge
2024-09-28 12:32:12 +02:00
parent f2e28d18bc
commit 3cb0f60900
73 changed files with 365 additions and 164 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
src/core/mergedproxymodel.cpp
View File

@@ -245,20 +245,32 @@ QModelIndex MergedProxyModel::GetActualSourceParent(const QModelIndex &source_pa
}
void MergedProxyModel::RowsAboutToBeInserted(const QModelIndex &source_parent, int start, int end) {
void MergedProxyModel::RowsAboutToBeInserted(const QModelIndex &source_parent, const int start, const int end) {
beginInsertRows(mapFromSource(GetActualSourceParent(source_parent, qobject_cast<QAbstractItemModel*>(sender()))), start, end);
}
void MergedProxyModel::RowsInserted(const QModelIndex&, int, int) {
void MergedProxyModel::RowsInserted(const QModelIndex &source_parent, const int start, const int end) {
Q_UNUSED(source_parent)
Q_UNUSED(start)
Q_UNUSED(end)
endInsertRows();
}
void MergedProxyModel::RowsAboutToBeRemoved(const QModelIndex &source_parent, int start, int end) {
void MergedProxyModel::RowsAboutToBeRemoved(const QModelIndex &source_parent, const int start, const int end) {
beginRemoveRows(mapFromSource(GetActualSourceParent(source_parent, qobject_cast<QAbstractItemModel*>(sender()))), start, end);
}
void MergedProxyModel::RowsRemoved(const QModelIndex&, int, int) {
void MergedProxyModel::RowsRemoved(const QModelIndex &source_parent, const int start, const int end) {
Q_UNUSED(source_parent)
Q_UNUSED(start)
Q_UNUSED(end)
endRemoveRows();
}
QModelIndex MergedProxyModel::mapToSource(const QModelIndex &proxy_index) const {
@@ -294,7 +306,7 @@ QModelIndex MergedProxyModel::mapFromSource(const QModelIndex &source_index) con
}
QModelIndex MergedProxyModel::index(int row, int column, const QModelIndex &parent) const {
QModelIndex MergedProxyModel::index(const int row, const int column, const QModelIndex &parent) const {
QModelIndex source_index;
@@ -380,7 +392,7 @@ bool MergedProxyModel::hasChildren(const QModelIndex &parent) const {
}
QVariant MergedProxyModel::data(const QModelIndex &proxy_index, int role) const {
QVariant MergedProxyModel::data(const QModelIndex &proxy_index, const int role) const {
QModelIndex source_index = mapToSource(proxy_index);
if (!IsKnownModel(source_index.model())) return QVariant();
@@ -407,7 +419,7 @@ Qt::ItemFlags MergedProxyModel::flags(const QModelIndex &idx) const {
}
bool MergedProxyModel::setData(const QModelIndex &idx, const QVariant &value, int role) {
bool MergedProxyModel::setData(const QModelIndex &idx, const QVariant &value, const int role) {
QModelIndex source_index = mapToSource(idx);
@@ -456,7 +468,7 @@ QMimeData *MergedProxyModel::mimeData(const QModelIndexList &indexes) const {
}
bool MergedProxyModel::dropMimeData(const QMimeData *data, Qt::DropAction action, int row, int column, const QModelIndex &parent) {
bool MergedProxyModel::dropMimeData(const QMimeData *data, Qt::DropAction action, const int row, const int column, const QModelIndex &parent) {
if (!parent.isValid()) {
return false;

16
src/core/mergedproxymodel.h
View File

@@ -59,18 +59,18 @@ class MergedProxyModel : public QAbstractProxyModel {
QModelIndex FindSourceParent(const QModelIndex &proxy_index) const;
// QAbstractItemModel
QModelIndex index(int row, int column, const QModelIndex &parent) const override;
QModelIndex index(const int row, const int column, const QModelIndex &parent) const override;
QModelIndex parent(const QModelIndex &child) const override;
int rowCount(const QModelIndex &parent) const override;
int columnCount(const QModelIndex &parent) const override;
QVariant data(const QModelIndex &proxy_index, int role = Qt::DisplayRole) const override;
QVariant data(const QModelIndex &proxy_index, const int role = Qt::DisplayRole) const override;
bool hasChildren(const QModelIndex &parent) const override;
QMap<int, QVariant> itemData(const QModelIndex &proxy_index) const override;
Qt::ItemFlags flags(const QModelIndex &idx) const override;
bool setData(const QModelIndex &idx, const QVariant &value, int role) override;
bool setData(const QModelIndex &idx, const QVariant &value, const int role) override;
QStringList mimeTypes() const override;
QMimeData *mimeData(const QModelIndexList &indexes) const override;
bool dropMimeData(const QMimeData *data, Qt::DropAction action, int row, int column, const QModelIndex &parent) override;
bool dropMimeData(const QMimeData *data, Qt::DropAction action, const int row, const int column, const QModelIndex &parent) override;
bool canFetchMore(const QModelIndex &parent) const override;
void fetchMore(const QModelIndex &parent) override;
@@ -93,10 +93,10 @@ class MergedProxyModel : public QAbstractProxyModel {
void SubModelAboutToBeReset();
void SubModelResetSlot();
void RowsAboutToBeInserted(const QModelIndex &source_parent, int start, int end);
void RowsInserted(const QModelIndex &source_parent, int start, int end);
void RowsAboutToBeRemoved(const QModelIndex &source_parent, int start, int end);
void RowsRemoved(const QModelIndex &source_parent, int start, int end);
void RowsAboutToBeInserted(const QModelIndex &source_parent, const int start, const int end);
void RowsInserted(const QModelIndex &source_parent, const int start, const int end);
void RowsAboutToBeRemoved(const QModelIndex &source_parent, const int start, const int end);
void RowsRemoved(const QModelIndex &source_parent, const int start, const int end);
void DataChanged(const QModelIndex &top_left, const QModelIndex &bottom_right);
void LayoutAboutToBeChanged();

3
src/core/qtsystemtrayicon.cpp
View File

@@ -190,7 +190,8 @@ void SystemTrayIcon::MuteButtonStateChanged(const bool value) {
if (action_mute_) action_mute_->setChecked(value);
}
void SystemTrayIcon::SetNowPlaying(const Song &song, const QUrl&) {
void SystemTrayIcon::SetNowPlaying(const Song &song, const QUrl &url) {
Q_UNUSED(url)
if (available_) setToolTip(song.PrettyTitleWithArtist());
}

2
src/core/qtsystemtrayicon.h
View File

@@ -56,7 +56,7 @@ class SystemTrayIcon : public QSystemTrayIcon {
void SetStopped();
void SetProgress(const int percentage);
void MuteButtonStateChanged(const bool value);
void SetNowPlaying(const Song &song, const QUrl&);
void SetNowPlaying(const Song &song, const QUrl &url);
void ClearNowPlaying();
void LoveVisibilityChanged(const bool value);
void LoveStateChanged(const bool value);

17
src/core/songloader.cpp
View File

@@ -545,7 +545,10 @@ SongLoader::Result SongLoader::LoadRemote() {
#endif
#ifdef HAVE_GSTREAMER
void SongLoader::TypeFound(GstElement*, uint, GstCaps *caps, void *self) {
void SongLoader::TypeFound(GstElement *typefind, const uint probability, GstCaps *caps, void *self) {
Q_UNUSED(typefind)
Q_UNUSED(probability)
SongLoader *instance = static_cast<SongLoader*>(self);
@@ -567,7 +570,9 @@ void SongLoader::TypeFound(GstElement*, uint, GstCaps *caps, void *self) {
#endif
#ifdef HAVE_GSTREAMER
GstPadProbeReturn SongLoader::DataReady(GstPad*, GstPadProbeInfo *info, gpointer self) {
GstPadProbeReturn SongLoader::DataReady(GstPad *pad, GstPadProbeInfo *info, gpointer self) {
Q_UNUSED(pad)
SongLoader *instance = reinterpret_cast<SongLoader*>(self);
@@ -594,7 +599,9 @@ GstPadProbeReturn SongLoader::DataReady(GstPad*, GstPadProbeInfo *info, gpointer
#endif
#ifdef HAVE_GSTREAMER
gboolean SongLoader::BusWatchCallback(GstBus*, GstMessage *msg, gpointer self) {
gboolean SongLoader::BusWatchCallback(GstBus *bus, GstMessage *msg, gpointer self) {
Q_UNUSED(bus)
SongLoader *instance = reinterpret_cast<SongLoader*>(self);
@@ -612,7 +619,9 @@ gboolean SongLoader::BusWatchCallback(GstBus*, GstMessage *msg, gpointer self) {
#endif
#ifdef HAVE_GSTREAMER
GstBusSyncReply SongLoader::BusCallbackSync(GstBus*, GstMessage *msg, gpointer self) {
GstBusSyncReply SongLoader::BusCallbackSync(GstBus *bus, GstMessage *msg, gpointer self) {
Q_UNUSED(bus)
SongLoader *instance = reinterpret_cast<SongLoader*>(self);

8
src/core/songloader.h
View File

@@ -121,10 +121,10 @@ class SongLoader : public QObject {
Result LoadRemote();
// GStreamer callbacks
static void TypeFound(GstElement *typefind, uint probability, GstCaps *caps, void *self);
static GstPadProbeReturn DataReady(GstPad*, GstPadProbeInfo *info, gpointer self);
static GstBusSyncReply BusCallbackSync(GstBus*, GstMessage*, gpointer);
static gboolean BusWatchCallback(GstBus*, GstMessage*, gpointer);
static void TypeFound(GstElement *typefind, const uint probability, GstCaps *caps, void *self);
static GstPadProbeReturn DataReady(GstPad *pad, GstPadProbeInfo *info, gpointer self);
static GstBusSyncReply BusCallbackSync(GstBus *bus, GstMessage *msg, gpointer self);
static gboolean BusWatchCallback(GstBus *bus, GstMessage *msg, gpointer self);
void ErrorMessageReceived(GstMessage *msg);
void EndOfStreamReached();