dryark/strawberry
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add missing names for parameter variables

Browse Source
This commit is contained in:
Jonas Kvinge
2024-09-28 12:32:12 +02:00
parent f2e28d18bc
commit 3cb0f60900
73 changed files with 365 additions and 164 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/engine/chromaprinter.cpp
View File

@@ -189,7 +189,9 @@ QString Chromaprinter::CreateFingerprint() {
}
void Chromaprinter::NewPadCallback(GstElement*, GstPad *pad, gpointer data) {
void Chromaprinter::NewPadCallback(GstElement *element, GstPad *pad, gpointer data) {
Q_UNUSED(element)
Chromaprinter *instance = reinterpret_cast<Chromaprinter*>(data);
GstPad *const audiopad = gst_element_get_static_pad(instance->convert_element_, "sink");

2
src/engine/chromaprinter.h
View File

@@ -49,7 +49,7 @@ class Chromaprinter {
private:
static GstElement *CreateElement(const QString &factory_name, GstElement *bin = nullptr);
static void NewPadCallback(GstElement*, GstPad *pad, gpointer data);
static void NewPadCallback(GstElement *element, GstPad *pad, gpointer data);
static GstFlowReturn NewBufferCallback(GstAppSink *app_sink, gpointer self);
private:

3
src/engine/enginebase.cpp
View File

@@ -114,8 +114,9 @@ QString EngineBase::Description(const Type type) {
}
bool EngineBase::Load(const QUrl &media_url, const QUrl &stream_url, const TrackChangeFlags, const bool force_stop_at_end, const quint64 beginning_nanosec, const qint64 end_nanosec, const std::optional<double> ebur128_integrated_loudness_lufs) {
bool EngineBase::Load(const QUrl &media_url, const QUrl &stream_url, const TrackChangeFlags track_change_flags, const bool force_stop_at_end, const quint64 beginning_nanosec, const qint64 end_nanosec, const std::optional<double> ebur128_integrated_loudness_lufs) {
Q_UNUSED(track_change_flags)
Q_UNUSED(force_stop_at_end);
media_url_ = media_url;

2
src/engine/enginebase.h
View File

@@ -104,7 +104,7 @@ class EngineBase : public QObject {
virtual bool Init() = 0;
virtual State state() const = 0;
virtual void StartPreloading(const QUrl&, const QUrl&, const bool, const qint64, const qint64) {}
virtual bool Load(const QUrl &media_url, const QUrl &stream_url, const TrackChangeFlags change, const bool force_stop_at_end, const quint64 beginning_nanosec, const qint64 end_nanosec, const std::optional<double> ebur128_integrated_loudness_lufs);
virtual bool Load(const QUrl &media_url, const QUrl &stream_url, const TrackChangeFlags track_change_flags, const bool force_stop_at_end, const quint64 beginning_nanosec, const qint64 end_nanosec, const std::optional<double> ebur128_integrated_loudness_lufs);
virtual bool Play(const bool pause, const quint64 offset_nanosec) = 0;
virtual void Stop(const bool stop_after = false) = 0;
virtual void Pause() = 0;

10
src/engine/gstengine.cpp
View File

@@ -1063,7 +1063,10 @@ void GstEngine::UpdateScope(const int chunk_length) {
}
void GstEngine::StreamDiscovered(GstDiscoverer*, GstDiscovererInfo *info, GError*, gpointer self) {
void GstEngine::StreamDiscovered(GstDiscoverer *discoverer, GstDiscovererInfo *info, GError *error, gpointer self) {
Q_UNUSED(discoverer)
Q_UNUSED(error)
GstEngine *instance = reinterpret_cast<GstEngine*>(self);
if (!instance->current_pipeline_) return;
@@ -1146,7 +1149,10 @@ void GstEngine::StreamDiscovered(GstDiscoverer*, GstDiscovererInfo *info, GError
}
void GstEngine::StreamDiscoveryFinished(GstDiscoverer*, gpointer) {}
void GstEngine::StreamDiscoveryFinished(GstDiscoverer *discoverer, gpointer self) {
Q_UNUSED(discoverer)
Q_UNUSED(self)
}
QString GstEngine::GSTdiscovererErrorMessage(GstDiscovererResult result) {

4
src/engine/gstengine.h
View File

@@ -144,8 +144,8 @@ class GstEngine : public EngineBase, public GstBufferConsumer {
void UpdateScope(int chunk_length);
static void StreamDiscovered(GstDiscoverer*, GstDiscovererInfo *info, GError*, gpointer self);
static void StreamDiscoveryFinished(GstDiscoverer*, gpointer);
static void StreamDiscovered(GstDiscoverer *discoverer, GstDiscovererInfo *info, GError *error, gpointer self);
static void StreamDiscoveryFinished(GstDiscoverer *discoverer, gpointer self);
static QString GSTdiscovererErrorMessage(GstDiscovererResult result);
bool OldExclusivePipelineActive() const;

4
src/engine/gststartup.cpp
View File

@@ -48,7 +48,9 @@ using namespace Qt::Literals::StringLiterals;
GThread *GstStartup::kGThread = nullptr;
gpointer GstStartup::GLibMainLoopThreadFunc(gpointer) {
gpointer GstStartup::GLibMainLoopThreadFunc(gpointer data) {
Q_UNUSED(data)
qLog(Info) << "Creating GLib main event loop.";

2
src/engine/gststartup.h
View File

@@ -40,7 +40,7 @@ class GstStartup : public QObject {
private:
static GThread *kGThread;
static gpointer GLibMainLoopThreadFunc(gpointer);
static gpointer GLibMainLoopThreadFunc(gpointer data);
static void InitializeGStreamer();
static void SetEnvironment();