dryark/strawberry
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add missing names for parameter variables

Browse Source
This commit is contained in:
Jonas Kvinge
2024-09-28 12:32:12 +02:00
parent f2e28d18bc
commit 3cb0f60900
73 changed files with 365 additions and 164 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
ext/libstrawberry-common/core/logging.cpp
View File

@@ -115,7 +115,10 @@ class DebugBase : public QDebug {
class BufferedDebug : public DebugBase<BufferedDebug> { class BufferedDebug : public DebugBase<BufferedDebug> {
public: public:
BufferedDebug() = default; BufferedDebug() = default;
explicit BufferedDebug(QtMsgType) : buf_(new QBuffer, later_deleter) { explicit BufferedDebug(QtMsgType msg_type) : buf_(new QBuffer, later_deleter) {
Q_UNUSED(msg_type)
buf_->open(QIODevice::WriteOnly); buf_->open(QIODevice::WriteOnly);
// QDebug doesn't have a method to set a new io device, but swap() allows the devices to be swapped between two instances. // QDebug doesn't have a method to set a new io device, but swap() allows the devices to be swapped between two instances.
@@ -137,7 +140,9 @@ class LoggedDebug : public DebugBase<LoggedDebug> {
explicit LoggedDebug(QtMsgType t) : DebugBase(t) { nospace() << kMessageHandlerMagic; } explicit LoggedDebug(QtMsgType t) : DebugBase(t) { nospace() << kMessageHandlerMagic; }
}; };
static void MessageHandler(QtMsgType type, const QMessageLogContext&, const QString &message) { static void MessageHandler(QtMsgType type, const QMessageLogContext &message_log_context, const QString &message) {
Q_UNUSED(message_log_context)
if (message.startsWith(QLatin1String(kMessageHandlerMagic))) { if (message.startsWith(QLatin1String(kMessageHandlerMagic))) {
QByteArray message_data = message.toUtf8(); QByteArray message_data = message.toUtf8();

4
src/context/contextalbum.cpp
View File

@@ -100,7 +100,9 @@ QSize ContextAlbum::sizeHint() const {
} }
void ContextAlbum::paintEvent(QPaintEvent*) { void ContextAlbum::paintEvent(QPaintEvent *paint_event) {
Q_UNUSED(paint_event)
QPainter p(this); QPainter p(this);
p.setRenderHint(QPainter::SmoothPixmapTransform); p.setRenderHint(QPainter::SmoothPixmapTransform);

2
src/context/contextalbum.h
View File

@@ -56,7 +56,7 @@ class ContextAlbum : public QWidget {
protected: protected:
QSize sizeHint() const override; QSize sizeHint() const override;
void paintEvent(QPaintEvent*) override; void paintEvent(QPaintEvent *paint_event) override;
void mouseDoubleClickEvent(QMouseEvent *e) override; void mouseDoubleClickEvent(QMouseEvent *e) override;
void contextMenuEvent(QContextMenuEvent *e) override; void contextMenuEvent(QContextMenuEvent *e) override;

28
src/core/mergedproxymodel.cpp
View File

@@ -245,20 +245,32 @@ QModelIndex MergedProxyModel::GetActualSourceParent(const QModelIndex &source_pa
} }
void MergedProxyModel::RowsAboutToBeInserted(const QModelIndex &source_parent, int start, int end) { void MergedProxyModel::RowsAboutToBeInserted(const QModelIndex &source_parent, const int start, const int end) {
beginInsertRows(mapFromSource(GetActualSourceParent(source_parent, qobject_cast<QAbstractItemModel*>(sender()))), start, end); beginInsertRows(mapFromSource(GetActualSourceParent(source_parent, qobject_cast<QAbstractItemModel*>(sender()))), start, end);
} }
void MergedProxyModel::RowsInserted(const QModelIndex&, int, int) { void MergedProxyModel::RowsInserted(const QModelIndex &source_parent, const int start, const int end) {
Q_UNUSED(source_parent)
Q_UNUSED(start)
Q_UNUSED(end)
endInsertRows(); endInsertRows();
} }
void MergedProxyModel::RowsAboutToBeRemoved(const QModelIndex &source_parent, int start, int end) { void MergedProxyModel::RowsAboutToBeRemoved(const QModelIndex &source_parent, const int start, const int end) {
beginRemoveRows(mapFromSource(GetActualSourceParent(source_parent, qobject_cast<QAbstractItemModel*>(sender()))), start, end); beginRemoveRows(mapFromSource(GetActualSourceParent(source_parent, qobject_cast<QAbstractItemModel*>(sender()))), start, end);
} }
void MergedProxyModel::RowsRemoved(const QModelIndex&, int, int) { void MergedProxyModel::RowsRemoved(const QModelIndex &source_parent, const int start, const int end) {
Q_UNUSED(source_parent)
Q_UNUSED(start)
Q_UNUSED(end)
endRemoveRows(); endRemoveRows();
} }
QModelIndex MergedProxyModel::mapToSource(const QModelIndex &proxy_index) const { QModelIndex MergedProxyModel::mapToSource(const QModelIndex &proxy_index) const {
@@ -294,7 +306,7 @@ QModelIndex MergedProxyModel::mapFromSource(const QModelIndex &source_index) con
} }
QModelIndex MergedProxyModel::index(int row, int column, const QModelIndex &parent) const { QModelIndex MergedProxyModel::index(const int row, const int column, const QModelIndex &parent) const {
QModelIndex source_index; QModelIndex source_index;
@@ -380,7 +392,7 @@ bool MergedProxyModel::hasChildren(const QModelIndex &parent) const {
} }
QVariant MergedProxyModel::data(const QModelIndex &proxy_index, int role) const { QVariant MergedProxyModel::data(const QModelIndex &proxy_index, const int role) const {
QModelIndex source_index = mapToSource(proxy_index); QModelIndex source_index = mapToSource(proxy_index);
if (!IsKnownModel(source_index.model())) return QVariant(); if (!IsKnownModel(source_index.model())) return QVariant();
@@ -407,7 +419,7 @@ Qt::ItemFlags MergedProxyModel::flags(const QModelIndex &idx) const {
} }
bool MergedProxyModel::setData(const QModelIndex &idx, const QVariant &value, int role) { bool MergedProxyModel::setData(const QModelIndex &idx, const QVariant &value, const int role) {
QModelIndex source_index = mapToSource(idx); QModelIndex source_index = mapToSource(idx);
@@ -456,7 +468,7 @@ QMimeData *MergedProxyModel::mimeData(const QModelIndexList &indexes) const {
} }
bool MergedProxyModel::dropMimeData(const QMimeData *data, Qt::DropAction action, int row, int column, const QModelIndex &parent) { bool MergedProxyModel::dropMimeData(const QMimeData *data, Qt::DropAction action, const int row, const int column, const QModelIndex &parent) {
if (!parent.isValid()) { if (!parent.isValid()) {
return false; return false;

16
src/core/mergedproxymodel.h
View File

@@ -59,18 +59,18 @@ class MergedProxyModel : public QAbstractProxyModel {
QModelIndex FindSourceParent(const QModelIndex &proxy_index) const; QModelIndex FindSourceParent(const QModelIndex &proxy_index) const;
// QAbstractItemModel // QAbstractItemModel
QModelIndex index(int row, int column, const QModelIndex &parent) const override; QModelIndex index(const int row, const int column, const QModelIndex &parent) const override;
QModelIndex parent(const QModelIndex &child) const override; QModelIndex parent(const QModelIndex &child) const override;
int rowCount(const QModelIndex &parent) const override; int rowCount(const QModelIndex &parent) const override;
int columnCount(const QModelIndex &parent) const override; int columnCount(const QModelIndex &parent) const override;
QVariant data(const QModelIndex &proxy_index, int role = Qt::DisplayRole) const override; QVariant data(const QModelIndex &proxy_index, const int role = Qt::DisplayRole) const override;
bool hasChildren(const QModelIndex &parent) const override; bool hasChildren(const QModelIndex &parent) const override;
QMap<int, QVariant> itemData(const QModelIndex &proxy_index) const override; QMap<int, QVariant> itemData(const QModelIndex &proxy_index) const override;
Qt::ItemFlags flags(const QModelIndex &idx) const override; Qt::ItemFlags flags(const QModelIndex &idx) const override;
bool setData(const QModelIndex &idx, const QVariant &value, int role) override; bool setData(const QModelIndex &idx, const QVariant &value, const int role) override;
QStringList mimeTypes() const override; QStringList mimeTypes() const override;
QMimeData *mimeData(const QModelIndexList &indexes) const override; QMimeData *mimeData(const QModelIndexList &indexes) const override;
bool dropMimeData(const QMimeData *data, Qt::DropAction action, int row, int column, const QModelIndex &parent) override; bool dropMimeData(const QMimeData *data, Qt::DropAction action, const int row, const int column, const QModelIndex &parent) override;
bool canFetchMore(const QModelIndex &parent) const override; bool canFetchMore(const QModelIndex &parent) const override;
void fetchMore(const QModelIndex &parent) override; void fetchMore(const QModelIndex &parent) override;
@@ -93,10 +93,10 @@ class MergedProxyModel : public QAbstractProxyModel {
void SubModelAboutToBeReset(); void SubModelAboutToBeReset();
void SubModelResetSlot(); void SubModelResetSlot();
void RowsAboutToBeInserted(const QModelIndex &source_parent, int start, int end); void RowsAboutToBeInserted(const QModelIndex &source_parent, const int start, const int end);
void RowsInserted(const QModelIndex &source_parent, int start, int end); void RowsInserted(const QModelIndex &source_parent, const int start, const int end);
void RowsAboutToBeRemoved(const QModelIndex &source_parent, int start, int end); void RowsAboutToBeRemoved(const QModelIndex &source_parent, const int start, const int end);
void RowsRemoved(const QModelIndex &source_parent, int start, int end); void RowsRemoved(const QModelIndex &source_parent, const int start, const int end);
void DataChanged(const QModelIndex &top_left, const QModelIndex &bottom_right); void DataChanged(const QModelIndex &top_left, const QModelIndex &bottom_right);
void LayoutAboutToBeChanged(); void LayoutAboutToBeChanged();

3
src/core/qtsystemtrayicon.cpp
View File

@@ -190,7 +190,8 @@ void SystemTrayIcon::MuteButtonStateChanged(const bool value) {
if (action_mute_) action_mute_->setChecked(value); if (action_mute_) action_mute_->setChecked(value);
} }
void SystemTrayIcon::SetNowPlaying(const Song &song, const QUrl&) { void SystemTrayIcon::SetNowPlaying(const Song &song, const QUrl &url) {
Q_UNUSED(url)
if (available_) setToolTip(song.PrettyTitleWithArtist()); if (available_) setToolTip(song.PrettyTitleWithArtist());
} }

2
src/core/qtsystemtrayicon.h
View File

@@ -56,7 +56,7 @@ class SystemTrayIcon : public QSystemTrayIcon {
void SetStopped(); void SetStopped();
void SetProgress(const int percentage); void SetProgress(const int percentage);
void MuteButtonStateChanged(const bool value); void MuteButtonStateChanged(const bool value);
void SetNowPlaying(const Song &song, const QUrl&); void SetNowPlaying(const Song &song, const QUrl &url);
void ClearNowPlaying(); void ClearNowPlaying();
void LoveVisibilityChanged(const bool value); void LoveVisibilityChanged(const bool value);
void LoveStateChanged(const bool value); void LoveStateChanged(const bool value);

17
src/core/songloader.cpp
View File

@@ -545,7 +545,10 @@ SongLoader::Result SongLoader::LoadRemote() {
#endif #endif
#ifdef HAVE_GSTREAMER #ifdef HAVE_GSTREAMER
void SongLoader::TypeFound(GstElement*, uint, GstCaps *caps, void *self) { void SongLoader::TypeFound(GstElement *typefind, const uint probability, GstCaps *caps, void *self) {
Q_UNUSED(typefind)
Q_UNUSED(probability)
SongLoader *instance = static_cast<SongLoader*>(self); SongLoader *instance = static_cast<SongLoader*>(self);
@@ -567,7 +570,9 @@ void SongLoader::TypeFound(GstElement*, uint, GstCaps *caps, void *self) {
#endif #endif
#ifdef HAVE_GSTREAMER #ifdef HAVE_GSTREAMER
GstPadProbeReturn SongLoader::DataReady(GstPad*, GstPadProbeInfo *info, gpointer self) { GstPadProbeReturn SongLoader::DataReady(GstPad *pad, GstPadProbeInfo *info, gpointer self) {
Q_UNUSED(pad)
SongLoader *instance = reinterpret_cast<SongLoader*>(self); SongLoader *instance = reinterpret_cast<SongLoader*>(self);
@@ -594,7 +599,9 @@ GstPadProbeReturn SongLoader::DataReady(GstPad*, GstPadProbeInfo *info, gpointer
#endif #endif
#ifdef HAVE_GSTREAMER #ifdef HAVE_GSTREAMER
gboolean SongLoader::BusWatchCallback(GstBus*, GstMessage *msg, gpointer self) { gboolean SongLoader::BusWatchCallback(GstBus *bus, GstMessage *msg, gpointer self) {
Q_UNUSED(bus)
SongLoader *instance = reinterpret_cast<SongLoader*>(self); SongLoader *instance = reinterpret_cast<SongLoader*>(self);
@@ -612,7 +619,9 @@ gboolean SongLoader::BusWatchCallback(GstBus*, GstMessage *msg, gpointer self) {
#endif #endif
#ifdef HAVE_GSTREAMER #ifdef HAVE_GSTREAMER
GstBusSyncReply SongLoader::BusCallbackSync(GstBus*, GstMessage *msg, gpointer self) { GstBusSyncReply SongLoader::BusCallbackSync(GstBus *bus, GstMessage *msg, gpointer self) {
Q_UNUSED(bus)
SongLoader *instance = reinterpret_cast<SongLoader*>(self); SongLoader *instance = reinterpret_cast<SongLoader*>(self);

8
src/core/songloader.h
View File

@@ -121,10 +121,10 @@ class SongLoader : public QObject {
Result LoadRemote(); Result LoadRemote();
// GStreamer callbacks // GStreamer callbacks
static void TypeFound(GstElement *typefind, uint probability, GstCaps *caps, void *self); static void TypeFound(GstElement *typefind, const uint probability, GstCaps *caps, void *self);
static GstPadProbeReturn DataReady(GstPad*, GstPadProbeInfo *info, gpointer self); static GstPadProbeReturn DataReady(GstPad *pad, GstPadProbeInfo *info, gpointer self);
static GstBusSyncReply BusCallbackSync(GstBus*, GstMessage*, gpointer); static GstBusSyncReply BusCallbackSync(GstBus *bus, GstMessage *msg, gpointer self);
static gboolean BusWatchCallback(GstBus*, GstMessage*, gpointer); static gboolean BusWatchCallback(GstBus *bus, GstMessage *msg, gpointer self);
void ErrorMessageReceived(GstMessage *msg); void ErrorMessageReceived(GstMessage *msg);
void EndOfStreamReached(); void EndOfStreamReached();

29
src/device/cddalister.cpp
View File

@@ -39,10 +39,14 @@
QStringList CddaLister::DeviceUniqueIDs() { return devices_list_; } QStringList CddaLister::DeviceUniqueIDs() { return devices_list_; }
QVariantList CddaLister::DeviceIcons(const QString &) { QVariantList CddaLister::DeviceIcons(const QString &id) {
Q_UNUSED(id)
QVariantList icons; QVariantList icons;
icons << QStringLiteral("media-optical"); icons << QStringLiteral("media-optical");
return icons; return icons;
} }
QString CddaLister::DeviceManufacturer(const QString &id) { QString CddaLister::DeviceManufacturer(const QString &id) {
@@ -71,11 +75,24 @@ QString CddaLister::DeviceModel(const QString &id) {
} }
quint64 CddaLister::DeviceCapacity(const QString&) { return 0; } quint64 CddaLister::DeviceCapacity(const QString &id) {
quint64 CddaLister::DeviceFreeSpace(const QString&) { return 0; } Q_UNUSED(id)
QVariantMap CddaLister::DeviceHardwareInfo(const QString&) { return 0;
}
quint64 CddaLister::DeviceFreeSpace(const QString &id) {
Q_UNUSED(id)
return 0;
}
QVariantMap CddaLister::DeviceHardwareInfo(const QString &id) {
Q_UNUSED(id)
return QVariantMap(); return QVariantMap();
} }
@@ -100,7 +117,9 @@ void CddaLister::UnmountDevice(const QString &id) {
cdio_eject_media_drive(id.toLocal8Bit().constData()); cdio_eject_media_drive(id.toLocal8Bit().constData());
} }
void CddaLister::UpdateDeviceFreeSpace(const QString&) {} void CddaLister::UpdateDeviceFreeSpace(const QString &id) {
Q_UNUSED(id)
}
bool CddaLister::Init() { bool CddaLister::Init() {

10
src/device/connecteddevice.cpp
View File

@@ -132,12 +132,18 @@ void ConnectedDevice::Eject() {
} }
bool ConnectedDevice::FinishCopy(bool success, QString&) { bool ConnectedDevice::FinishCopy(bool success, QString &error_text) {
Q_UNUSED(error_text)
lister_->UpdateDeviceFreeSpace(unique_id_); lister_->UpdateDeviceFreeSpace(unique_id_);
return success; return success;
} }
bool ConnectedDevice::FinishDelete(bool success, QString&) { bool ConnectedDevice::FinishDelete(bool success, QString &error_text) {
Q_UNUSED(error_text)
lister_->UpdateDeviceFreeSpace(unique_id_); lister_->UpdateDeviceFreeSpace(unique_id_);
return success; return success;
} }

7
src/device/devicestatefiltermodel.cpp
View File

@@ -38,11 +38,14 @@ DeviceStateFilterModel::DeviceStateFilterModel(QObject *parent, DeviceManager::S
} }
bool DeviceStateFilterModel::filterAcceptsRow(int row, const QModelIndex&) const { bool DeviceStateFilterModel::filterAcceptsRow(const int row, const QModelIndex &parent) const {
Q_UNUSED(parent)
return sourceModel()->index(row, 0).data(DeviceManager::Role_State).toInt() != state_ && sourceModel()->index(row, 0).data(DeviceManager::Role_CopyMusic).toBool(); return sourceModel()->index(row, 0).data(DeviceManager::Role_State).toInt() != state_ && sourceModel()->index(row, 0).data(DeviceManager::Role_CopyMusic).toBool();
} }
void DeviceStateFilterModel::ProxyRowCountChanged(const QModelIndex&, const int, const int) { void DeviceStateFilterModel::ProxyRowCountChanged(const QModelIndex &idx, const int, const int) {
Q_UNUSED(idx)
Q_EMIT IsEmptyChanged(rowCount() == 0); Q_EMIT IsEmptyChanged(rowCount() == 0);

2
src/device/devicestatefiltermodel.h
View File

@@ -45,7 +45,7 @@ class DeviceStateFilterModel : public QSortFilterProxyModel {
void IsEmptyChanged(const bool is_empty); void IsEmptyChanged(const bool is_empty);
protected: protected:
bool filterAcceptsRow(int row, const QModelIndex &parent) const override; bool filterAcceptsRow(const int row, const QModelIndex &parent) const override;
private Q_SLOTS: private Q_SLOTS:
void ProxyReset(); void ProxyReset();

34
src/device/giolister.cpp
View File

@@ -90,7 +90,8 @@ void OperationFinished(F f, GObject *object, GAsyncResult *result) {
} }
void GioLister::VolumeMountFinished(GObject *object, GAsyncResult *result, gpointer) { void GioLister::VolumeMountFinished(GObject *object, GAsyncResult *result, gpointer instance) {
Q_UNUSED(instance)
OperationFinished<GVolume>(std::bind(g_volume_mount_finish, std::placeholders::_1, std::placeholders::_2, std::placeholders::_3), object, result); OperationFinished<GVolume>(std::bind(g_volume_mount_finish, std::placeholders::_1, std::placeholders::_2, std::placeholders::_3), object, result);
} }
@@ -271,24 +272,29 @@ QList<QUrl> GioLister::MakeDeviceUrls(const QString &id) {
} }
void GioLister::VolumeAddedCallback(GVolumeMonitor*, GVolume *v, gpointer d) { void GioLister::VolumeAddedCallback(GVolumeMonitor *volume_monitor, GVolume *volume, gpointer instance) {
static_cast<GioLister*>(d)->VolumeAdded(v); Q_UNUSED(volume_monitor)
static_cast<GioLister*>(instance)->VolumeAdded(volume);
} }
void GioLister::VolumeRemovedCallback(GVolumeMonitor*, GVolume *v, gpointer d) { void GioLister::VolumeRemovedCallback(GVolumeMonitor *volume_monitor, GVolume *volume, gpointer instance) {
static_cast<GioLister*>(d)->VolumeRemoved(v); Q_UNUSED(volume_monitor)
static_cast<GioLister*>(instance)->VolumeRemoved(volume);
} }
void GioLister::MountAddedCallback(GVolumeMonitor*, GMount *m, gpointer d) { void GioLister::MountAddedCallback(GVolumeMonitor *volume_monitor, GMount *mount, gpointer instance) {
static_cast<GioLister*>(d)->MountAdded(m); Q_UNUSED(volume_monitor)
static_cast<GioLister*>(instance)->MountAdded(mount);
} }
void GioLister::MountChangedCallback(GVolumeMonitor*, GMount *m, gpointer d) { void GioLister::MountChangedCallback(GVolumeMonitor *volume_monitor, GMount *mount, gpointer instance) {
static_cast<GioLister*>(d)->MountChanged(m); Q_UNUSED(volume_monitor)
static_cast<GioLister*>(instance)->MountChanged(mount);
} }
void GioLister::MountRemovedCallback(GVolumeMonitor*, GMount *m, gpointer d) { void GioLister::MountRemovedCallback(GVolumeMonitor *volume_monitor, GMount *mount, gpointer instance) {
static_cast<GioLister*>(d)->MountRemoved(m); Q_UNUSED(volume_monitor)
static_cast<GioLister*>(instance)->MountRemoved(mount);
} }
void GioLister::VolumeAdded(GVolume *volume) { void GioLister::VolumeAdded(GVolume *volume) {
@@ -570,11 +576,13 @@ void GioLister::VolumeEjectFinished(GObject *object, GAsyncResult *result, gpoin
OperationFinished<GVolume>(std::bind(g_volume_eject_with_operation_finish, std::placeholders::_1, std::placeholders::_2, std::placeholders::_3), object, result); OperationFinished<GVolume>(std::bind(g_volume_eject_with_operation_finish, std::placeholders::_1, std::placeholders::_2, std::placeholders::_3), object, result);
} }
void GioLister::MountEjectFinished(GObject *object, GAsyncResult *result, gpointer) { void GioLister::MountEjectFinished(GObject *object, GAsyncResult *result, gpointer instance) {
Q_UNUSED(instance)
OperationFinished<GMount>(std::bind(g_mount_eject_with_operation_finish, std::placeholders::_1, std::placeholders::_2, std::placeholders::_3), object, result); OperationFinished<GMount>(std::bind(g_mount_eject_with_operation_finish, std::placeholders::_1, std::placeholders::_2, std::placeholders::_3), object, result);
} }
void GioLister::MountUnmountFinished(GObject *object, GAsyncResult *result, gpointer) { void GioLister::MountUnmountFinished(GObject *object, GAsyncResult *result, gpointer instance) {
Q_UNUSED(instance)
OperationFinished<GMount>(std::bind(g_mount_unmount_with_operation_finish, std::placeholders::_1, std::placeholders::_2, std::placeholders::_3), object, result); OperationFinished<GMount>(std::bind(g_mount_unmount_with_operation_finish, std::placeholders::_1, std::placeholders::_2, std::placeholders::_3), object, result);
} }

18
src/device/giolister.h
View File

@@ -116,17 +116,17 @@ class GioLister : public DeviceLister {
void MountChanged(GMount *mount); void MountChanged(GMount *mount);
void MountRemoved(GMount *mount); void MountRemoved(GMount *mount);
static void VolumeAddedCallback(GVolumeMonitor*, GVolume*, gpointer); static void VolumeAddedCallback(GVolumeMonitor *volume_monitor, GVolume *volume, gpointer instance);
static void VolumeRemovedCallback(GVolumeMonitor*, GVolume*, gpointer); static void VolumeRemovedCallback(GVolumeMonitor *volume_monitor, GVolume *volume, gpointer instance);
static void MountAddedCallback(GVolumeMonitor*, GMount*, gpointer); static void MountAddedCallback(GVolumeMonitor *volume_monitor, GMount*, gpointer instance);
static void MountChangedCallback(GVolumeMonitor*, GMount*, gpointer); static void MountChangedCallback(GVolumeMonitor *volume_monitor, GMount*, gpointer instance);
static void MountRemovedCallback(GVolumeMonitor*, GMount*, gpointer); static void MountRemovedCallback(GVolumeMonitor *volume_monitor, GMount *mount, gpointer instance);
static void VolumeMountFinished(GObject *object, GAsyncResult *result, gpointer); static void VolumeMountFinished(GObject *object, GAsyncResult *result, gpointer instance);
static void VolumeEjectFinished(GObject *object, GAsyncResult *result, gpointer); static void VolumeEjectFinished(GObject *object, GAsyncResult *result, gpointer instance);
static void MountEjectFinished(GObject *object, GAsyncResult *result, gpointer); static void MountEjectFinished(GObject *object, GAsyncResult *result, gpointer instance);
static void MountUnmountFinished(GObject *object, GAsyncResult *result, gpointer); static void MountUnmountFinished(GObject *object, GAsyncResult *result, gpointer instance);
// You MUST hold the mutex while calling this function // You MUST hold the mutex while calling this function
QString FindUniqueIdByMount(GMount *mount) const; QString FindUniqueIdByMount(GMount *mount) const;

4
src/engine/chromaprinter.cpp
View File

@@ -189,7 +189,9 @@ QString Chromaprinter::CreateFingerprint() {
} }
void Chromaprinter::NewPadCallback(GstElement*, GstPad *pad, gpointer data) { void Chromaprinter::NewPadCallback(GstElement *element, GstPad *pad, gpointer data) {
Q_UNUSED(element)
Chromaprinter *instance = reinterpret_cast<Chromaprinter*>(data); Chromaprinter *instance = reinterpret_cast<Chromaprinter*>(data);
GstPad *const audiopad = gst_element_get_static_pad(instance->convert_element_, "sink"); GstPad *const audiopad = gst_element_get_static_pad(instance->convert_element_, "sink");

2
src/engine/chromaprinter.h
View File

@@ -49,7 +49,7 @@ class Chromaprinter {
private: private:
static GstElement *CreateElement(const QString &factory_name, GstElement *bin = nullptr); static GstElement *CreateElement(const QString &factory_name, GstElement *bin = nullptr);
static void NewPadCallback(GstElement*, GstPad *pad, gpointer data); static void NewPadCallback(GstElement *element, GstPad *pad, gpointer data);
static GstFlowReturn NewBufferCallback(GstAppSink *app_sink, gpointer self); static GstFlowReturn NewBufferCallback(GstAppSink *app_sink, gpointer self);
private: private:

3
src/engine/enginebase.cpp
View File

@@ -114,8 +114,9 @@ QString EngineBase::Description(const Type type) {
} }
bool EngineBase::Load(const QUrl &media_url, const QUrl &stream_url, const TrackChangeFlags, const bool force_stop_at_end, const quint64 beginning_nanosec, const qint64 end_nanosec, const std::optional<double> ebur128_integrated_loudness_lufs) { bool EngineBase::Load(const QUrl &media_url, const QUrl &stream_url, const TrackChangeFlags track_change_flags, const bool force_stop_at_end, const quint64 beginning_nanosec, const qint64 end_nanosec, const std::optional<double> ebur128_integrated_loudness_lufs) {
Q_UNUSED(track_change_flags)
Q_UNUSED(force_stop_at_end); Q_UNUSED(force_stop_at_end);
media_url_ = media_url; media_url_ = media_url;

2
src/engine/enginebase.h
View File

@@ -104,7 +104,7 @@ class EngineBase : public QObject {
virtual bool Init() = 0; virtual bool Init() = 0;
virtual State state() const = 0; virtual State state() const = 0;
virtual void StartPreloading(const QUrl&, const QUrl&, const bool, const qint64, const qint64) {} virtual void StartPreloading(const QUrl&, const QUrl&, const bool, const qint64, const qint64) {}
virtual bool Load(const QUrl &media_url, const QUrl &stream_url, const TrackChangeFlags change, const bool force_stop_at_end, const quint64 beginning_nanosec, const qint64 end_nanosec, const std::optional<double> ebur128_integrated_loudness_lufs); virtual bool Load(const QUrl &media_url, const QUrl &stream_url, const TrackChangeFlags track_change_flags, const bool force_stop_at_end, const quint64 beginning_nanosec, const qint64 end_nanosec, const std::optional<double> ebur128_integrated_loudness_lufs);
virtual bool Play(const bool pause, const quint64 offset_nanosec) = 0; virtual bool Play(const bool pause, const quint64 offset_nanosec) = 0;
virtual void Stop(const bool stop_after = false) = 0; virtual void Stop(const bool stop_after = false) = 0;
virtual void Pause() = 0; virtual void Pause() = 0;

10
src/engine/gstengine.cpp
View File

@@ -1063,7 +1063,10 @@ void GstEngine::UpdateScope(const int chunk_length) {
} }
void GstEngine::StreamDiscovered(GstDiscoverer*, GstDiscovererInfo *info, GError*, gpointer self) { void GstEngine::StreamDiscovered(GstDiscoverer *discoverer, GstDiscovererInfo *info, GError *error, gpointer self) {
Q_UNUSED(discoverer)
Q_UNUSED(error)
GstEngine *instance = reinterpret_cast<GstEngine*>(self); GstEngine *instance = reinterpret_cast<GstEngine*>(self);
if (!instance->current_pipeline_) return; if (!instance->current_pipeline_) return;
@@ -1146,7 +1149,10 @@ void GstEngine::StreamDiscovered(GstDiscoverer*, GstDiscovererInfo *info, GError
} }
void GstEngine::StreamDiscoveryFinished(GstDiscoverer*, gpointer) {} void GstEngine::StreamDiscoveryFinished(GstDiscoverer *discoverer, gpointer self) {
Q_UNUSED(discoverer)
Q_UNUSED(self)
}
QString GstEngine::GSTdiscovererErrorMessage(GstDiscovererResult result) { QString GstEngine::GSTdiscovererErrorMessage(GstDiscovererResult result) {

4
src/engine/gstengine.h
View File

@@ -144,8 +144,8 @@ class GstEngine : public EngineBase, public GstBufferConsumer {
void UpdateScope(int chunk_length); void UpdateScope(int chunk_length);
static void StreamDiscovered(GstDiscoverer*, GstDiscovererInfo *info, GError*, gpointer self); static void StreamDiscovered(GstDiscoverer *discoverer, GstDiscovererInfo *info, GError *error, gpointer self);
static void StreamDiscoveryFinished(GstDiscoverer*, gpointer); static void StreamDiscoveryFinished(GstDiscoverer *discoverer, gpointer self);
static QString GSTdiscovererErrorMessage(GstDiscovererResult result); static QString GSTdiscovererErrorMessage(GstDiscovererResult result);
bool OldExclusivePipelineActive() const; bool OldExclusivePipelineActive() const;

4
src/engine/gststartup.cpp
View File

@@ -48,7 +48,9 @@ using namespace Qt::Literals::StringLiterals;
GThread *GstStartup::kGThread = nullptr; GThread *GstStartup::kGThread = nullptr;
gpointer GstStartup::GLibMainLoopThreadFunc(gpointer) { gpointer GstStartup::GLibMainLoopThreadFunc(gpointer data) {
Q_UNUSED(data)
qLog(Info) << "Creating GLib main event loop."; qLog(Info) << "Creating GLib main event loop.";

2
src/engine/gststartup.h
View File

@@ -40,7 +40,7 @@ class GstStartup : public QObject {
private: private:
static GThread *kGThread; static GThread *kGThread;
static gpointer GLibMainLoopThreadFunc(gpointer); static gpointer GLibMainLoopThreadFunc(gpointer data);
static void InitializeGStreamer(); static void InitializeGStreamer();
static void SetEnvironment(); static void SetEnvironment();

8
src/equalizer/equalizer.cpp
View File

@@ -299,7 +299,9 @@ void Equalizer::StereoBalancerEnabledChangedSlot(const bool enabled) {
} }
void Equalizer::StereoBalanceSliderChanged(const int) { void Equalizer::StereoBalanceSliderChanged(const int value) {
Q_UNUSED(value)
Q_EMIT StereoBalanceChanged(stereo_balance()); Q_EMIT StereoBalanceChanged(stereo_balance());
Save(); Save();
@@ -348,7 +350,9 @@ void Equalizer::Save() {
} }
void Equalizer::closeEvent(QCloseEvent*) { void Equalizer::closeEvent(QCloseEvent *e) {
Q_UNUSED(e)
QString name = ui_->preset->currentText(); QString name = ui_->preset->currentText();
if (!presets_.contains(name)) return; if (!presets_.contains(name)) return;

2
src/equalizer/equalizer.h
View File

@@ -71,7 +71,7 @@ class Equalizer : public QDialog {
void EqualizerParametersChanged(const int preamp, const QList<int> &band_gains); void EqualizerParametersChanged(const int preamp, const QList<int> &band_gains);
protected: protected:
void closeEvent(QCloseEvent*) override; void closeEvent(QCloseEvent *e) override;
private Q_SLOTS: private Q_SLOTS:
void StereoBalancerEnabledChangedSlot(const bool enabled); void StereoBalancerEnabledChangedSlot(const bool enabled);

5
src/globalshortcuts/globalshortcut-x11.cpp
View File

@@ -91,7 +91,10 @@ int GlobalShortcut::nativeKeycode(const Qt::Key qt_keycode) {
} }
int GlobalShortcut::nativeKeycode2(const Qt::Key) { return 0; } int GlobalShortcut::nativeKeycode2(const Qt::Key key) {
Q_UNUSED(key)
return 0;
}
bool GlobalShortcut::registerShortcut(const int native_key, const int native_mods) { bool GlobalShortcut::registerShortcut(const int native_key, const int native_mods) {

4
src/globalshortcuts/globalshortcutsbackend-gnome.cpp
View File

@@ -117,7 +117,9 @@ void GlobalShortcutsBackendGnome::DoUnregister() {
} }
void GlobalShortcutsBackendGnome::GnomeMediaKeyPressed(const QString&, const QString &key) { void GlobalShortcutsBackendGnome::GnomeMediaKeyPressed(const QString &application, const QString &key) {
Q_UNUSED(application)
auto shortcuts = manager_->shortcuts(); auto shortcuts = manager_->shortcuts();
if (key == "Play"_L1) shortcuts[QStringLiteral("play_pause")].action->trigger(); if (key == "Play"_L1) shortcuts[QStringLiteral("play_pause")].action->trigger();

4
src/globalshortcuts/globalshortcutsbackend-kde.cpp
View File

@@ -207,7 +207,9 @@ QList<QKeySequence> GlobalShortcutsBackendKDE::ToKeySequenceList(const QList<int
} }
void GlobalShortcutsBackendKDE::GlobalShortcutPressed(const QString &component_unique, const QString &shortcut_unique, qint64) { void GlobalShortcutsBackendKDE::GlobalShortcutPressed(const QString &component_unique, const QString &shortcut_unique, const qint64 timestamp) {
Q_UNUSED(timestamp)
if (QCoreApplication::applicationName() == component_unique && actions_.contains(shortcut_unique)) { if (QCoreApplication::applicationName() == component_unique && actions_.contains(shortcut_unique)) {
const QList<QAction*> actions = actions_.values(shortcut_unique); const QList<QAction*> actions = actions_.values(shortcut_unique);

2
src/globalshortcuts/globalshortcutsbackend-kde.h
View File

@@ -59,7 +59,7 @@ class GlobalShortcutsBackendKDE : public GlobalShortcutsBackend {
private Q_SLOTS: private Q_SLOTS:
void RegisterFinished(QDBusPendingCallWatcher *watcher); void RegisterFinished(QDBusPendingCallWatcher *watcher);
void GlobalShortcutPressed(const QString &component_unique, const QString &shortcut_unique, qint64); void GlobalShortcutPressed(const QString &component_unique, const QString &shortcut_unique, const qint64 timestamp);
private: private:
OrgKdeKGlobalAccelInterface *interface_; OrgKdeKGlobalAccelInterface *interface_;

4
src/globalshortcuts/globalshortcutsbackend-mate.cpp
View File

@@ -117,7 +117,9 @@ void GlobalShortcutsBackendMate::DoUnregister() {
} }
void GlobalShortcutsBackendMate::MateMediaKeyPressed(const QString&, const QString &key) { void GlobalShortcutsBackendMate::MateMediaKeyPressed(const QString &application, const QString &key) {
Q_UNUSED(application)
auto shortcuts = manager_->shortcuts(); auto shortcuts = manager_->shortcuts();
if (key == "Play"_L1) shortcuts[QStringLiteral("play_pause")].action->trigger(); if (key == "Play"_L1) shortcuts[QStringLiteral("play_pause")].action->trigger();

2
src/lyrics/lyricfindlyricsprovider.h
View File

@@ -46,7 +46,7 @@ class LyricFindLyricsProvider : public JsonLyricsProvider {
static QUrl Url(const LyricsSearchRequest &request); static QUrl Url(const LyricsSearchRequest &request);
static QString StringFixup(const QString &text); static QString StringFixup(const QString &text);
void StartSearch(const int id, const LyricsSearchRequest &request) override; void StartSearch(const int id, const LyricsSearchRequest &request) override;
void EndSearch(const int id, const LyricsSearchRequest &request, const LyricsSearchResults &lyrics = LyricsSearchResults()); void EndSearch(const int id, const LyricsSearchRequest &request, const LyricsSearchResults &results = LyricsSearchResults());
void Error(const QString &error, const QVariant &debug = QVariant()) override; void Error(const QString &error, const QVariant &debug = QVariant()) override;
private Q_SLOTS: private Q_SLOTS:

4
src/moodbar/moodbarproxystyle.cpp
View File

@@ -54,7 +54,7 @@ constexpr int kArrowWidth = 17;
constexpr int kArrowHeight = 13; constexpr int kArrowHeight = 13;
} // namespace } // namespace
MoodbarProxyStyle::MoodbarProxyStyle(Application *app, QSlider *slider, QObject*) MoodbarProxyStyle::MoodbarProxyStyle(Application *app, QSlider *slider, QObject *parent)
: QProxyStyle(nullptr), : QProxyStyle(nullptr),
app_(app), app_(app),
slider_(slider), slider_(slider),
@@ -68,6 +68,8 @@ MoodbarProxyStyle::MoodbarProxyStyle(Application *app, QSlider *slider, QObject*
show_moodbar_action_(nullptr), show_moodbar_action_(nullptr),
style_action_group_(nullptr) { style_action_group_(nullptr) {
Q_UNUSED(parent)
slider->setStyle(this); slider->setStyle(this);
slider->installEventFilter(this); slider->installEventFilter(this);

8
src/organize/organizedialog.cpp
View File

@@ -168,14 +168,18 @@ void OrganizeDialog::SetDestinationModel(QAbstractItemModel *model, const bool d
} }
void OrganizeDialog::showEvent(QShowEvent*) { void OrganizeDialog::showEvent(QShowEvent *e) {
Q_UNUSED(e)
LoadGeometry(); LoadGeometry();
LoadSettings(); LoadSettings();
} }
void OrganizeDialog::closeEvent(QCloseEvent*) { void OrganizeDialog::closeEvent(QCloseEvent *e) {
Q_UNUSED(e)
if (!devices_) SaveGeometry(); if (!devices_) SaveGeometry();

4
src/organize/organizedialog.h
View File

@@ -74,8 +74,8 @@ class OrganizeDialog : public QDialog {
void SetPlaylist(const QString &playlist); void SetPlaylist(const QString &playlist);
protected: protected:
void showEvent(QShowEvent*) override; void showEvent(QShowEvent *e) override;
void closeEvent(QCloseEvent*) override; void closeEvent(QCloseEvent *e) override;
private: private:
void LoadGeometry(); void LoadGeometry();

9
src/osd/osdbase.cpp
View File

@@ -451,6 +451,13 @@ bool OSDBase::SupportsTrayPopups() {
return tray_icon_->IsSystemTrayAvailable(); return tray_icon_->IsSystemTrayAvailable();
} }
void OSDBase::ShowMessageNative(const QString&, const QString&, const QString&, const QImage&) { void OSDBase::ShowMessageNative(const QString &summary, const QString &message, const QString &icon, const QImage &image) {
Q_UNUSED(summary)
Q_UNUSED(message)
Q_UNUSED(icon)
Q_UNUSED(image)
qLog(Warning) << "Native notifications are not supported on this OS."; qLog(Warning) << "Native notifications are not supported on this OS.";
} }

18
src/osd/osdpretty.cpp
View File

@@ -292,7 +292,9 @@ QRect OSDPretty::BoxBorder() const {
return rect().adjusted(kDropShadowSize, kDropShadowSize, -kDropShadowSize, -kDropShadowSize); return rect().adjusted(kDropShadowSize, kDropShadowSize, -kDropShadowSize, -kDropShadowSize);
} }
void OSDPretty::paintEvent(QPaintEvent*) { void OSDPretty::paintEvent(QPaintEvent *e) {
Q_UNUSED(e)
QPainter p(this); QPainter p(this);
p.setRenderHint(QPainter::Antialiasing); p.setRenderHint(QPainter::Antialiasing);
@@ -461,7 +463,9 @@ void OSDPretty::Reposition() {
} }
void OSDPretty::enterEvent(QEnterEvent*) { void OSDPretty::enterEvent(QEnterEvent *e) {
Q_UNUSED(e)
if (mode_ == Mode::Popup) { if (mode_ == Mode::Popup) {
setWindowOpacity(0.25); setWindowOpacity(0.25);
@@ -469,8 +473,12 @@ void OSDPretty::enterEvent(QEnterEvent*) {
} }
void OSDPretty::leaveEvent(QEvent*) { void OSDPretty::leaveEvent(QEvent *e) {
Q_UNUSED(e)
setWindowOpacity(1.0); setWindowOpacity(1.0);
} }
void OSDPretty::mousePressEvent(QMouseEvent *e) { void OSDPretty::mousePressEvent(QMouseEvent *e) {
@@ -514,7 +522,9 @@ void OSDPretty::mouseMoveEvent(QMouseEvent *e) {
} }
void OSDPretty::mouseReleaseEvent(QMouseEvent *) { void OSDPretty::mouseReleaseEvent(QMouseEvent *e) {
Q_UNUSED(e)
if (current_screen() && mode_ == Mode::Draggable) { if (current_screen() && mode_ == Mode::Draggable) {
popup_screen_ = current_screen(); popup_screen_ = current_screen();

20
src/playlist/playlist.cpp
View File

@@ -188,7 +188,9 @@ void Playlist::InsertSongItems(const SongList &songs, const int pos, const bool
} }
QVariant Playlist::headerData(const int section, Qt::Orientation, const int role) const { QVariant Playlist::headerData(const int section, Qt::Orientation orientation, const int role) const {
Q_UNUSED(orientation)
if (role != Qt::DisplayRole && role != Qt::ToolTipRole) return QVariant(); if (role != Qt::DisplayRole && role != Qt::ToolTipRole) return QVariant();
@@ -501,7 +503,8 @@ int Playlist::last_played_row() const {
return last_played_item_index_.isValid() ? last_played_item_index_.row() : -1; return last_played_item_index_.isValid() ? last_played_item_index_.row() : -1;
} }
void Playlist::ShuffleModeChanged(const PlaylistSequence::ShuffleMode) { void Playlist::ShuffleModeChanged(const PlaylistSequence::ShuffleMode shuffle_mode) {
Q_UNUSED(shuffle_mode)
ReshuffleIndices(); ReshuffleIndices();
} }
@@ -787,7 +790,10 @@ Qt::DropActions Playlist::supportedDropActions() const {
return Qt::MoveAction | Qt::CopyAction | Qt::LinkAction; return Qt::MoveAction | Qt::CopyAction | Qt::LinkAction;
} }
bool Playlist::dropMimeData(const QMimeData *data, Qt::DropAction action, const int row, int, const QModelIndex&) { bool Playlist::dropMimeData(const QMimeData *data, Qt::DropAction action, const int row, const int column, const QModelIndex &parent_index) {
Q_UNUSED(column)
Q_UNUSED(parent_index)
if (action == Qt::IgnoreAction) return false; if (action == Qt::IgnoreAction) return false;
@@ -2060,7 +2066,9 @@ PlaylistItemPtrList Playlist::collection_items_by_id(const int id) const {
return collection_items_by_id_.values(id); return collection_items_by_id_.values(id);
} }
void Playlist::TracksAboutToBeDequeued(const QModelIndex&, const int begin, const int end) { void Playlist::TracksAboutToBeDequeued(const QModelIndex &idx, const int begin, const int end) {
Q_UNUSED(idx)
for (int i = begin; i <= end; ++i) { for (int i = begin; i <= end; ++i) {
temp_dequeue_change_indexes_ << queue_->mapToSource(queue_->index(i, static_cast<int>(Column::Title))); temp_dequeue_change_indexes_ << queue_->mapToSource(queue_->index(i, static_cast<int>(Column::Title)));
@@ -2078,7 +2086,9 @@ void Playlist::TracksDequeued() {
} }
void Playlist::TracksEnqueued(const QModelIndex&, const int begin, const int end) { void Playlist::TracksEnqueued(const QModelIndex &parent_idx, const int begin, const int end) {
Q_UNUSED(parent_idx)
const QModelIndex &b = queue_->mapToSource(queue_->index(begin, static_cast<int>(Column::Title))); const QModelIndex &b = queue_->mapToSource(queue_->index(begin, static_cast<int>(Column::Title)));
const QModelIndex &e = queue_->mapToSource(queue_->index(end, static_cast<int>(Column::Title))); const QModelIndex &e = queue_->mapToSource(queue_->index(end, static_cast<int>(Column::Title)));

6
src/playlist/playlist.h
View File

@@ -255,7 +255,7 @@ class Playlist : public QAbstractListModel {
QStringList mimeTypes() const override; QStringList mimeTypes() const override;
Qt::DropActions supportedDropActions() const override; Qt::DropActions supportedDropActions() const override;
QMimeData *mimeData(const QModelIndexList &indexes) const override; QMimeData *mimeData(const QModelIndexList &indexes) const override;
bool dropMimeData(const QMimeData *data, Qt::DropAction action, const int row, const int column, const QModelIndex &parent) override; bool dropMimeData(const QMimeData *data, Qt::DropAction action, const int row, const int column, const QModelIndex &parent_index) override;
void sort(const int column_number, const Qt::SortOrder order) override; void sort(const int column_number, const Qt::SortOrder order) override;
bool removeRows(const int row, const int count, const QModelIndex &parent = QModelIndex()) override; bool removeRows(const int row, const int count, const QModelIndex &parent = QModelIndex()) override;
@@ -288,7 +288,7 @@ class Playlist : public QAbstractListModel {
void RemoveUnavailableSongs(); void RemoveUnavailableSongs();
void Shuffle(); void Shuffle();
void ShuffleModeChanged(const PlaylistSequence::ShuffleMode); void ShuffleModeChanged(const PlaylistSequence::ShuffleMode shuffle_mode);
void SetColumnAlignment(const ColumnAlignmentMap &alignment); void SetColumnAlignment(const ColumnAlignmentMap &alignment);
@@ -348,7 +348,7 @@ class Playlist : public QAbstractListModel {
private Q_SLOTS: private Q_SLOTS:
void TracksAboutToBeDequeued(const QModelIndex&, const int begin, const int end); void TracksAboutToBeDequeued(const QModelIndex&, const int begin, const int end);
void TracksDequeued(); void TracksDequeued();
void TracksEnqueued(const QModelIndex&, const int begin, const int end); void TracksEnqueued(const QModelIndex &parent_idx, const int begin, const int end);
void QueueLayoutChanged(); void QueueLayoutChanged();
void SongSaveComplete(TagReaderReply *reply, const QPersistentModelIndex &idx, const Song &old_metadata); void SongSaveComplete(TagReaderReply *reply, const QPersistentModelIndex &idx, const Song &old_metadata);
void ItemReloadComplete(const QPersistentModelIndex &idx, const Song &old_metadata, const bool metadata_edit); void ItemReloadComplete(const QPersistentModelIndex &idx, const Song &old_metadata, const bool metadata_edit);

36
src/playlist/playlistdelegates.cpp
View File

@@ -170,7 +170,9 @@ PlaylistDelegateBase::PlaylistDelegateBase(QObject *parent, const QString &suffi
{ {
} }
QString PlaylistDelegateBase::displayText(const QVariant &value, const QLocale&) const { QString PlaylistDelegateBase::displayText(const QVariant &value, const QLocale &locale) const {
Q_UNUSED(locale)
QString text; QString text;
@@ -297,7 +299,9 @@ bool PlaylistDelegateBase::helpEvent(QHelpEvent *event, QAbstractItemView *view,
} }
QString LengthItemDelegate::displayText(const QVariant &value, const QLocale&) const { QString LengthItemDelegate::displayText(const QVariant &value, const QLocale &locale) const {
Q_UNUSED(locale)
bool ok = false; bool ok = false;
qint64 nanoseconds = value.toLongLong(&ok); qint64 nanoseconds = value.toLongLong(&ok);
@@ -308,7 +312,9 @@ QString LengthItemDelegate::displayText(const QVariant &value, const QLocale&) c
} }
QString SizeItemDelegate::displayText(const QVariant &value, const QLocale&) const { QString SizeItemDelegate::displayText(const QVariant &value, const QLocale &locale) const {
Q_UNUSED(locale)
bool ok = false; bool ok = false;
qint64 bytes = value.toLongLong(&ok); qint64 bytes = value.toLongLong(&ok);
@@ -425,7 +431,10 @@ void TagCompleter::ModelReady() {
} }
QWidget *TagCompletionItemDelegate::createEditor(QWidget *parent, const QStyleOptionViewItem&, const QModelIndex&) const { QWidget *TagCompletionItemDelegate::createEditor(QWidget *parent, const QStyleOptionViewItem &option, const QModelIndex &idx) const {
Q_UNUSED(option)
Q_UNUSED(idx)
QLineEdit *editor = new QLineEdit(parent); QLineEdit *editor = new QLineEdit(parent);
new TagCompleter(backend_, column_, editor); new TagCompleter(backend_, column_, editor);
@@ -434,7 +443,9 @@ QWidget *TagCompletionItemDelegate::createEditor(QWidget *parent, const QStyleOp
} }
QString NativeSeparatorsDelegate::displayText(const QVariant &value, const QLocale&) const { QString NativeSeparatorsDelegate::displayText(const QVariant &value, const QLocale &locale) const {
Q_UNUSED(locale)
const QString string_value = value.toString(); const QString string_value = value.toString();
@@ -458,8 +469,9 @@ QString NativeSeparatorsDelegate::displayText(const QVariant &value, const QLoca
SongSourceDelegate::SongSourceDelegate(QObject *parent) : PlaylistDelegateBase(parent) {} SongSourceDelegate::SongSourceDelegate(QObject *parent) : PlaylistDelegateBase(parent) {}
QString SongSourceDelegate::displayText(const QVariant &value, const QLocale&) const { QString SongSourceDelegate::displayText(const QVariant &value, const QLocale &locale) const {
Q_UNUSED(value); Q_UNUSED(value);
Q_UNUSED(locale)
return QString(); return QString();
} }
@@ -522,7 +534,9 @@ QSize RatingItemDelegate::sizeHint(const QStyleOptionViewItem &option, const QMo
} }
QString RatingItemDelegate::displayText(const QVariant &value, const QLocale&) const { QString RatingItemDelegate::displayText(const QVariant &value, const QLocale &locale) const {
Q_UNUSED(locale)
if (value.isNull() || value.toFloat() <= 0) return QString(); if (value.isNull() || value.toFloat() <= 0) return QString();
@@ -533,7 +547,9 @@ QString RatingItemDelegate::displayText(const QVariant &value, const QLocale&) c
} }
QString Ebur128LoudnessLUFSItemDelegate::displayText(const QVariant &value, const QLocale&) const { QString Ebur128LoudnessLUFSItemDelegate::displayText(const QVariant &value, const QLocale &locale) const {
Q_UNUSED(locale)
bool ok = false; bool ok = false;
double v = value.toDouble(&ok); double v = value.toDouble(&ok);
@@ -543,7 +559,9 @@ QString Ebur128LoudnessLUFSItemDelegate::displayText(const QVariant &value, cons
} }
QString Ebur128LoudnessRangeLUItemDelegate::displayText(const QVariant &value, const QLocale&) const { QString Ebur128LoudnessRangeLUItemDelegate::displayText(const QVariant &value, const QLocale &locale) const {
Q_UNUSED(locale)
bool ok = false; bool ok = false;
double v = value.toDouble(&ok); double v = value.toDouble(&ok);

3
src/playlist/playlistheader.cpp
View File

@@ -164,7 +164,8 @@ void PlaylistHeader::ToggleVisible(const int section) {
Q_EMIT SectionVisibilityChanged(section, !isSectionHidden(section)); Q_EMIT SectionVisibilityChanged(section, !isSectionHidden(section));
} }
void PlaylistHeader::enterEvent(QEnterEvent*) { void PlaylistHeader::enterEvent(QEnterEvent *e) {
Q_UNUSED(e)
Q_EMIT MouseEntered(); Q_EMIT MouseEntered();
} }

7
src/playlist/playlistlistview.cpp
View File

@@ -70,8 +70,13 @@ bool PlaylistListView::ItemsSelected() const {
return selectionModel()->selectedRows().count() > 0; return selectionModel()->selectedRows().count() > 0;
} }
void PlaylistListView::selectionChanged(const QItemSelection&, const QItemSelection&) { void PlaylistListView::selectionChanged(const QItemSelection &selected, const QItemSelection &deselected) {
Q_UNUSED(selected)
Q_UNUSED(deselected)
Q_EMIT ItemsSelectedChanged(selectionModel()->selectedRows().count() > 0); Q_EMIT ItemsSelectedChanged(selectionModel()->selectedRows().count() > 0);
} }
void PlaylistListView::dragEnterEvent(QDragEnterEvent *e) { void PlaylistListView::dragEnterEvent(QDragEnterEvent *e) {

3
src/playlist/playlisttabbar.cpp
View File

@@ -408,7 +408,8 @@ void PlaylistTabBar::dragMoveEvent(QDragMoveEvent *e) {
} }
void PlaylistTabBar::dragLeaveEvent(QDragLeaveEvent*) { void PlaylistTabBar::dragLeaveEvent(QDragLeaveEvent *e) {
Q_UNUSED(e)
drag_hover_timer_.stop(); drag_hover_timer_.stop();
} }

5
src/playlistparsers/asxparser.cpp
View File

@@ -133,7 +133,10 @@ return_song:
} }
void ASXParser::Save(const SongList &songs, QIODevice *device, const QDir&, const PlaylistSettingsPage::PathType) const { void ASXParser::Save(const SongList &songs, QIODevice *device, const QDir &dir, const PlaylistSettingsPage::PathType path_type) const {
Q_UNUSED(dir)
Q_UNUSED(path_type)
QXmlStreamWriter writer(device); QXmlStreamWriter writer(device);
writer.setAutoFormatting(true); writer.setAutoFormatting(true);

10
src/queue/queue.cpp
View File

@@ -148,7 +148,10 @@ int Queue::rowCount(const QModelIndex &parent) const {
return static_cast<int>(source_indexes_.count()); return static_cast<int>(source_indexes_.count());
} }
int Queue::columnCount(const QModelIndex&) const { return 1; } int Queue::columnCount(const QModelIndex &parent) const {
Q_UNUSED(parent)
return 1;
}
QVariant Queue::data(const QModelIndex &proxy_index, int role) const { QVariant Queue::data(const QModelIndex &proxy_index, int role) const {
@@ -356,7 +359,10 @@ QMimeData *Queue::mimeData(const QModelIndexList &indexes) const {
} }
bool Queue::dropMimeData(const QMimeData *data, Qt::DropAction action, int row, int, const QModelIndex&) { bool Queue::dropMimeData(const QMimeData *data, Qt::DropAction action, const int row, const int column, const QModelIndex &parent_index) {
Q_UNUSED(column)
Q_UNUSED(parent_index)
if (action == Qt::IgnoreAction) if (action == Qt::IgnoreAction)
return false; return false;

2
src/queue/queue.h
View File

@@ -74,7 +74,7 @@ class Queue : public QAbstractProxyModel {
QStringList mimeTypes() const override; QStringList mimeTypes() const override;
Qt::DropActions supportedDropActions() const override; Qt::DropActions supportedDropActions() const override;
QMimeData *mimeData(const QModelIndexList &indexes) const override; QMimeData *mimeData(const QModelIndexList &indexes) const override;
bool dropMimeData(const QMimeData *data, Qt::DropAction action, int row, int column, const QModelIndex &parent) override; bool dropMimeData(const QMimeData *data, Qt::DropAction action, const int row, const int column, const QModelIndex &parent_index) override;
Qt::ItemFlags flags(const QModelIndex &idx) const override; Qt::ItemFlags flags(const QModelIndex &idx) const override;
public Q_SLOTS: public Q_SLOTS:

4
src/radios/radioview.cpp
View File

@@ -54,7 +54,9 @@ RadioView::RadioView(QWidget *parent)
RadioView::~RadioView() { delete menu_; } RadioView::~RadioView() { delete menu_; }
void RadioView::showEvent(QShowEvent*) { void RadioView::showEvent(QShowEvent *e) {
Q_UNUSED(e)
if (!initialized_) { if (!initialized_) {
Q_EMIT GetChannels(); Q_EMIT GetChannels();

6
src/settings/notificationssettingspage.cpp
View File

@@ -142,11 +142,13 @@ NotificationsSettingsPage::~NotificationsSettingsPage() {
delete ui_; delete ui_;
} }
void NotificationsSettingsPage::showEvent(QShowEvent*) { void NotificationsSettingsPage::showEvent(QShowEvent *e) {
Q_UNUSED(e)
UpdatePopupVisible(); UpdatePopupVisible();
} }
void NotificationsSettingsPage::hideEvent(QHideEvent*) { void NotificationsSettingsPage::hideEvent(QHideEvent *e) {
Q_UNUSED(e)
UpdatePopupVisible(); UpdatePopupVisible();
} }

4
src/settings/settingsdialog.cpp
View File

@@ -209,7 +209,9 @@ void SettingsDialog::showEvent(QShowEvent *e) {
} }
void SettingsDialog::closeEvent(QCloseEvent*) { void SettingsDialog::closeEvent(QCloseEvent *e) {
Q_UNUSED(e)
SaveGeometry(); SaveGeometry();

4
src/smartplaylists/smartplaylistsearchtermwidgetoverlay.cpp
View File

@@ -80,7 +80,9 @@ void SmartPlaylistSearchTermWidgetOverlay::SetOpacity(const float opacity) {
} }
void SmartPlaylistSearchTermWidgetOverlay::paintEvent(QPaintEvent*) { void SmartPlaylistSearchTermWidgetOverlay::paintEvent(QPaintEvent *e) {
Q_UNUSED(e)
QPainter p(this); QPainter p(this);

4
src/smartplaylists/smartplaylistsview.cpp
View File

@@ -39,7 +39,9 @@ SmartPlaylistsView::SmartPlaylistsView(QWidget *_parent) : QListView(_parent) {
SmartPlaylistsView::~SmartPlaylistsView() = default; SmartPlaylistsView::~SmartPlaylistsView() = default;
void SmartPlaylistsView::selectionChanged(const QItemSelection&, const QItemSelection&) { void SmartPlaylistsView::selectionChanged(const QItemSelection &selected, const QItemSelection &deselected) {
Q_UNUSED(selected)
Q_UNUSED(deselected)
Q_EMIT ItemsSelectedChanged(); Q_EMIT ItemsSelectedChanged();
} }

2
src/smartplaylists/smartplaylistsview.h
View File

@@ -35,7 +35,7 @@ class SmartPlaylistsView : public QListView {
~SmartPlaylistsView(); ~SmartPlaylistsView();
protected: protected:
void selectionChanged(const QItemSelection&, const QItemSelection&) override; void selectionChanged(const QItemSelection &selected, const QItemSelection &deselected) override;
void contextMenuEvent(QContextMenuEvent *e) override; void contextMenuEvent(QContextMenuEvent *e) override;
Q_SIGNALS: Q_SIGNALS:

9
src/streaming/streamingsearchview.cpp
View File

@@ -732,15 +732,18 @@ void StreamingSearchView::SetGroupBy(const CollectionModel::Grouping g) {
} }
void StreamingSearchView::SearchArtistsClicked(const bool) { void StreamingSearchView::SearchArtistsClicked(const bool checked) {
Q_UNUSED(checked)
SetSearchType(StreamingSearchView::SearchType::Artists); SetSearchType(StreamingSearchView::SearchType::Artists);
} }
void StreamingSearchView::SearchAlbumsClicked(const bool) { void StreamingSearchView::SearchAlbumsClicked(const bool checked) {
Q_UNUSED(checked)
SetSearchType(StreamingSearchView::SearchType::Albums); SetSearchType(StreamingSearchView::SearchType::Albums);
} }
void StreamingSearchView::SearchSongsClicked(const bool) { void StreamingSearchView::SearchSongsClicked(const bool checked) {
Q_UNUSED(checked)
SetSearchType(StreamingSearchView::SearchType::Songs); SetSearchType(StreamingSearchView::SearchType::Songs);
} }

6
src/streaming/streamingsearchview.h
View File

@@ -165,9 +165,9 @@ class StreamingSearchView : public QWidget {
void SearchForThis(); void SearchForThis();
void OpenSettingsDialog(); void OpenSettingsDialog();
void SearchArtistsClicked(const bool); void SearchArtistsClicked(const bool checked);
void SearchAlbumsClicked(const bool); void SearchAlbumsClicked(const bool checked);
void SearchSongsClicked(const bool); void SearchSongsClicked(const bool checked);
void GroupByClicked(QAction *action); void GroupByClicked(QAction *action);
void SetGroupBy(const CollectionModel::Grouping g); void SetGroupBy(const CollectionModel::Grouping g);

8
src/transcoder/transcoder.cpp
View File

@@ -350,7 +350,9 @@ Transcoder::StartJobStatus Transcoder::MaybeStartNextJob() {
} }
void Transcoder::NewPadCallback(GstElement*, GstPad *pad, gpointer data) { void Transcoder::NewPadCallback(GstElement *element, GstPad *pad, gpointer data) {
Q_UNUSED(element)
JobState *state = reinterpret_cast<JobState*>(data); JobState *state = reinterpret_cast<JobState*>(data);
GstPad *const audiopad = gst_element_get_static_pad(state->convert_element_, "sink"); GstPad *const audiopad = gst_element_get_static_pad(state->convert_element_, "sink");
@@ -365,7 +367,9 @@ void Transcoder::NewPadCallback(GstElement*, GstPad *pad, gpointer data) {
} }
GstBusSyncReply Transcoder::BusCallbackSync(GstBus*, GstMessage *msg, gpointer data) { GstBusSyncReply Transcoder::BusCallbackSync(GstBus *bus, GstMessage *msg, gpointer data) {
Q_UNUSED(bus)
JobState *state = reinterpret_cast<JobState*>(data); JobState *state = reinterpret_cast<JobState*>(data);
switch (GST_MESSAGE_TYPE(msg)) { switch (GST_MESSAGE_TYPE(msg)) {

4
src/transcoder/transcoder.h
View File

@@ -138,8 +138,8 @@ class Transcoder : public QObject {
GstElement *CreateElementForMimeType(GstElementFactoryListType element_type, const QString &mime_type, GstElement *bin = nullptr); GstElement *CreateElementForMimeType(GstElementFactoryListType element_type, const QString &mime_type, GstElement *bin = nullptr);
void SetElementProperties(const QString &name, GObject *object); void SetElementProperties(const QString &name, GObject *object);
static void NewPadCallback(GstElement*, GstPad *pad, gpointer data); static void NewPadCallback(GstElement *element, GstPad *pad, gpointer data);
static GstBusSyncReply BusCallbackSync(GstBus*, GstMessage *msg, gpointer data); static GstBusSyncReply BusCallbackSync(GstBus *bus, GstMessage *msg, gpointer data);
private: private:
using JobStateList = QList<SharedPtr<JobState>>; using JobStateList = QList<SharedPtr<JobState>>;

6
src/widgets/busyindicator.cpp
View File

@@ -72,11 +72,13 @@ BusyIndicator::~BusyIndicator() {
delete movie_; delete movie_;
} }
void BusyIndicator::showEvent(QShowEvent*) { void BusyIndicator::showEvent(QShowEvent *e) {
Q_UNUSED(e)
movie_->start(); movie_->start();
} }
void BusyIndicator::hideEvent(QHideEvent*) { void BusyIndicator::hideEvent(QHideEvent *e) {
Q_UNUSED(e)
movie_->stop(); movie_->stop();
} }

4
src/widgets/busyindicator.h
View File

@@ -44,8 +44,8 @@ class BusyIndicator : public QWidget {
void set_text(const QString &text); void set_text(const QString &text);
protected: protected:
void showEvent(QShowEvent *event) override; void showEvent(QShowEvent *e) override;
void hideEvent(QHideEvent *event) override; void hideEvent(QHideEvent *e) override;
private: private:
void Init(const QString &text); void Init(const QString &text);

2
src/widgets/fancytabwidget.cpp
View File

@@ -77,7 +77,7 @@ FancyTabWidget::FancyTabWidget(QWidget *parent)
} }
FancyTabWidget::~FancyTabWidget() {} FancyTabWidget::~FancyTabWidget() = default;
void FancyTabWidget::AddTab(QWidget *widget_view, const QString &name, const QIcon &icon, const QString &label) { void FancyTabWidget::AddTab(QWidget *widget_view, const QString &name, const QIcon &icon, const QString &label) {

4
src/widgets/favoritewidget.cpp
View File

@@ -72,7 +72,9 @@ void FavoriteWidget::paintEvent(QPaintEvent *e) {
} }
void FavoriteWidget::mouseDoubleClickEvent(QMouseEvent*) { void FavoriteWidget::mouseDoubleClickEvent(QMouseEvent *e) {
Q_UNUSED(e)
favorite_ = !favorite_; favorite_ = !favorite_;
update(); update();

2
src/widgets/favoritewidget.h
View File

@@ -48,7 +48,7 @@ class FavoriteWidget : public QWidget {
protected: protected:
void paintEvent(QPaintEvent *e) override; void paintEvent(QPaintEvent *e) override;
void mouseDoubleClickEvent(QMouseEvent*) override; void mouseDoubleClickEvent(QMouseEvent *e) override;
private: private:
// The playlist's id this widget belongs to // The playlist's id this widget belongs to

4
src/widgets/freespacebar.cpp
View File

@@ -80,7 +80,9 @@ QSize FreeSpaceBar::sizeHint() const {
return QSize(150, kBarHeight + kLabelBoxPadding + fontMetrics().height()); return QSize(150, kBarHeight + kLabelBoxPadding + fontMetrics().height());
} }
void FreeSpaceBar::paintEvent(QPaintEvent*) { void FreeSpaceBar::paintEvent(QPaintEvent *e) {
Q_UNUSED(e)
// Geometry // Geometry
QRect bar_rect(rect()); QRect bar_rect(rect());

2
src/widgets/freespacebar.h
View File

@@ -50,7 +50,7 @@ class FreeSpaceBar : public QWidget {
QSize sizeHint() const override; QSize sizeHint() const override;
protected: protected:
void paintEvent(QPaintEvent*) override; void paintEvent(QPaintEvent *e) override;
private: private:
struct Label { struct Label {

12
src/widgets/groupediconview.cpp
View File

@@ -132,9 +132,13 @@ void GroupedIconView::rowsInserted(const QModelIndex &parent, int start, int end
LayoutItems(); LayoutItems();
} }
void GroupedIconView::dataChanged(const QModelIndex &topLeft, const QModelIndex &bottomRight, const QList<int>&) { void GroupedIconView::dataChanged(const QModelIndex &top_left, const QModelIndex &bottom_right, const QList<int> &roles) {
QListView::dataChanged(topLeft, bottomRight);
Q_UNUSED(roles)
QListView::dataChanged(top_left, bottom_right);
LayoutItems(); LayoutItems();
} }
void GroupedIconView::LayoutItems() { void GroupedIconView::LayoutItems() {
@@ -363,7 +367,9 @@ QRegion GroupedIconView::visualRegionForSelection(const QItemSelection &selectio
} }
QModelIndex GroupedIconView::moveCursor(CursorAction action, Qt::KeyboardModifiers) { QModelIndex GroupedIconView::moveCursor(CursorAction action, const Qt::KeyboardModifiers keyboard_modifiers) {
Q_UNUSED(keyboard_modifiers)
if (model()->rowCount() == 0) { if (model()->rowCount() == 0) {
return QModelIndex(); return QModelIndex();

4
src/widgets/groupediconview.h
View File

@@ -76,7 +76,7 @@ class GroupedIconView : public QListView {
void set_header_text(const QString &value) { header_text_ = value; } void set_header_text(const QString &value) { header_text_ = value; }
// QAbstractItemView // QAbstractItemView
QModelIndex moveCursor(CursorAction action, Qt::KeyboardModifiers modifiers) override; QModelIndex moveCursor(CursorAction action, const Qt::KeyboardModifiers keyboard_modifiers) override;
void setModel(QAbstractItemModel *model) override; void setModel(QAbstractItemModel *model) override;
static void DrawHeader(QPainter *painter, const QRect rect, const QFont &font, const QPalette &palette, const QString &text); static void DrawHeader(QPainter *painter, const QRect rect, const QFont &font, const QPalette &palette, const QString &text);
@@ -89,7 +89,7 @@ class GroupedIconView : public QListView {
void resizeEvent(QResizeEvent *e) override; void resizeEvent(QResizeEvent *e) override;
// QAbstractItemView // QAbstractItemView
void dataChanged(const QModelIndex &topLeft, const QModelIndex &bottomRight, const QList<int>& = QList<int>()) override; void dataChanged(const QModelIndex &top_left, const QModelIndex &bottom_right, const QList<int> &roles = QList<int>()) override;
QModelIndex indexAt(const QPoint &p) const override; QModelIndex indexAt(const QPoint &p) const override;
void rowsInserted(const QModelIndex &parent, int start, int end) override; void rowsInserted(const QModelIndex &parent, int start, int end) override;
void setSelection(const QRect &rect, QItemSelectionModel::SelectionFlags command) override; void setSelection(const QRect &rect, QItemSelectionModel::SelectionFlags command) override;

4
src/widgets/multiloadingindicator.cpp
View File

@@ -98,7 +98,9 @@ void MultiLoadingIndicator::UpdateText() {
} }
void MultiLoadingIndicator::paintEvent(QPaintEvent*) { void MultiLoadingIndicator::paintEvent(QPaintEvent *e) {
Q_UNUSED(e)
QPainter p(this); QPainter p(this);

2
src/widgets/multiloadingindicator.h
View File

@@ -47,7 +47,7 @@ class MultiLoadingIndicator : public QWidget {
void TaskCountChange(const int tasks); void TaskCountChange(const int tasks);
protected: protected:
void paintEvent(QPaintEvent*) override; void paintEvent(QPaintEvent *e) override;
private Q_SLOTS: private Q_SLOTS:
void UpdateText(); void UpdateText();

8
src/widgets/ratingwidget.cpp
View File

@@ -128,7 +128,9 @@ void RatingWidget::set_rating(const float rating) {
} }
void RatingWidget::paintEvent(QPaintEvent*) { void RatingWidget::paintEvent(QPaintEvent *e) {
Q_UNUSED(e)
QStylePainter p(this); QStylePainter p(this);
@@ -161,7 +163,9 @@ void RatingWidget::mouseMoveEvent(QMouseEvent *e) {
} }
void RatingWidget::leaveEvent(QEvent*) { void RatingWidget::leaveEvent(QEvent *e) {
Q_UNUSED(e)
hover_rating_ = -1.0; hover_rating_ = -1.0;
update(); update();

2
src/widgets/ratingwidget.h
View File

@@ -62,7 +62,7 @@ class RatingWidget : public QWidget {
void paintEvent(QPaintEvent*) override; void paintEvent(QPaintEvent*) override;
void mousePressEvent(QMouseEvent *e) override; void mousePressEvent(QMouseEvent *e) override;
void mouseMoveEvent(QMouseEvent *e) override; void mouseMoveEvent(QMouseEvent *e) override;
void leaveEvent(QEvent*) override; void leaveEvent(QEvent *e) override;
private: private:
RatingPainter painter_; RatingPainter painter_;

4
src/widgets/sliderslider.cpp
View File

@@ -121,7 +121,9 @@ void SliderSlider::mousePressEvent(QMouseEvent *e) {
} }
void SliderSlider::mouseReleaseEvent(QMouseEvent*) { void SliderSlider::mouseReleaseEvent(QMouseEvent *e) {
Q_UNUSED(e)
if (!outside_ && QSlider::value() != prev_value_) { if (!outside_ && QSlider::value() != prev_value_) {
Q_EMIT SliderReleased(value()); Q_EMIT SliderReleased(value());

2
src/widgets/stretchheaderview.h
View File

@@ -47,7 +47,7 @@ class StretchHeaderView : public QHeaderView {
// Serialises the proportional and actual column widths. // Serialises the proportional and actual column widths.
// Use these instead of QHeaderView::restoreState and QHeaderView::saveState to persist the proportional values directly and avoid floating point errors over time. // Use these instead of QHeaderView::restoreState and QHeaderView::saveState to persist the proportional values directly and avoid floating point errors over time.
bool RestoreState(const QByteArray &sdata); bool RestoreState(const QByteArray &state);
QByteArray SaveState() const; QByteArray SaveState() const;
QByteArray ResetState(); QByteArray ResetState();

3
src/widgets/tracksliderpopup.cpp
View File

@@ -75,7 +75,8 @@ void TrackSliderPopup::SetPopupPosition(const QPoint pos) {
UpdatePosition(); UpdatePosition();
} }
void TrackSliderPopup::paintEvent(QPaintEvent*) { void TrackSliderPopup::paintEvent(QPaintEvent *e) {
Q_UNUSED(e)
QPainter p(this); QPainter p(this);
p.drawPixmap(0, 0, pixmap_); p.drawPixmap(0, 0, pixmap_);
} }

15
src/widgets/volumeslider.cpp
View File

@@ -94,7 +94,9 @@ void VolumeSlider::HandleWheel(const int delta) {
} }
void VolumeSlider::paintEvent(QPaintEvent*) { void VolumeSlider::paintEvent(QPaintEvent *e) {
Q_UNUSED(e)
QPainter p(this); QPainter p(this);
@@ -162,7 +164,8 @@ void VolumeSlider::slotAnimTimer() {
} }
void VolumeSlider::paletteChange(const QPalette&) { void VolumeSlider::paletteChange(const QPalette &palette) {
Q_UNUSED(palette)
generateGradient(); generateGradient();
} }
@@ -229,7 +232,9 @@ void VolumeSlider::drawVolumeSliderHandle() {
} }
void VolumeSlider::enterEvent(QEnterEvent*) { void VolumeSlider::enterEvent(QEnterEvent *e) {
Q_UNUSED(e)
anim_enter_ = true; anim_enter_ = true;
anim_count_ = 0; anim_count_ = 0;
@@ -238,7 +243,9 @@ void VolumeSlider::enterEvent(QEnterEvent*) {
} }
void VolumeSlider::leaveEvent(QEvent*) { void VolumeSlider::leaveEvent(QEvent *e) {
Q_UNUSED(e)
// This can happen if you enter and leave the widget quickly // This can happen if you enter and leave the widget quickly
if (anim_count_ == 0) anim_count_ = 1; if (anim_count_ == 0) anim_count_ = 1;

12
src/widgets/volumeslider.h
View File

@@ -48,12 +48,12 @@ class VolumeSlider : public SliderSlider {
void HandleWheel(const int delta); void HandleWheel(const int delta);
protected: protected:
void enterEvent(QEnterEvent*) override; void enterEvent(QEnterEvent *e) override;
void leaveEvent(QEvent*) override; void leaveEvent(QEvent *e) override;
void paintEvent(QPaintEvent*) override; void paintEvent(QPaintEvent *e) override;
virtual void paletteChange(const QPalette&); virtual void paletteChange(const QPalette &palette);
void slideEvent(QMouseEvent*) override; void slideEvent(QMouseEvent *e) override;
void contextMenuEvent(QContextMenuEvent*) override; void contextMenuEvent(QContextMenuEvent *e) override;
void mousePressEvent(QMouseEvent*) override; void mousePressEvent(QMouseEvent*) override;
void wheelEvent(QWheelEvent *e) override; void wheelEvent(QWheelEvent *e) override;