Add const and std::as_const

This commit is contained in:
Jonas Kvinge
2024-04-23 17:15:42 +02:00
parent 24c8d06d41
commit 426de61525
67 changed files with 273 additions and 192 deletions

View File

@@ -21,6 +21,8 @@
#include "config.h"
#include <utility>
#include <QAbstractListModel>
#include <QVariant>
#include <QStringList>
@@ -136,7 +138,7 @@ void SmartPlaylistsModel::Init() {
// Append the new ones
s.beginWriteArray(collection_backend_->songs_table(), playlist_index + unwritten_defaults);
for (; version < default_smart_playlists_.count(); ++version) {
for (PlaylistGeneratorPtr gen : default_smart_playlists_[version]) { // clazy:exclude=range-loop-reference
for (PlaylistGeneratorPtr gen : std::as_const(default_smart_playlists_[version])) {
SaveGenerator(&s, playlist_index++, gen);
}
}
@@ -231,7 +233,8 @@ void SmartPlaylistsModel::DeleteGenerator(const QModelIndex &idx) {
// Rewrite all the items to the settings
s.beginWriteArray(collection_backend_->songs_table(), static_cast<int>(root_->children.count()));
int i = 0;
for (SmartPlaylistsItem *item : root_->children) {
const QList<SmartPlaylistsItem*> children = root_->children;
for (SmartPlaylistsItem *item : children) {
s.setArrayIndex(i++);
s.setValue("name", item->display_text);
s.setValue("type", static_cast<int>(item->smart_playlist_type));