From 4b4c5fc0ab1a96ef1e1f4f2690d442d441ce928f Mon Sep 17 00:00:00 2001
From: Jonas Kvinge <jonas@jkvinge.net>
Date: Fri, 21 Jul 2023 07:17:26 +0200
Subject: [PATCH] Use const reference for `AlbumCoverLoaderOptions::Types`

---
 src/covermanager/albumcoverexporter.cpp      | 2 +-
 src/covermanager/albumcoverexporter.h        | 2 +-
 src/covermanager/albumcoverloaderoptions.cpp | 4 ++--
 src/covermanager/albumcoverloaderoptions.h   | 2 +-
 src/covermanager/coverexportrunnable.cpp     | 2 +-
 src/covermanager/coverexportrunnable.h       | 2 +-
 6 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/src/covermanager/albumcoverexporter.cpp b/src/covermanager/albumcoverexporter.cpp
index dbf3457a7..bb7859fe6 100644
--- a/src/covermanager/albumcoverexporter.cpp
+++ b/src/covermanager/albumcoverexporter.cpp
@@ -44,7 +44,7 @@ void AlbumCoverExporter::SetDialogResult(const AlbumCoverExport::DialogResult &d
   dialog_result_ = dialog_result;
 }
 
-void AlbumCoverExporter::SetCoverTypes(const AlbumCoverLoaderOptions::Types cover_types) {
+void AlbumCoverExporter::SetCoverTypes(const AlbumCoverLoaderOptions::Types &cover_types) {
   cover_types_ = cover_types;
 }
 
diff --git a/src/covermanager/albumcoverexporter.h b/src/covermanager/albumcoverexporter.h
index 705dd47ed..e762d6535 100644
--- a/src/covermanager/albumcoverexporter.h
+++ b/src/covermanager/albumcoverexporter.h
@@ -43,7 +43,7 @@ class AlbumCoverExporter : public QObject {
   static const int kMaxConcurrentRequests;
 
   void SetDialogResult(const AlbumCoverExport::DialogResult &dialog_result);
-  void SetCoverTypes(const AlbumCoverLoaderOptions::Types cover_types);
+  void SetCoverTypes(const AlbumCoverLoaderOptions::Types &cover_types);
   void AddExportRequest(const Song &song);
   void StartExporting();
   void Cancel();
diff --git a/src/covermanager/albumcoverloaderoptions.cpp b/src/covermanager/albumcoverloaderoptions.cpp
index d9a653435..163ba4186 100644
--- a/src/covermanager/albumcoverloaderoptions.cpp
+++ b/src/covermanager/albumcoverloaderoptions.cpp
@@ -23,7 +23,7 @@
 
 #include "settings/coverssettingspage.h"
 
-AlbumCoverLoaderOptions::AlbumCoverLoaderOptions(const Options _options, const QSize _desired_scaled_size, const qreal _device_pixel_ratio, const Types _types)
+AlbumCoverLoaderOptions::AlbumCoverLoaderOptions(const Options _options, const QSize _desired_scaled_size, const qreal _device_pixel_ratio, const Types &_types)
     : options(_options),
       desired_scaled_size(_desired_scaled_size),
       device_pixel_ratio(_device_pixel_ratio),
@@ -56,4 +56,4 @@ AlbumCoverLoaderOptions::Types AlbumCoverLoaderOptions::LoadTypes() {
 
   return cover_types;
 
-}
\ No newline at end of file
+}
diff --git a/src/covermanager/albumcoverloaderoptions.h b/src/covermanager/albumcoverloaderoptions.h
index 4cf131f53..b29e5b969 100644
--- a/src/covermanager/albumcoverloaderoptions.h
+++ b/src/covermanager/albumcoverloaderoptions.h
@@ -43,7 +43,7 @@ class AlbumCoverLoaderOptions {
   };
   using Types = QList<Type>;
 
-  explicit AlbumCoverLoaderOptions(const Options _options = AlbumCoverLoaderOptions::Option::ScaledImage, const QSize _desired_scaled_size = QSize(32, 32), const qreal device_pixel_ratio = 1.0F, const Types _types = QList<AlbumCoverLoaderOptions::Type>() << AlbumCoverLoaderOptions::Type::Embedded << AlbumCoverLoaderOptions::Type::Automatic << AlbumCoverLoaderOptions::Type::Manual);
+  explicit AlbumCoverLoaderOptions(const Options _options = AlbumCoverLoaderOptions::Option::ScaledImage, const QSize _desired_scaled_size = QSize(32, 32), const qreal device_pixel_ratio = 1.0F, const Types &_types = QList<AlbumCoverLoaderOptions::Type>() << AlbumCoverLoaderOptions::Type::Embedded << AlbumCoverLoaderOptions::Type::Automatic << AlbumCoverLoaderOptions::Type::Manual);
 
   Options options;
   QSize desired_scaled_size;
diff --git a/src/covermanager/coverexportrunnable.cpp b/src/covermanager/coverexportrunnable.cpp
index 499f73b79..6857a976f 100644
--- a/src/covermanager/coverexportrunnable.cpp
+++ b/src/covermanager/coverexportrunnable.cpp
@@ -32,7 +32,7 @@
 #include "albumcoverexport.h"
 #include "coverexportrunnable.h"
 
-CoverExportRunnable::CoverExportRunnable(const AlbumCoverExport::DialogResult &dialog_result, const AlbumCoverLoaderOptions::Types cover_types, const Song &song, QObject *parent)
+CoverExportRunnable::CoverExportRunnable(const AlbumCoverExport::DialogResult &dialog_result, const AlbumCoverLoaderOptions::Types &cover_types, const Song &song, QObject *parent)
     : QObject(parent),
       dialog_result_(dialog_result),
       cover_types_(cover_types),
diff --git a/src/covermanager/coverexportrunnable.h b/src/covermanager/coverexportrunnable.h
index cfb3e6a38..9648e3170 100644
--- a/src/covermanager/coverexportrunnable.h
+++ b/src/covermanager/coverexportrunnable.h
@@ -36,7 +36,7 @@ class CoverExportRunnable : public QObject, public QRunnable {
   Q_OBJECT
 
  public:
-  explicit CoverExportRunnable(const AlbumCoverExport::DialogResult &dialog_result, const AlbumCoverLoaderOptions::Types cover_types, const Song &song, QObject *parent = nullptr);
+  explicit CoverExportRunnable(const AlbumCoverExport::DialogResult &dialog_result, const AlbumCoverLoaderOptions::Types &cover_types, const Song &song, QObject *parent = nullptr);
 
   void run() override;