Address code review feedback
- Fix album cover URL: use result.album_cover.cover_url instead of result.cover_url - Convert WINDOWS_MEDIA_CONTROLS to optional_component for better configuration management Co-authored-by: jonaski <10343810+jonaski@users.noreply.github.com>
This commit is contained in:
@@ -296,7 +296,9 @@ if(UNIX AND NOT APPLE)
|
|||||||
endif()
|
endif()
|
||||||
|
|
||||||
if(MSVC)
|
if(MSVC)
|
||||||
set(HAVE_WINDOWS_MEDIA_CONTROLS ON)
|
optional_component(WINDOWS_MEDIA_CONTROLS ON "Windows Media Transport Controls"
|
||||||
|
DEPENDS "MSVC compiler" MSVC
|
||||||
|
)
|
||||||
endif()
|
endif()
|
||||||
|
|
||||||
optional_component(SONGFINGERPRINTING ON "Song fingerprinting and tracking"
|
optional_component(SONGFINGERPRINTING ON "Song fingerprinting and tracking"
|
||||||
|
|||||||
@@ -246,7 +246,7 @@ void WindowsMediaController::AlbumCoverLoaded(const Song &song, const AlbumCover
|
|||||||
}
|
}
|
||||||
|
|
||||||
// Update metadata with album cover
|
// Update metadata with album cover
|
||||||
UpdateMetadata(song, result.temp_cover_url.isEmpty() ? result.cover_url : result.temp_cover_url);
|
UpdateMetadata(song, result.temp_cover_url.isEmpty() ? result.album_cover.cover_url : result.temp_cover_url);
|
||||||
}
|
}
|
||||||
|
|
||||||
void WindowsMediaController::UpdateMetadata(const Song &song, const QUrl &art_url) {
|
void WindowsMediaController::UpdateMetadata(const Song &song, const QUrl &art_url) {
|
||||||
|
|||||||
Reference in New Issue
Block a user