Prefer ICU to transliterate characters when available

Fixes #1008
2022-07-28 04:01:58 +02:00
parent 538c759fef
commit 564211aceb
17 changed files with 95 additions and 19 deletions
--- a/tests/src/organizeformat_test.cpp
+++ b/tests/src/organizeformat_test.cpp
@@ -176,8 +176,18 @@ TEST_F(OrganizeFormatTest, ReplaceNonAscii) {
  format_.set_remove_non_ascii(true);
  EXPECT_EQ("Royksopp", format_.GetFilenameForSong(song_));

+  song_.set_artist("");
+  EXPECT_EQ("", format_.GetFilenameForSong(song_));
+
+#ifdef HAVE_ICU
+
  song_.set_artist(QString::fromUtf8("Владимир Высоцкий"));
-  EXPECT_EQ("_________________", format_.GetFilenameForSong(song_));
+  EXPECT_EQ("Vladimir_Vysockij", format_.GetFilenameForSong(song_));
+
+  song_.set_artist(QString::fromUtf8("エックス・ジャパン"));
+  EXPECT_EQ("ekkusujapan", format_.GetFilenameForSong(song_));
+
+#endif

 }