dryark/strawberry
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove redundant initialization

Browse Source
This commit is contained in:
Jonas Kvinge
2020-06-15 00:11:52 +02:00
parent 13b60351a6
commit 56caab4461
21 changed files with 32 additions and 38 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
3rdparty/taglib/ape/apetag.cpp vendored
View File

@@ -86,9 +86,9 @@ class APE::Tag::TagPrivate {
// public methods
////////////////////////////////////////////////////////////////////////////////
APE::Tag::Tag() : Strawberry_TagLib::TagLib::Tag(), d(new TagPrivate()) {}
APE::Tag::Tag() : d(new TagPrivate()) {}
APE::Tag::Tag(Strawberry_TagLib::TagLib::File *file, long footerLocation) : Strawberry_TagLib::TagLib::Tag(), d(new TagPrivate()) {
APE::Tag::Tag(Strawberry_TagLib::TagLib::File *file, long footerLocation) : d(new TagPrivate()) {
d->file = file;
d->footerLocation = footerLocation;

2
3rdparty/taglib/asf/asftag.cpp vendored
View File

@@ -38,7 +38,7 @@ class ASF::Tag::TagPrivate {
AttributeListMap attributeListMap;
};
ASF::Tag::Tag() : Strawberry_TagLib::TagLib::Tag(), d(new TagPrivate()) {
ASF::Tag::Tag() : d(new TagPrivate()) {
}
ASF::Tag::~Tag() {

2
3rdparty/taglib/dsdiff/dsdiffdiintag.cpp vendored
View File

@@ -39,7 +39,7 @@ class DSDIFF::DIIN::Tag::TagPrivate {
String artist;
};
DSDIFF::DIIN::Tag::Tag() : Strawberry_TagLib::TagLib::Tag() {
DSDIFF::DIIN::Tag::Tag() {
d = new TagPrivate;
}

2
3rdparty/taglib/fileref.cpp vendored
View File

@@ -274,7 +274,7 @@ File *createInternal(FileName fileName, bool readAudioProperties, AudioPropertie
class FileRef::FileRefPrivate : public RefCounter {
public:
FileRefPrivate() : RefCounter(), file(nullptr), stream(nullptr) {}
FileRefPrivate() : file(nullptr), stream(nullptr) {}
~FileRefPrivate() {
delete file;

2
3rdparty/taglib/it/itfile.cpp vendored
View File

@@ -35,7 +35,7 @@ using namespace IT;
class IT::File::FilePrivate {
public:
explicit FilePrivate(AudioProperties::ReadStyle propertiesStyle) : tag(), properties(propertiesStyle) {}
explicit FilePrivate(AudioProperties::ReadStyle propertiesStyle) : properties(propertiesStyle) {}
Mod::Tag tag;
IT::Properties properties;

2
3rdparty/taglib/mod/modtag.cpp vendored
View File

@@ -40,7 +40,7 @@ class Mod::Tag::TagPrivate {
String trackerName;
};
Mod::Tag::Tag() : Strawberry_TagLib::TagLib::Tag(), d(new TagPrivate()) {}
Mod::Tag::Tag() : d(new TagPrivate()) {}
Mod::Tag::~Tag() {
delete d;

2
3rdparty/taglib/mp4/mp4coverart.cpp vendored
View File

@@ -32,7 +32,7 @@ using namespace Strawberry_TagLib::TagLib;
class MP4::CoverArt::CoverArtPrivate : public RefCounter {
public:
CoverArtPrivate() : RefCounter(), format(MP4::CoverArt::JPEG) {}
CoverArtPrivate() : format(MP4::CoverArt::JPEG) {}
Format format;
ByteVector data;

2
3rdparty/taglib/mp4/mp4item.cpp vendored
View File

@@ -32,7 +32,7 @@ using namespace Strawberry_TagLib::TagLib;
class MP4::Item::ItemPrivate : public RefCounter {
public:
ItemPrivate() : RefCounter(), valid(true), atomDataType(TypeUndefined) {}
ItemPrivate() : valid(true), atomDataType(TypeUndefined) {}
bool valid;
AtomDataType atomDataType;

4
3rdparty/taglib/mpeg/id3v1/id3v1tag.cpp vendored
View File

@@ -80,9 +80,9 @@ ByteVector ID3v1::StringHandler::render(const String &s) const {
// public methods
////////////////////////////////////////////////////////////////////////////////
ID3v1::Tag::Tag() : Strawberry_TagLib::TagLib::Tag(), d(new TagPrivate()) {}
ID3v1::Tag::Tag() : d(new TagPrivate()) {}
ID3v1::Tag::Tag(File *file, long tagOffset) : Strawberry_TagLib::TagLib::Tag(), d(new TagPrivate()) {
ID3v1::Tag::Tag(File *file, long tagOffset) : d(new TagPrivate()) {
d->file = file;
d->tagOffset = tagOffset;

4
3rdparty/taglib/mpeg/id3v2/id3v2tag.cpp vendored
View File

@@ -99,11 +99,11 @@ String Latin1StringHandler::parse(const ByteVector &data) const {
// public members
////////////////////////////////////////////////////////////////////////////////
ID3v2::Tag::Tag() : Strawberry_TagLib::TagLib::Tag(), d(new TagPrivate()) {
ID3v2::Tag::Tag() : d(new TagPrivate()) {
d->factory = FrameFactory::instance();
}
ID3v2::Tag::Tag(File *file, long tagOffset, const FrameFactory *factory) : Strawberry_TagLib::TagLib::Tag(), d(new TagPrivate()) {
ID3v2::Tag::Tag(File *file, long tagOffset, const FrameFactory *factory) : d(new TagPrivate()) {
d->factory = factory;
d->file = file;
d->tagOffset = tagOffset;

4
3rdparty/taglib/ogg/xiphcomment.cpp vendored
View File

@@ -57,9 +57,9 @@ class Ogg::XiphComment::XiphCommentPrivate {
// public members
////////////////////////////////////////////////////////////////////////////////
Ogg::XiphComment::XiphComment() : Strawberry_TagLib::TagLib::Tag(), d(new XiphCommentPrivate()) {}
Ogg::XiphComment::XiphComment() : d(new XiphCommentPrivate()) {}
Ogg::XiphComment::XiphComment(const ByteVector &data) : Strawberry_TagLib::TagLib::Tag(), d(new XiphCommentPrivate()) {
Ogg::XiphComment::XiphComment(const ByteVector &data) : d(new XiphCommentPrivate()) {
parse(data);
}

4
3rdparty/taglib/riff/wav/infotag.cpp vendored
View File

@@ -62,11 +62,11 @@ ByteVector RIFF::Info::StringHandler::render(const String &s) const {
// public members
////////////////////////////////////////////////////////////////////////////////
RIFF::Info::Tag::Tag(const ByteVector &data) : Strawberry_TagLib::TagLib::Tag(), d(new TagPrivate()) {
RIFF::Info::Tag::Tag(const ByteVector &data) : d(new TagPrivate()) {
parse(data);
}
RIFF::Info::Tag::Tag() : Strawberry_TagLib::TagLib::Tag(), d(new TagPrivate()) {}
RIFF::Info::Tag::Tag() : d(new TagPrivate()) {}
RIFF::Info::Tag::~Tag() {
delete d;

2
3rdparty/taglib/toolkit/tbytevectorlist.cpp vendored
View File

@@ -58,7 +58,7 @@ ByteVectorList ByteVectorList::split(const ByteVector &v, const ByteVector &patt
// public members
////////////////////////////////////////////////////////////////////////////////
ByteVectorList::ByteVectorList() : List<ByteVector>(), d(nullptr) {}
ByteVectorList::ByteVectorList() : d(nullptr) {}
ByteVectorList::~ByteVectorList() {}

2
3rdparty/taglib/toolkit/tpropertymap.cpp vendored
View File

@@ -28,7 +28,7 @@
using namespace Strawberry_TagLib::TagLib;
PropertyMap::PropertyMap() : SimplePropertyMap() {}
PropertyMap::PropertyMap() {}
PropertyMap::PropertyMap(const SimplePropertyMap &m) {

2
3rdparty/taglib/toolkit/tstring.cpp vendored
View File

@@ -145,7 +145,7 @@ namespace TagLib {
class String::StringPrivate : public RefCounter {
public:
StringPrivate() : RefCounter() {}
StringPrivate() {}
/*!
* Stores string in UTF-16. The byte order depends on the CPU endian.

6
3rdparty/taglib/toolkit/tstringlist.cpp vendored
View File

@@ -54,13 +54,13 @@ StringList StringList::split(const String &s, const String &pattern) {
// public members
////////////////////////////////////////////////////////////////////////////////
StringList::StringList() : List<String>(), d(nullptr) {}
StringList::StringList() : d(nullptr) {}
StringList::StringList(const String &s) : List<String>(), d(nullptr) {
StringList::StringList(const String &s) : d(nullptr) {
append(s);
}
StringList::StringList(const ByteVectorList &bl, String::Type t) : List<String>() {
StringList::StringList(const ByteVectorList &bl, String::Type t) {
ByteVectorList::ConstIterator i = bl.begin();
for (; i != bl.end(); i++) {

10
3rdparty/taglib/xm/xmfile.cpp vendored
View File

@@ -82,8 +82,7 @@ class Reader {
class SkipReader : public Reader {
public:
explicit SkipReader(unsigned int size) : m_size(size) {
}
explicit SkipReader(unsigned int size) : m_size(size) {}
unsigned int read(Strawberry_TagLib::TagLib::File &file, unsigned int limit) {
unsigned int count = std::min(m_size, limit);
@@ -102,8 +101,7 @@ class SkipReader : public Reader {
template<typename T>
class ValueReader : public Reader {
public:
explicit ValueReader(T &_value) : value(_value) {
}
explicit ValueReader(T &_value) : value(_value) {}
protected:
T &value;
@@ -306,9 +304,7 @@ class StructReader : public Reader {
class XM::File::FilePrivate {
public:
explicit FilePrivate(AudioProperties::ReadStyle propertiesStyle)
: tag(), properties(propertiesStyle) {
}
explicit FilePrivate(AudioProperties::ReadStyle propertiesStyle) : properties(propertiesStyle) {}
Mod::Tag tag;
XM::Properties properties;