dryark/strawberry
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

TidalRequest: Only return error when no songs are received

Browse Source 
Fixes #1061
This commit is contained in:
Jonas Kvinge
2022-10-28 21:46:12 +02:00
parent 41aeb0ac80
commit 5ca6513c04
2 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/tidal/tidalrequest.cpp
View File

@@ -1254,21 +1254,21 @@ void TidalRequest::FinishCheck() {
album_covers_received_ >= album_covers_requested_ album_covers_received_ >= album_covers_requested_
) { ) {
finished_ = true; finished_ = true;
if (errors_.isEmpty()) { if (songs_.isEmpty()) {
if (songs_.isEmpty()) { if (errors_.isEmpty()) {
if (IsSearch()) { if (IsSearch()) {
emit Results(query_id_, SongMap(), tr("No match.")); emit Results(query_id_, SongMap(), tr("No match."));
} }
else { else {
emit Results(query_id_, SongMap(), QString()); emit Results(query_id_);
} }
} }
else { else {
emit Results(query_id_, songs_, QString()); emit Results(query_id_, SongMap(), ErrorsToHTML(errors_));
} }
} }
else { else {
emit Results(query_id_, SongMap(), ErrorsToHTML(errors_)); emit Results(query_id_);
} }
} }

2
src/tidal/tidalrequest.h
View File

@@ -81,7 +81,7 @@ class TidalRequest : public TidalBaseRequest {
signals: signals:
void LoginSuccess(); void LoginSuccess();
void LoginFailure(QString failure_reason); void LoginFailure(QString failure_reason);
void Results(int id, SongMap songs, QString error); void Results(int id, SongMap songs = SongMap(), QString error = QString());
void UpdateStatus(int id, QString text); void UpdateStatus(int id, QString text);
void ProgressSetMaximum(int id, int max); void ProgressSetMaximum(int id, int max);
void UpdateProgress(int id, int max); void UpdateProgress(int id, int max);