Replace qrand with QRandomGenerator when using Qt 5.10 or higher

src/core/utilities.cpp

@@ -64,6 +64,9 @@
 #include <QMessageBox>
 #include <QNetworkInterface>
 #include <QtDebug>
+#if QT_VERSION >= QT_VERSION_CHECK(5, 10, 0)
+#  include <QRandomGenerator>
+#endif
 
 #include <stdio.h>
 
@@ -540,7 +543,11 @@ bool IsMouseEventInWidget(const QMouseEvent *e, const QWidget *widget) {
 quint16 PickUnusedPort() {
 
   forever {
+#if QT_VERSION >= QT_VERSION_CHECK(5, 10, 0)
+    const quint64 port = QRandomGenerator::global()->bounded(49152, 65535);
+#else
     const quint16 port = 49152 + qrand() % 16384;
+#endif
 
     QTcpServer server;
     if (server.listen(QHostAddress::Any, port)) {
@@ -821,8 +828,12 @@ QString CryptographicRandomString(const int len) {
 QString GetRandomString(const int len, const QString &UseCharacters) {
 
    QString randstr;
-   for(int i=0 ; i < len ; ++i) {
-     int index = qrand() % UseCharacters.length();
+   for(int i = 0 ; i < len ; ++i) {
+#if QT_VERSION >= QT_VERSION_CHECK(5, 10, 0)
+     const int index = QRandomGenerator::global()->bounded(0, UseCharacters.length());
+#else
+     const int index = qrand() % UseCharacters.length();
+#endif
      QChar nextchar = UseCharacters.at(index);
      randstr.append(nextchar);
    }

src/internet/localredirectserver.cpp

@@ -48,6 +48,9 @@
 #include <QTcpSocket>
 #include <QSslSocket>
 #include <QDateTime>
+#if QT_VERSION >= QT_VERSION_CHECK(5, 10, 0)
+#  include <QRandomGenerator>
+#endif
 
 LocalRedirectServer::LocalRedirectServer(QObject *parent)
     : QTcpServer(parent),
@@ -152,7 +155,12 @@ bool LocalRedirectServer::GenerateCertificate() {
     return false;
   }
 
+#if QT_VERSION >= QT_VERSION_CHECK(5, 10, 0)
+  quint64 serial = 9999999 + QRandomGenerator::global()->bounded(1000000);
+#else
   quint64 serial = (9999999 + qrand() % 1000000);
+#endif
+
   QByteArray q_serial;
   q_serial.setNum(serial);