diff --git a/src/settings/tidalsettingspage.cpp b/src/settings/tidalsettingspage.cpp index 56962696a..2be864f28 100644 --- a/src/settings/tidalsettingspage.cpp +++ b/src/settings/tidalsettingspage.cpp @@ -88,7 +88,7 @@ void TidalSettingsPage::Load() { s.beginGroup(kSettingsGroup); ui_->enable->setChecked(s.value("enabled", false).toBool()); - ui_->oauth->setChecked(s.value("oauth", false).toBool()); + ui_->oauth->setChecked(s.value("oauth", true).toBool()); ui_->client_id->setText(s.value("client_id").toString()); ui_->api_token->setText(s.value("api_token").toString()); @@ -105,7 +105,7 @@ void TidalSettingsPage::Load() { ui_->songssearchlimit->setValue(s.value("songssearchlimit", 10).toInt()); ui_->checkbox_fetchalbums->setChecked(s.value("fetchalbums", false).toBool()); ui_->checkbox_download_album_covers->setChecked(s.value("downloadalbumcovers", true).toBool()); - dialog()->ComboBoxLoadFromSettings(s, ui_->coversize, "coversize", "320x320"); + dialog()->ComboBoxLoadFromSettings(s, ui_->coversize, "coversize", "640x640"); StreamUrlMethod stream_url = static_cast(s.value("streamurl").toInt()); int i = ui_->streamurl->findData(stream_url); @@ -158,8 +158,16 @@ void TidalSettingsPage::LoginClicked() { emit Authorize(ui_->client_id->text()); } else { - if (ui_->api_token->text().isEmpty() || ui_->username->text().isEmpty() || ui_->password->text().isEmpty()) { - QMessageBox::critical(this, tr("Configuration incomplete"), tr("Missing API token, username or password.")); + if (ui_->api_token->text().isEmpty()) { + QMessageBox::critical(this, tr("Configuration incomplete"), tr("Missing API token.")); + return; + } + if (ui_->username->text().isEmpty()) { + QMessageBox::critical(this, tr("Configuration incomplete"), tr("Missing username.")); + return; + } + if (ui_->password->text().isEmpty()) { + QMessageBox::critical(this, tr("Configuration incomplete"), tr("Missing password.")); return; } emit Login(ui_->api_token->text(), ui_->username->text(), ui_->password->text()); diff --git a/src/settings/tidalsettingspage.ui b/src/settings/tidalsettingspage.ui index 87ccfcd0c..7772d49d3 100644 --- a/src/settings/tidalsettingspage.ui +++ b/src/settings/tidalsettingspage.ui @@ -7,7 +7,7 @@ 0 0 472 - 912 + 853 diff --git a/src/tidal/tidalbaserequest.h b/src/tidal/tidalbaserequest.h index 48e1f230a..1d0e6ad7b 100644 --- a/src/tidal/tidalbaserequest.h +++ b/src/tidal/tidalbaserequest.h @@ -57,7 +57,7 @@ class TidalBaseRequest : public QObject { QueryType_StreamURL, }; - TidalBaseRequest(TidalService *service, NetworkAccessManager *network, QObject *parent); + explicit TidalBaseRequest(TidalService *service, NetworkAccessManager *network, QObject *parent); typedef QPair Param; typedef QList ParamList; diff --git a/src/tidal/tidalfavoriterequest.h b/src/tidal/tidalfavoriterequest.h index fa0378b31..f41d7d1da 100644 --- a/src/tidal/tidalfavoriterequest.h +++ b/src/tidal/tidalfavoriterequest.h @@ -38,7 +38,7 @@ class TidalFavoriteRequest : public TidalBaseRequest { Q_OBJECT public: - TidalFavoriteRequest(TidalService *service, NetworkAccessManager *network, QObject *parent); + explicit TidalFavoriteRequest(TidalService *service, NetworkAccessManager *network, QObject *parent); ~TidalFavoriteRequest() override; enum FavoriteType { diff --git a/src/tidal/tidalrequest.h b/src/tidal/tidalrequest.h index a2005c1d2..5809c6558 100644 --- a/src/tidal/tidalrequest.h +++ b/src/tidal/tidalrequest.h @@ -51,7 +51,7 @@ class TidalRequest : public TidalBaseRequest { public: - TidalRequest(TidalService *service, TidalUrlHandler *url_handler, Application *app, NetworkAccessManager *network, QueryType type, QObject *parent); + explicit TidalRequest(TidalService *service, TidalUrlHandler *url_handler, Application *app, NetworkAccessManager *network, QueryType type, QObject *parent); ~TidalRequest() override; void ReloadSettings(); diff --git a/src/tidal/tidalservice.cpp b/src/tidal/tidalservice.cpp index 3af8bd69a..377a8507f 100644 --- a/src/tidal/tidalservice.cpp +++ b/src/tidal/tidalservice.cpp @@ -264,7 +264,7 @@ void TidalService::ReloadSettings() { s.beginGroup(TidalSettingsPage::kSettingsGroup); enabled_ = s.value("enabled", false).toBool(); - oauth_ = s.value("oauth", false).toBool(); + oauth_ = s.value("oauth", true).toBool(); client_id_ = s.value("client_id").toString(); api_token_ = s.value("api_token").toString(); @@ -279,7 +279,7 @@ void TidalService::ReloadSettings() { albumssearchlimit_ = s.value("albumssearchlimit", 10).toInt(); songssearchlimit_ = s.value("songssearchlimit", 10).toInt(); fetchalbums_ = s.value("fetchalbums", false).toBool(); - coversize_ = s.value("coversize", "320x320").toString(); + coversize_ = s.value("coversize", "640x640").toString(); download_album_covers_ = s.value("downloadalbumcovers", true).toBool(); stream_url_method_ = static_cast(s.value("streamurl").toInt()); diff --git a/src/tidal/tidalservice.h b/src/tidal/tidalservice.h index ea9a38075..208ae9663 100644 --- a/src/tidal/tidalservice.h +++ b/src/tidal/tidalservice.h @@ -59,7 +59,7 @@ class TidalService : public InternetService { Q_OBJECT public: - TidalService(Application *app, QObject *parent); + explicit TidalService(Application *app, QObject *parent); ~TidalService() override; static const Song::Source kSource; @@ -121,8 +121,6 @@ class TidalService : public InternetService { QueryType_SearchSongs, }; - signals: - public slots: void ShowConfig() override; void TryLogin(); diff --git a/src/tidal/tidalstreamurlrequest.h b/src/tidal/tidalstreamurlrequest.h index 222398726..130dd2b21 100644 --- a/src/tidal/tidalstreamurlrequest.h +++ b/src/tidal/tidalstreamurlrequest.h @@ -41,7 +41,7 @@ class TidalStreamURLRequest : public TidalBaseRequest { Q_OBJECT public: - TidalStreamURLRequest(TidalService *service, NetworkAccessManager *network, const QUrl &original_url, QObject *parent); + explicit TidalStreamURLRequest(TidalService *service, NetworkAccessManager *network, const QUrl &original_url, QObject *parent); ~TidalStreamURLRequest() override; void GetStreamURL(); diff --git a/src/tidal/tidalurlhandler.h b/src/tidal/tidalurlhandler.h index 6ddf9bf9f..a0b22f0b1 100644 --- a/src/tidal/tidalurlhandler.h +++ b/src/tidal/tidalurlhandler.h @@ -37,7 +37,7 @@ class TidalUrlHandler : public UrlHandler { Q_OBJECT public: - TidalUrlHandler(Application *app, TidalService *service); + explicit TidalUrlHandler(Application *app, TidalService *service); QString scheme() const override { return service_->url_scheme(); } LoadResult StartLoading(const QUrl &url) override;