Use QString::compare with Qt::CaseInsensitive to reduce allocations

src/covermanager/albumcoverchoicecontroller.cpp

@@ -249,7 +249,7 @@ void AlbumCoverChoiceController::SaveCoverToFileManual(const Song &song, const A
     fileinfo.setFile(save_filename);
   }
 
-  if (result.is_jpeg() && fileinfo.completeSuffix().toLower() == "jpg") {
+  if (result.is_jpeg() && fileinfo.completeSuffix().compare("jpg") == 0) {
     QFile file(save_filename);
     if (file.open(QIODevice::WriteOnly)) {
       file.write(result.image_data);

src/covermanager/albumcoverfetchersearch.cpp

@@ -86,7 +86,7 @@ void AlbumCoverFetcherSearch::TerminateSearch() {
 void AlbumCoverFetcherSearch::Start(CoverProviders *cover_providers) {
 
   // Ignore Radio Paradise "commercial" break.
-  if (request_.artist.toLower() == "commercial-free" && request_.title.toLower() == "listener-supported") {
+  if (request_.artist.compare("commercial-free", Qt::CaseInsensitive) == 0 && request_.title.compare("listener-supported", Qt::CaseInsensitive) == 0) {
     TerminateSearch();
     return;
   }
@@ -147,22 +147,22 @@ void AlbumCoverFetcherSearch::ProviderSearchResults(CoverProvider *provider, con
     results_copy[i].provider = provider->name();
     results_copy[i].score_provider = provider->quality();
 
-    QString request_artist = request_.artist.toLower();
-    QString request_album = request_.album.toLower();
-    QString result_artist = results_copy[i].artist.toLower();
-    QString result_album = results_copy[i].album.toLower();
+    const QString &request_artist = request_.artist;
+    const QString &request_album = request_.album;
+    const QString &result_artist = results_copy[i].artist;
+    const QString &result_album = results_copy[i].album;
 
-    if (result_artist == request_artist) {
+    if (result_artist.compare(request_artist, Qt::CaseInsensitive) == 0) {
       results_copy[i].score_match += 0.5;
     }
-    if (result_album == request_album) {
+    if (result_album.compare(request_album, Qt::CaseInsensitive) == 0) {
       results_copy[i].score_match += 0.5;
     }
-    if (result_artist != request_artist && result_album != request_album) {
+    if (result_artist.compare(request_artist, Qt::CaseInsensitive) != 0 && result_album.compare(request_album, Qt::CaseInsensitive) != 0) {
       results_copy[i].score_match -= 1.5;
     }
 
-    if (request_album.isEmpty() && result_artist != request_artist) {
+    if (request_album.isEmpty() && result_artist.compare(request_artist, Qt::CaseInsensitive) != 0) {
       results_copy[i].score_match -= 1;
     }
 
@@ -170,51 +170,51 @@ void AlbumCoverFetcherSearch::ProviderSearchResults(CoverProvider *provider, con
     // This is done since we can't match the album titles, and we want to prevent compilation or live albums from being picked before studio albums for streams.
     // TODO: Make these regular expressions.
     if (request_album.isEmpty() && (
-        result_album.contains("hits") ||
-        result_album.contains("greatest") ||
-        result_album.contains("best") ||
-        result_album.contains("collection") ||
-        result_album.contains("classics") ||
-        result_album.contains("singles") ||
-        result_album.contains("bootleg") ||
-        result_album.contains("live") ||
-        result_album.contains("concert") ||
-        result_album.contains("essential") ||
-        result_album.contains("ultimate") ||
-        result_album.contains("karaoke") ||
-        result_album.contains("mixtape") ||
-        result_album.contains("country rock") ||
-        result_album.contains("indie folk") ||
-        result_album.contains("soft rock") ||
-        result_album.contains("folk music") ||
-        result_album.contains("60's rock") ||
-        result_album.contains("60's romance") ||
-        result_album.contains("60s music") ||
-        result_album.contains("late 60s") ||
-        result_album.contains("the 60s") ||
-        result_album.contains("folk and blues") ||
-        result_album.contains("60 from the 60's") ||
-        result_album.contains("classic psychedelic") ||
-        result_album.contains("playlist: acoustic") ||
-        result_album.contains("90's rnb playlist") ||
-        result_album.contains("rock 80s") ||
-        result_album.contains("classic 80s") ||
-        result_album.contains("rock anthems") ||
-        result_album.contains("rock songs") ||
-        result_album.contains("rock 2019") ||
-        result_album.contains("guitar anthems") ||
-        result_album.contains("driving anthems") ||
-        result_album.contains("traffic jam jams") ||
-        result_album.contains("perfect background music") ||
-        result_album.contains("70's gold") ||
-        result_album.contains("rockfluence") ||
-        result_album.contains("acoustic dinner accompaniment") ||
-        result_album.contains("complete studio albums") ||
-        result_album.contains("mellow rock")
+        result_album.contains("hits", Qt::CaseInsensitive) ||
+        result_album.contains("greatest", Qt::CaseInsensitive) ||
+        result_album.contains("best", Qt::CaseInsensitive) ||
+        result_album.contains("collection", Qt::CaseInsensitive) ||
+        result_album.contains("classics", Qt::CaseInsensitive) ||
+        result_album.contains("singles", Qt::CaseInsensitive) ||
+        result_album.contains("bootleg", Qt::CaseInsensitive) ||
+        result_album.contains("live", Qt::CaseInsensitive) ||
+        result_album.contains("concert", Qt::CaseInsensitive) ||
+        result_album.contains("essential", Qt::CaseInsensitive) ||
+        result_album.contains("ultimate", Qt::CaseInsensitive) ||
+        result_album.contains("karaoke", Qt::CaseInsensitive) ||
+        result_album.contains("mixtape", Qt::CaseInsensitive) ||
+        result_album.contains("country rock", Qt::CaseInsensitive) ||
+        result_album.contains("indie folk", Qt::CaseInsensitive) ||
+        result_album.contains("soft rock", Qt::CaseInsensitive) ||
+        result_album.contains("folk music", Qt::CaseInsensitive) ||
+        result_album.contains("60's rock", Qt::CaseInsensitive) ||
+        result_album.contains("60's romance", Qt::CaseInsensitive) ||
+        result_album.contains("60s music", Qt::CaseInsensitive) ||
+        result_album.contains("late 60s", Qt::CaseInsensitive) ||
+        result_album.contains("the 60s", Qt::CaseInsensitive) ||
+        result_album.contains("folk and blues", Qt::CaseInsensitive) ||
+        result_album.contains("60 from the 60's", Qt::CaseInsensitive) ||
+        result_album.contains("classic psychedelic", Qt::CaseInsensitive) ||
+        result_album.contains("playlist: acoustic", Qt::CaseInsensitive) ||
+        result_album.contains("90's rnb playlist", Qt::CaseInsensitive) ||
+        result_album.contains("rock 80s", Qt::CaseInsensitive) ||
+        result_album.contains("classic 80s", Qt::CaseInsensitive) ||
+        result_album.contains("rock anthems", Qt::CaseInsensitive) ||
+        result_album.contains("rock songs", Qt::CaseInsensitive) ||
+        result_album.contains("rock 2019", Qt::CaseInsensitive) ||
+        result_album.contains("guitar anthems", Qt::CaseInsensitive) ||
+        result_album.contains("driving anthems", Qt::CaseInsensitive) ||
+        result_album.contains("traffic jam jams", Qt::CaseInsensitive) ||
+        result_album.contains("perfect background music", Qt::CaseInsensitive) ||
+        result_album.contains("70's gold", Qt::CaseInsensitive) ||
+        result_album.contains("rockfluence", Qt::CaseInsensitive) ||
+        result_album.contains("acoustic dinner accompaniment", Qt::CaseInsensitive) ||
+        result_album.contains("complete studio albums", Qt::CaseInsensitive) ||
+        result_album.contains("mellow rock", Qt::CaseInsensitive)
         )) {
       results_copy[i].score_match -= 1;
     }
-    else if (request_album.isEmpty() && result_album.contains("soundtrack")) {
+    else if (request_album.isEmpty() && result_album.contains("soundtrack", Qt::CaseInsensitive)) {
       results_copy[i].score_match -= 0.5;
     }
 

src/covermanager/discogscoverprovider.cpp

@@ -296,7 +296,7 @@ void DiscogsCoverProvider::HandleSearchReply(QNetworkReply *reply, const int id)
       if (title_splitted.count() == 2) {
         QString artist = title_splitted.first();
         title = title_splitted.last();
-        if (artist.toLower() != search->artist.toLower() && title.toLower() != search->album.toLower()) continue;
+        if (artist.compare(search->artist, Qt::CaseInsensitive) != 0 && title.compare(search->album, Qt::CaseInsensitive) != 0) continue;
       }
     }
 

src/covermanager/musixmatchcoverprovider.cpp

@@ -62,19 +62,19 @@ bool MusixmatchCoverProvider::StartSearch(const QString &artist, const QString &
   QString artist_stripped = artist;
   QString album_stripped = album;
 
-  artist_stripped = artist_stripped.replace('/', '-');
-  artist_stripped = artist_stripped.remove(QRegularExpression("[^\\w0-9\\- ]", QRegularExpression::UseUnicodePropertiesOption));
-  artist_stripped = artist_stripped.simplified();
-  artist_stripped = artist_stripped.replace(' ', '-');
-  artist_stripped = artist_stripped.replace(QRegularExpression("(-)\\1+"), "-");
-  artist_stripped = artist_stripped.toLower();
+  artist_stripped = artist_stripped.replace('/', '-')
+                                   .remove(QRegularExpression("[^\\w0-9\\- ]", QRegularExpression::UseUnicodePropertiesOption))
+                                   .simplified()
+                                   .replace(' ', '-')
+                                   .replace(QRegularExpression("(-)\\1+"), "-")
+                                   .toLower();
 
-  album_stripped = album_stripped.replace('/', '-');
-  album_stripped = album_stripped.remove(QRegularExpression("[^\\w0-9\\- ]", QRegularExpression::UseUnicodePropertiesOption));
-  album_stripped = album_stripped.simplified();
-  album_stripped = album_stripped.replace(' ', '-').toLower();
-  album_stripped = album_stripped.replace(QRegularExpression("(-)\\1+"), "-");
-  album_stripped = album_stripped.toLower();
+  album_stripped = album_stripped.replace('/', '-')
+                                 .remove(QRegularExpression("[^\\w0-9\\- ]", QRegularExpression::UseUnicodePropertiesOption))
+                                 .simplified()
+                                 .replace(' ', '-')
+                                 .replace(QRegularExpression("(-)\\1+"), "-")
+                                 .toLower();
 
   if (artist_stripped.isEmpty() || album_stripped.isEmpty()) return false;
 
@@ -201,7 +201,7 @@ void MusixmatchCoverProvider::HandleSearchReply(QNetworkReply *reply, const int
   result.artist = obj_album["artistName"].toString();
   result.album = obj_album["name"].toString();
 
-  if (artist.toLower() != result.artist.toLower() && album.toLower() != result.album.toLower()) {
+  if (result.artist.compare(artist, Qt::CaseInsensitive) != 0 && result.album.compare(album, Qt::CaseInsensitive) != 0) {
     emit SearchFinished(id, results);
     return;
   }