From 70c2b99771f35dc8ade68ff4865b1beb59312da1 Mon Sep 17 00:00:00 2001
From: Jonas Kvinge <jonas@jkvinge.net>
Date: Thu, 20 Jun 2024 16:05:07 +0200
Subject: [PATCH] ContextAlbum: Delete timeline to delete previous cover

QTimeLine was holding the previous covers shared pointer in the signal/slot connection, which caused it to never be free'd even though it's removed from the previous_covers_ list.
To fix this, make sure the QTimeLine is deleted.

This fixes a huge memory leak.

Addresses issue #1464
---
 src/context/contextalbum.cpp | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/context/contextalbum.cpp b/src/context/contextalbum.cpp
index f28975dbd..91bb2abb1 100644
--- a/src/context/contextalbum.cpp
+++ b/src/context/contextalbum.cpp
@@ -235,6 +235,7 @@ void ContextAlbum::FadePreviousCover(SharedPtr<PreviousCover> previous_cover) {
 
 void ContextAlbum::FadePreviousCoverFinished(SharedPtr<PreviousCover> previous_cover) {
 
+  previous_cover->timeline.reset();
   previous_covers_.removeAll(previous_cover);
 
 }