From 8a27c6a52ffce63c5c7ae058ea3966bdf6543bc6 Mon Sep 17 00:00:00 2001 From: Jonas Kvinge Date: Sun, 2 Jun 2024 12:09:38 +0200 Subject: [PATCH] GstEnginePipeline: Use playbin3 with GStreamer 1.24 and higher playbin3 is buggy with GStreamer 1.22, for some reason the bug is only reproducible on Gnome. https://forum.strawberrymusicplayer.org/topic/1506/buffering-forever/23 --- src/engine/gstenginepipeline.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/engine/gstenginepipeline.cpp b/src/engine/gstenginepipeline.cpp index f0a9958ce..c3166695b 100644 --- a/src/engine/gstenginepipeline.cpp +++ b/src/engine/gstenginepipeline.cpp @@ -345,7 +345,7 @@ bool GstEnginePipeline::InitFromUrl(const QUrl &media_url, const QUrl &stream_ur guint version_major = 0, version_minor = 0, version_micro = 0, version_nano = 0; gst_plugins_base_version(&version_major, &version_minor, &version_micro, &version_nano); - if (QVersionNumber::compare(QVersionNumber(static_cast(version_major), static_cast(version_minor)), QVersionNumber(1, 22)) >= 0) { + if (QVersionNumber::compare(QVersionNumber(static_cast(version_major), static_cast(version_minor)), QVersionNumber(1, 24)) >= 0) { pipeline_ = CreateElement(QStringLiteral("playbin3"), QStringLiteral("pipeline"), nullptr, error); } else {