dryark/strawberry
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Make sure QCache::insert is successful

Browse Source 
Otherwise object is deleted by QCache::insert
This commit is contained in:
Jonas Kvinge
2021-03-26 21:07:47 +01:00
parent a3d23a6f57
commit 8a39a43ad5
1 changed files with 13 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
src/moodbar/moodbaritemdelegate.cpp
View File

@@ -99,12 +99,15 @@ void MoodbarItemDelegate::paint(QPainter *painter, const QStyleOptionViewItem &o
QPixmap MoodbarItemDelegate::PixmapForIndex(const QModelIndex &idx, const QSize &size) { QPixmap MoodbarItemDelegate::PixmapForIndex(const QModelIndex &idx, const QSize &size) {
// Pixmaps are keyed off URL. // Pixmaps are keyed off URL.
const QUrl url(idx.sibling(idx.row(), Playlist::Column_Filename).data().toUrl()); const QUrl url = idx.sibling(idx.row(), Playlist::Column_Filename).data().toUrl();
Data *data = data_[url]; Data *data = nullptr;
if (!data) { if (data_.contains(url)) {
data = data_[url];
}
else {
data = new Data; data = new Data;
data_.insert(url, data); if (!data_.insert(url, data)) return QPixmap();
} }
data->indexes_.insert(idx); data->indexes_.insert(idx);
@@ -189,10 +192,9 @@ void MoodbarItemDelegate::ReloadAllColors() {
void MoodbarItemDelegate::DataLoaded(const QUrl &url, MoodbarPipeline *pipeline) { void MoodbarItemDelegate::DataLoaded(const QUrl &url, MoodbarPipeline *pipeline) {
if (!data_.contains(url)) return;
Data *data = data_[url]; Data *data = data_[url];
if (!data) {
return;
}
if (RemoveFromCacheIfIndexesInvalid(url, data)) { if (RemoveFromCacheIfIndexesInvalid(url, data)) {
return; return;
@@ -224,10 +226,9 @@ void MoodbarItemDelegate::StartLoadingColors(const QUrl &url, const QByteArray &
void MoodbarItemDelegate::ColorsLoaded(const QUrl &url, const ColorVector &colors) { void MoodbarItemDelegate::ColorsLoaded(const QUrl &url, const ColorVector &colors) {
if (!data_.contains(url)) return;
Data *data = data_[url]; Data *data = data_[url];
if (!data) {
return;
}
if (RemoveFromCacheIfIndexesInvalid(url, data)) { if (RemoveFromCacheIfIndexesInvalid(url, data)) {
return; return;
@@ -256,10 +257,9 @@ void MoodbarItemDelegate::StartLoadingImage(const QUrl &url, Data *data) {
void MoodbarItemDelegate::ImageLoaded(const QUrl &url, const QImage &image) { void MoodbarItemDelegate::ImageLoaded(const QUrl &url, const QImage &image) {
if (!data_.contains(url)) return;
Data *data = data_[url]; Data *data = data_[url];
if (!data) {
return;
}
if (RemoveFromCacheIfIndexesInvalid(url, data)) { if (RemoveFromCacheIfIndexesInvalid(url, data)) {
return; return;