dryark/strawberry
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix narrowing conversions in connects

Browse Source
This commit is contained in:
Jonas Kvinge
2022-09-12 23:18:54 +02:00
parent 78d6fd634b
commit 93f12baf51
11 changed files with 46 additions and 31 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
src/core/player.cpp
View File

@@ -641,16 +641,21 @@ uint Player::GetVolume() const {
}
void Player::SetVolume(const uint value) {
void Player::SetVolumeFromValue(const int value) {
SetVolume(static_cast<uint>(std::max(0, value)));
}
void Player::SetVolume(const uint volume) {
uint old_volume = engine_->volume();
uint new_volume = qBound(0U, volume, 100U);
settings_.setValue("volume", new_volume);
engine_->SetVolume(new_volume);
uint volume = qBound(0U, value, 100U);
settings_.setValue("volume", volume);
engine_->SetVolume(volume);
if (volume != old_volume) {
emit VolumeChanged(volume);
if (new_volume != old_volume) {
emit VolumeChanged(new_volume);
}
}