dryark/strawberry
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Never use reference when iterating QJsonArray

Browse Source
This commit is contained in:
Jonas Kvinge
2020-11-13 20:34:36 +01:00
parent c0663bc19f
commit a155e503f4
16 changed files with 29 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/musicbrainz/acoustidclient.cpp
View File

@@ -167,11 +167,11 @@ void AcoustidClient::RequestFinished(QNetworkReply *reply, const int request_id)
// List of <id, nb of sources> pairs
QList<IdSource> id_source_list;
for (const QJsonValue& v : json_results) {
for (const QJsonValue v : json_results) {
QJsonObject r = v.toObject();
if (!r["recordings"].isUndefined()) {
QJsonArray json_recordings = r["recordings"].toArray();
for (const QJsonValue& recording : json_recordings) {
for (const QJsonValue recording : json_recordings) {
QJsonObject o = recording.toObject();
if (!o["id"].isUndefined()) {
id_source_list << IdSource(o["id"].toString(), o["sources"].toInt());