Never use reference when iterating QJsonArray

This commit is contained in:
Jonas Kvinge
2020-11-13 20:34:36 +01:00
parent c0663bc19f
commit a155e503f4
16 changed files with 29 additions and 29 deletions

View File

@@ -356,7 +356,7 @@ void LastFMImport::GetRecentTracksRequestFinished(QNetworkReply *reply, const in
QJsonArray array_track = json_obj["track"].toArray();
for (const QJsonValue &value_track : array_track) {
for (const QJsonValue value_track : array_track) {
++lastplayed_received_;
@@ -516,7 +516,7 @@ void LastFMImport::GetTopTracksRequestFinished(QNetworkReply *reply, const int p
else {
QJsonArray array_track = json_obj["track"].toArray();
for (const QJsonValue &value_track : array_track) {
for (const QJsonValue value_track : array_track) {
++playcount_received_;

View File

@@ -102,7 +102,7 @@ void ScrobblerCache::ReadCache() {
return;
}
for (const QJsonValue &value : json_array) {
for (const QJsonValue value : json_array) {
if (!value.isObject()) {
qLog(Error) << "Scrobbler cache JSON tracks array value is not an object.";
qLog(Debug) << value;

View File

@@ -711,7 +711,7 @@ void ScrobblingAPI20::ScrobbleRequestFinished(QNetworkReply *reply, QList<quint6
return;
}
for (const QJsonValue &value : array_scrobble) {
for (const QJsonValue value : array_scrobble) {
if (!value.isObject()) {
Error("Json scrobbles scrobble array value is not an object.", value);