Refactor scrobbler authentication code

Fix a crash when authentication is cancelled
2019-11-14 21:07:30 +01:00
parent 1862e70628
commit a9accb7d85
6 changed files with 104 additions and 65 deletions
--- a/src/scrobbler/scrobblerservice.h
+++ b/src/scrobbler/scrobblerservice.h
@@ -52,7 +52,7 @@ class ScrobblerService : public QObject {
  virtual void ClearPlaying() = 0;
  virtual void Scrobble(const Song &song) = 0;
  virtual void Love() {}
-  virtual void Error(QString error, QVariant debug = QVariant()) = 0;
+  virtual void Error(const QString &error, const QVariant &debug = QVariant()) = 0;

  virtual void DoSubmit() = 0;
  virtual void Submitted() = 0;