dryark/strawberry
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add const/references to all signal parameters

Browse Source
This commit is contained in:
Jonas Kvinge
2023-04-09 20:23:42 +02:00
parent fa856ee905
commit aaa530e72b
102 changed files with 296 additions and 297 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/covermanager/albumcoverchoicecontroller.h
View File

@@ -158,7 +158,7 @@ class AlbumCoverChoiceController : public QWidget {
void SaveEmbeddedCoverAsyncFinished(quint64 id, const bool success, const bool cleared);
signals:
void Error(QString);
void Error(const QString &error);
void AutomaticCoverSearchDone();
private:

2
src/covermanager/albumcoverexporter.h
View File

@@ -49,7 +49,7 @@ class AlbumCoverExporter : public QObject {
int request_count() { return static_cast<int>(requests_.size()); }
signals:
void AlbumCoversExportUpdate(int exported, int skipped, int all);
void AlbumCoversExportUpdate(const int exported, const int skipped, const int all);
private slots:
void CoverExported();

8
src/covermanager/albumcoverfetcher.h
View File

@@ -118,12 +118,12 @@ class AlbumCoverFetcher : public QObject {
void Clear();
signals:
void AlbumCoverFetched(quint64 request_id, AlbumCoverImageResultPtr result, CoverSearchStatistics statistics);
void SearchFinished(quint64 request_id, CoverProviderSearchResults results, CoverSearchStatistics statistics);
void AlbumCoverFetched(const quint64 request_id, AlbumCoverImageResultPtr result, const CoverSearchStatistics &statistics);
void SearchFinished(const quint64 request_id, const CoverProviderSearchResults &results, const CoverSearchStatistics &statistics);
private slots:
void SingleSearchFinished(const quint64, const CoverProviderSearchResults &results);
void SingleCoverFetched(const quint64, AlbumCoverImageResultPtr result);
void SingleSearchFinished(const quint64 id, const CoverProviderSearchResults &results);
void SingleCoverFetched(const quint64 id, AlbumCoverImageResultPtr result);
void StartRequests();
private:

4
src/covermanager/albumcoverfetchersearch.h
View File

@@ -66,10 +66,10 @@ class AlbumCoverFetcherSearch : public QObject {
signals:
// It's the end of search (when there was no fetch-me-a-cover request).
void SearchFinished(quint64, CoverProviderSearchResults results);
void SearchFinished(quint64, const CoverProviderSearchResults &results);
// It's the end of search and we've fetched a cover.
void AlbumCoverFetched(const quint64, AlbumCoverImageResultPtr result);
void AlbumCoverFetched(const quint64 id, AlbumCoverImageResultPtr result);
private slots:
void ProviderSearchResults(const int id, const CoverProviderSearchResults &results);

4
src/covermanager/albumcoverloader.h
View File

@@ -79,8 +79,8 @@ class AlbumCoverLoader : public QObject {
signals:
void ExitFinished();
void AlbumCoverLoaded(quint64 id, AlbumCoverLoaderResultPtr result);
void SaveEmbeddedCoverAsyncFinished(quint64 id, bool success, bool cleared);
void AlbumCoverLoaded(const quint64 id, AlbumCoverLoaderResultPtr result);
void SaveEmbeddedCoverAsyncFinished(const quint64 id, const bool success, const bool cleared);
protected slots:
void Exit();

2
src/covermanager/albumcovermanager.h
View File

@@ -147,7 +147,7 @@ class AlbumCoverManager : public QMainWindow {
bool ItemHasCover(const AlbumItem &item) const;
signals:
void Error(QString);
void Error(const QString &error);
void AddToPlaylist(QMimeData *data);
private slots:

8
src/covermanager/coverprovider.h
View File

@@ -68,11 +68,11 @@ class CoverProvider : public QObject {
virtual void Error(const QString &error, const QVariant &debug = QVariant()) = 0;
signals:
void AuthenticationComplete(bool, QStringList = QStringList());
void AuthenticationComplete(const bool success, const QStringList &errors = QStringList());
void AuthenticationSuccess();
void AuthenticationFailure(QStringList);
void SearchResults(int, CoverProviderSearchResults);
void SearchFinished(int, CoverProviderSearchResults);
void AuthenticationFailure(const QStringList &errors);
void SearchResults(const int id, const CoverProviderSearchResults &results);
void SearchFinished(const int id, const CoverProviderSearchResults &results);
protected:
using Param = QPair<QString, QString>;

4
src/covermanager/currentalbumcoverloader.h
View File

@@ -52,8 +52,8 @@ class CurrentAlbumCoverLoader : public QObject {
void LoadAlbumCover(const Song &song);
signals:
void AlbumCoverLoaded(Song song, AlbumCoverLoaderResultPtr result);
void ThumbnailLoaded(Song song, QUrl thumbnail_uri, const QImage &image);
void AlbumCoverLoaded(const Song &song, AlbumCoverLoaderResultPtr result);
void ThumbnailLoaded(const Song &song, const QUrl &thumbnail_uri, const QImage &image);
private slots:
void TempAlbumCoverLoaded(const quint64 id, AlbumCoverLoaderResultPtr result);