dryark/strawberry
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add const/references to all signal parameters

Browse Source
This commit is contained in:
Jonas Kvinge
2023-04-09 20:23:42 +02:00
parent fa856ee905
commit aaa530e72b
102 changed files with 296 additions and 297 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/device/cddadevice.h
View File

@@ -56,7 +56,7 @@ class CddaDevice : public ConnectedDevice {
static QStringList url_schemes() { return QStringList() << "cdda"; }
signals:
void SongsDiscovered(SongList songs);
void SongsDiscovered(const SongList &songs);
private slots:
void SongsLoaded(const SongList &songs);

8
src/device/cddasongloader.h
View File

@@ -57,10 +57,10 @@ class CddaSongLoader : public QObject {
QUrl GetUrlFromTrack(const int track_number) const;
signals:
void SongsLoadError(QString error);
void SongsLoaded(SongList songs);
void SongsDurationLoaded(SongList songs, QString error = QString());
void SongsMetadataLoaded(SongList songs);
void SongsLoadError(const QString &error);
void SongsLoaded(const SongList &songs);
void SongsDurationLoaded(const SongList &songs, const QString &error = QString());
void SongsMetadataLoaded(const SongList &songs);
private slots:
#ifdef HAVE_MUSICBRAINZ

8
src/device/connecteddevice.h
View File

@@ -75,10 +75,10 @@ class ConnectedDevice : public QObject, public virtual MusicStorage, public std:
void BackendCloseFinished();
signals:
void TaskStarted(int id);
void SongCountUpdated(int count);
void DeviceConnectFinished(QString id, bool success);
void DeviceCloseFinished(QString id);
void TaskStarted(const int id);
void SongCountUpdated(const int count);
void DeviceConnectFinished(const QString &id, const bool success);
void DeviceCloseFinished(const QString &id);
protected:
void InitBackendDirectory(const QString &mount_point, const bool first_time, const bool rewrite_path = true);

8
src/device/devicelister.h
View File

@@ -82,10 +82,10 @@ class DeviceLister : public QObject {
virtual void Exit();
signals:
void DeviceAdded(QString id);
void DeviceRemoved(QString id);
void DeviceChanged(QString id);
void DeviceMounted(QString id, int request_id, bool success);
void DeviceAdded(const QString &id);
void DeviceRemoved(const QString &id);
void DeviceChanged(const QString &id);
void DeviceMounted(const QString &id, const int request_id, const bool success);
void ExitFinished();
protected:

4
src/device/devicemanager.h
View File

@@ -120,8 +120,8 @@ class DeviceManager : public SimpleTreeModel<DeviceInfo> {
signals:
void ExitFinished();
void DeviceConnected(QModelIndex idx);
void DeviceDisconnected(QModelIndex idx);
void DeviceConnected(const QModelIndex idx);
void DeviceDisconnected(const QModelIndex idx);
void DeviceCreatedFromDB(DeviceInfo *info);
private slots:

6
src/device/gpodloader.h
View File

@@ -53,9 +53,9 @@ class GPodLoader : public QObject {
void LoadDatabase();
signals:
void Error(QString message);
void TaskStarted(int task_id);
void LoadFinished(Itdb_iTunesDB *db, bool success);
void Error(const QString &message);
void TaskStarted(const int task_id);
void LoadFinished(Itdb_iTunesDB *db, const bool success);
private:
Itdb_iTunesDB *TryLoad();

6
src/device/mtploader.h
View File

@@ -49,9 +49,9 @@ class MtpLoader : public QObject {
void LoadDatabase();
signals:
void Error(QString message);
void TaskStarted(int task_id);
void LoadFinished(bool success, MtpConnection*);
void Error(const QString &message);
void TaskStarted(const int task_id);
void LoadFinished(const bool success, MtpConnection *connection);
private:
bool TryLoad();