dryark/strawberry
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add const/references to all signal parameters

Browse Source
This commit is contained in:
Jonas Kvinge
2023-04-09 20:23:42 +02:00
parent fa856ee905
commit aaa530e72b
102 changed files with 296 additions and 297 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/engine/enginebase.h
View File

@@ -137,23 +137,23 @@ class Base : public QObject {
void FadeoutFinishedSignal();
void StatusText(QString text);
void Error(QString text);
void StatusText(const QString &text);
void Error(const QString &text);
// Emitted when there was a fatal error
void FatalError();
// Emitted when Engine was unable to play a song with the given QUrl.
void InvalidSongRequested(QUrl url);
void InvalidSongRequested(const QUrl &url);
// Emitted when Engine successfully started playing a song with the given QUrl.
void ValidSongRequested(QUrl url);
void ValidSongRequested(const QUrl &url);
void MetaData(Engine::SimpleMetaBundle);
void MetaData(const Engine::SimpleMetaBundle &bundle);
// Signals that the engine's state has changed (a stream was stopped for example).
// Always use the state from event, because it's not guaranteed that immediate subsequent call to state() won't return a stale value.
void StateChanged(Engine::State);
void StateChanged(const Engine::State state);
void VolumeChanged(uint volume);
void VolumeChanged(const uint volume);
protected:

10
src/engine/gstenginepipeline.h
View File

@@ -126,16 +126,16 @@ class GstEnginePipeline : public QObject {
void SetFaderVolume(const qreal volume);
signals:
void Error(int pipeline_id, int domain, int error_code, QString message, QString debug);
void Error(const int pipeline_id, const int domain, const int error_code, const QString &message, const QString &debug);
void EndOfStreamReached(int pipeline_id, bool has_next_track);
void MetadataFound(int pipeline_id, const Engine::SimpleMetaBundle &bundle);
void EndOfStreamReached(const int pipeline_id, const bool has_next_track);
void MetadataFound(const int pipeline_id, const Engine::SimpleMetaBundle &bundle);
void VolumeChanged(uint volume);
void VolumeChanged(const uint volume);
void FaderFinished();
void BufferingStarted();
void BufferingProgress(int percent);
void BufferingProgress(const int percent);
void BufferingFinished();
protected: