Add const/references to all signal parameters

This commit is contained in:
Jonas Kvinge
2023-04-09 20:23:42 +02:00
parent fa856ee905
commit aaa530e72b
102 changed files with 296 additions and 297 deletions

View File

@@ -59,8 +59,8 @@ class LyricsFetcher : public QObject {
void AddRequest(const Request &request);
signals:
void LyricsFetched(quint64 request_id, QString provider, QString lyrics);
void SearchFinished(quint64 request_id, LyricsSearchResults results);
void LyricsFetched(const quint64 request_id, const QString &provider, const QString &lyrics);
void SearchFinished(const quint64 request_id, const LyricsSearchResults &results);
private slots:
void SingleSearchFinished(const quint64 request_id, const LyricsSearchResults &results);

View File

@@ -44,8 +44,8 @@ class LyricsFetcherSearch : public QObject {
void Cancel();
signals:
void SearchFinished(quint64, LyricsSearchResults results);
void LyricsFetched(quint64, QString provider, QString lyrics);
void SearchFinished(const quint64 id, const LyricsSearchResults &results);
void LyricsFetched(const quint64 id, const QString &provider, const QString &lyrics);
private slots:
void ProviderSearchFinished(const int id, const LyricsSearchResults &results);

View File

@@ -60,10 +60,10 @@ class LyricsProvider : public QObject {
QString ParseLyricsFromHTML(const QString &content, const QRegularExpression &start_tag, const QRegularExpression &end_tag, const QRegularExpression &lyrics_start, const bool multiple);
signals:
void AuthenticationComplete(bool, QStringList = QStringList());
void AuthenticationComplete(const bool success, const QStringList &errors = QStringList());
void AuthenticationSuccess();
void AuthenticationFailure(QStringList);
void SearchFinished(int id, LyricsSearchResults results = LyricsSearchResults());
void AuthenticationFailure(const QStringList &errors);
void SearchFinished(const int id, const LyricsSearchResults &results = LyricsSearchResults());
protected:
NetworkAccessManager *network_;