Add const/references to all signal parameters

This commit is contained in:
Jonas Kvinge
2023-04-09 20:23:42 +02:00
parent fa856ee905
commit aaa530e72b
102 changed files with 296 additions and 297 deletions

View File

@@ -59,7 +59,7 @@ class AcoustidClient : public QObject {
void CancelAll();
signals:
void Finished(int id, QStringList mbid_list, QString error = QString());
void Finished(const int id, const QStringList &mbid_list, const QString &error = QString());
private slots:
void RequestFinished(QNetworkReply *reply, const int id);

View File

@@ -101,9 +101,9 @@ class MusicBrainzClient : public QObject {
signals:
// Finished signal emitted when fechting songs tags
void Finished(int id, MusicBrainzClient::ResultList result, QString error = QString());
void Finished(const int id, const MusicBrainzClient::ResultList &result, const QString &error = QString());
// Finished signal emitted when fechting album's songs tags using DiscId
void DiscIdFinished(QString artist, QString album, MusicBrainzClient::ResultList result, QString error = QString());
void DiscIdFinished(const QString &artist, const QString &album, const MusicBrainzClient::ResultList &result, const QString &error = QString());
private slots:
void FlushRequests();

View File

@@ -48,8 +48,8 @@ class TagFetcher : public QObject {
void Cancel();
signals:
void Progress(Song original_song, QString stage);
void ResultAvailable(Song original_song, SongList songs_guessed, QString error = QString());
void Progress(const Song &original_song, const QString &stage);
void ResultAvailable(const Song &original_song, const SongList &songs_guessed, const QString &error = QString());
private slots:
void FingerprintFound(const int index);