Add const/references to all signal parameters

This commit is contained in:
Jonas Kvinge
2023-04-09 20:23:42 +02:00
parent fa856ee905
commit aaa530e72b
102 changed files with 296 additions and 297 deletions

View File

@@ -71,11 +71,11 @@ class AudioScrobbler : public QObject {
void ErrorReceived(const QString &error);
signals:
void ErrorMessage(QString);
void ScrobblingEnabledChanged(bool value);
void ScrobblingOfflineChanged(bool value);
void ScrobbleButtonVisibilityChanged(bool value);
void LoveButtonVisibilityChanged(bool value);
void ErrorMessage(const QString &error);
void ScrobblingEnabledChanged(const bool value);
void ScrobblingOfflineChanged(const bool value);
void ScrobbleButtonVisibilityChanged(const bool value);
void LoveButtonVisibilityChanged(const bool value);
private:
Application *app_;

View File

@@ -79,12 +79,12 @@ class LastFMImport : public QObject {
void FinishCheck();
signals:
void UpdatePlayCount(QString, QString, int, bool = false);
void UpdateLastPlayed(QString, QString, QString, qint64);
void UpdateTotal(int, int);
void UpdateProgress(int, int);
void UpdatePlayCount(const QString&, const QString&, const int, const bool = false);
void UpdateLastPlayed(const QString&, const QString&, const QString&, const qint64);
void UpdateTotal(const int, const int);
void UpdateProgress(const int, const int);
void Finished();
void FinishedWithError(QString);
void FinishedWithError(const QString&);
private slots:
void FlushRequests();

View File

@@ -72,7 +72,7 @@ class ListenBrainzScrobbler : public ScrobblerService {
void Love() override;
signals:
void AuthenticationComplete(bool success, QString error = QString());
void AuthenticationComplete(const bool success, const QString &error = QString());
public slots:
void WriteCache() override { cache_->WriteCache(); }

View File

@@ -72,7 +72,7 @@ class ScrobblerService : public QObject {
virtual void WriteCache() = 0;
signals:
void ErrorMessage(QString);
void ErrorMessage(const QString &error);
private:
QString name_;

View File

@@ -70,7 +70,7 @@ class ScrobblingAPI20 : public ScrobblerService {
void Love() override;
signals:
void AuthenticationComplete(bool success, QString error = QString());
void AuthenticationComplete(const bool success, const QString &error = QString());
public slots:
void WriteCache() override { cache_->WriteCache(); }