Add const/references to all signal parameters
This commit is contained in:
@@ -45,7 +45,7 @@ class QobuzSettingsPage : public SettingsPage {
|
||||
bool eventFilter(QObject *object, QEvent *event) override;
|
||||
|
||||
signals:
|
||||
void Login(QString username, QString password, QString token);
|
||||
void Login(const QString &username, const QString &password, const QString &token);
|
||||
|
||||
private slots:
|
||||
void LoginClicked();
|
||||
|
||||
@@ -139,7 +139,7 @@ class SettingsDialog : public QDialog {
|
||||
|
||||
signals:
|
||||
void ReloadSettings();
|
||||
void NotificationPreview(OSDBase::Behaviour, QString, QString);
|
||||
void NotificationPreview(const OSDBase::Behaviour, const QString&, const QString&);
|
||||
|
||||
private slots:
|
||||
void CurrentItemChanged(QTreeWidgetItem *item);
|
||||
|
||||
@@ -76,7 +76,7 @@ class SettingsPage : public QWidget {
|
||||
virtual void Cancel() {}
|
||||
|
||||
signals:
|
||||
void NotificationPreview(OSDBase::Behaviour, QString, QString);
|
||||
void NotificationPreview(const OSDBase::Behaviour, const QString&, const QString&);
|
||||
|
||||
private:
|
||||
SettingsDialog *dialog_;
|
||||
|
||||
@@ -53,7 +53,7 @@ class SubsonicSettingsPage : public SettingsPage {
|
||||
bool eventFilter(QObject *object, QEvent *event) override;
|
||||
|
||||
signals:
|
||||
void Test(QUrl url, QString username, QString password, SubsonicSettingsPage::AuthMethod auth_method, bool redirect = false);
|
||||
void Test(const QUrl &url, const QString &username, const QString &password, const SubsonicSettingsPage::AuthMethod auth_method, const bool redirect = false);
|
||||
|
||||
private slots:
|
||||
void TestClicked();
|
||||
|
||||
@@ -53,8 +53,8 @@ class TidalSettingsPage : public SettingsPage {
|
||||
bool eventFilter(QObject *object, QEvent *event) override;
|
||||
|
||||
signals:
|
||||
void Authorize(QString client_id);
|
||||
void Login(QString api_token, QString username, QString password);
|
||||
void Authorize(const QString &client_id);
|
||||
void Login(const QString &api_token, const QString &username, const QString &password);
|
||||
|
||||
private slots:
|
||||
void OAuthClicked(const bool enabled);
|
||||
|
||||
Reference in New Issue
Block a user