New context with albums and lyrics +++ much more

* Added new lyrics provider with lyrics from AudD and API Seeds
* New improved context widget with albums and lyrics
* Fixed playing and context widget getting stuck in play mode when there was an error
* Changed icons for artists in collection, tidal and cover manager
* Removed "search" icon from "Search automatically" checkbox (right click) that looked ugly
* Removed some unused widgets from the src/widgets directory
* Fixed initial size of window and side panel
* Fixed saving window size correctly

src/collection/collection.cpp

@@ -57,7 +57,6 @@ SCollection::SCollection(Application *app, QObject *parent)
   backend_->Init(app->database(), kSongsTable, kDirsTable, kSubdirsTable, kFtsTable);
 
   model_ = new CollectionModel(backend_, app_, this);
- 
 
   ReloadSettings();
 

src/collection/collectionbackend.cpp

@@ -54,7 +54,6 @@ CollectionBackend::CollectionBackend(QObject *parent)
       {}
 
 void CollectionBackend::Init(Database *db, const QString &songs_table, const QString &dirs_table, const QString &subdirs_table, const QString &fts_table) {
-
   db_ = db;
   songs_table_ = songs_table;
   dirs_table_ = dirs_table;
@@ -219,8 +218,6 @@ void CollectionBackend::UpdateTotalArtistCount() {
   q.exec();
   if (db_->CheckErrors(q)) return;
   if (!q.next()) return;
-  
-  //qLog(Debug) << "TotalArtist: " << q.value(0).toInt();
 
   emit TotalArtistCountUpdated(q.value(0).toInt());
 
@@ -236,8 +233,6 @@ void CollectionBackend::UpdateTotalAlbumCount() {
   q.exec();
   if (db_->CheckErrors(q)) return;
   if (!q.next()) return;
-  
-  //qLog(Debug) << "TotalAlbum: " << q.value(0).toInt();
 
   emit TotalAlbumCountUpdated(q.value(0).toInt());
 
@@ -530,7 +525,7 @@ void CollectionBackend::MarkSongsUnavailable(const SongList &songs, bool unavail
 }
 
 QStringList CollectionBackend::GetAll(const QString &column, const QueryOptions &opt) {
-
+    
   CollectionQuery query(opt);
   query.SetColumnSpec("DISTINCT " + column);
   query.AddCompilationRequirement(false);
@@ -547,6 +542,7 @@ QStringList CollectionBackend::GetAll(const QString &column, const QueryOptions
 }
 
 QStringList CollectionBackend::GetAllArtists(const QueryOptions &opt) {
+
   return GetAll("artist", opt);
 }
 
@@ -596,8 +592,7 @@ CollectionBackend::AlbumList CollectionBackend::GetAlbumsByArtist(const QString
   return GetAlbums(artist, QString(), false, opt);
 }
 
-CollectionBackend::AlbumList CollectionBackend::GetAlbumsByAlbumArtist(
-    const QString &album_artist, const QueryOptions &opt) {
+CollectionBackend::AlbumList CollectionBackend::GetAlbumsByAlbumArtist(const QString &album_artist, const QueryOptions &opt) {
   return GetAlbums(QString(), album_artist, false, opt);
 }
 
@@ -629,6 +624,7 @@ SongList CollectionBackend::ExecCollectionQuery(CollectionQuery *query) {
     ret << song;
   }
   return ret;
+
 }
 
 Song CollectionBackend::GetSongById(int id) {
@@ -638,7 +634,6 @@ Song CollectionBackend::GetSongById(int id) {
 }
 
 SongList CollectionBackend::GetSongsById(const QList<int> &ids) {
-
   QMutexLocker l(db_->Mutex());
   QSqlDatabase db(db_->Connect());
 
@@ -658,7 +653,6 @@ SongList CollectionBackend::GetSongsById(const QStringList &ids) {
 }
 
 SongList CollectionBackend::GetSongsByForeignId(const QStringList &ids, const QString &table, const QString &column) {
-
   QMutexLocker l(db_->Mutex());
   QSqlDatabase db(db_->Connect());
 
@@ -687,7 +681,6 @@ Song CollectionBackend::GetSongById(int id, QSqlDatabase &db) {
 }
 
 SongList CollectionBackend::GetSongsById(const QStringList &ids, QSqlDatabase &db) {
-
   QString in = ids.join(",");
 
   QSqlQuery q(db);
@@ -705,7 +698,6 @@ SongList CollectionBackend::GetSongsById(const QStringList &ids, QSqlDatabase &d
 }
 
 Song CollectionBackend::GetSongByUrl(const QUrl &url, qint64 beginning) {
-
   CollectionQuery query;
   query.SetColumnSpec("%songs_table.ROWID, " + Song::kColumnSpec);
   query.AddWhere("filename", url.toEncoded());
@@ -719,7 +711,6 @@ Song CollectionBackend::GetSongByUrl(const QUrl &url, qint64 beginning) {
 }
 
 SongList CollectionBackend::GetSongsByUrl(const QUrl &url) {
-
   CollectionQuery query;
   query.SetColumnSpec("%songs_table.ROWID, " + Song::kColumnSpec);
   query.AddWhere("filename", url.toEncoded());
@@ -757,6 +748,7 @@ SongList CollectionBackend::GetCompilationSongs(const QString &album, const Quer
     ret << song;
   }
   return ret;
+
 }
 
 void CollectionBackend::UpdateCompilations() {
@@ -933,7 +925,7 @@ CollectionBackend::Album CollectionBackend::GetAlbumArt(const QString &artist, c
 }
 
 void CollectionBackend::UpdateManualAlbumArtAsync(const QString &artist, const QString &albumartist, const QString &album, const QString &art) {
-    
+
   metaObject()->invokeMethod(this, "UpdateManualAlbumArt", Qt::QueuedConnection, Q_ARG(QString, artist), Q_ARG(QString, albumartist), Q_ARG(QString, album), Q_ARG(QString, art));
 
 }

src/collection/collectiondirectorymodel.cpp

@@ -36,6 +36,8 @@
 #include "collectionbackend.h"
 #include "collectiondirectorymodel.h"
 
+using std::shared_ptr;
+
 CollectionDirectoryModel::CollectionDirectoryModel(CollectionBackend *backend, QObject *parent)
     : QStandardItemModel(parent),
       dir_icon_(IconLoader::Load("document-open-folder")),

src/collection/collectionfilterwidget.cpp

@@ -43,6 +43,7 @@
 
 #include "core/iconloader.h"
 #include "core/song.h"
+#include "core/logging.h"
 #include "collectionmodel.h"
 #include "collectionquery.h"
 #include "savedgroupingmanager.h"
@@ -58,6 +59,7 @@ CollectionFilterWidget::CollectionFilterWidget(QWidget *parent)
       filter_delay_(new QTimer(this)),
       filter_applies_to_model_(true),
       delay_behaviour_(DelayedOnLargeLibraries) {
+
   ui_->setupUi(this);
 
   // Add the available fields to the tooltip here instead of the ui file to prevent that they get translated by mistake.

src/collection/collectionmodel.cpp

@@ -85,8 +85,8 @@ CollectionModel::CollectionModel(CollectionBackend *backend, Application *app, Q
       total_song_count_(0),
       total_artist_count_(0),
       total_album_count_(0),
-      artist_icon_(IconLoader::Load("guitar")),
-      album_icon_(IconLoader::Load("cd")),
+      artist_icon_(IconLoader::Load("folder-sound")),
+      album_icon_(IconLoader::Load("cdcase")),
       playlists_dir_icon_(IconLoader::Load("folder-sound")),
       playlist_icon_(IconLoader::Load("albums")),
       init_task_id_(-1),
@@ -109,10 +109,9 @@ CollectionModel::CollectionModel(CollectionBackend *backend, Application *app, Q
   //icon_cache_->setCacheDirectory(Utilities::GetConfigPath(Utilities::Path_CacheRoot) + "/pixmapcache");
   //icon_cache_->setMaximumCacheSize(CollectionModel::kIconCacheSize);
 
-  //QIcon nocover = IconLoader::Load("nocover");
-  //QIcon nocover(":/pictures/noalbumart.png");
-  //no_cover_icon_ = nocover.pixmap(nocover.availableSizes().last()).scaled(kPrettyCoverSize, kPrettyCoverSize, Qt::KeepAspectRatio, Qt::SmoothTransformation);
-  no_cover_icon_ = QPixmap(":/pictures/noalbumart.png").scaled(kPrettyCoverSize, kPrettyCoverSize, Qt::KeepAspectRatio, Qt::SmoothTransformation);
+  QIcon nocover = IconLoader::Load("cdcase");
+  no_cover_icon_ = nocover.pixmap(nocover.availableSizes().last()).scaled(kPrettyCoverSize, kPrettyCoverSize, Qt::KeepAspectRatio, Qt::SmoothTransformation);
+  //no_cover_icon_ = QPixmap(":/pictures/noalbumart.png").scaled(kPrettyCoverSize, kPrettyCoverSize, Qt::KeepAspectRatio, Qt::SmoothTransformation);
 
   connect(backend_, SIGNAL(SongsDiscovered(SongList)), SLOT(SongsDiscovered(SongList)));
   connect(backend_, SIGNAL(SongsDeleted(SongList)), SLOT(SongsDeleted(SongList)));
@@ -159,7 +158,6 @@ void CollectionModel::SaveGrouping(QString name) {
 
 }
 
-
 void CollectionModel::Init(bool async) {
 
   if (async) {
@@ -717,6 +715,7 @@ CollectionModel::QueryResult CollectionModel::RunQuery(CollectionItem *parent) {
 
   // Execute the query
   QMutexLocker l(backend_->db()->Mutex());
+
   if (!backend_->ExecQuery(&q)) return result;
 
   while (q.Next()) {
@@ -751,7 +750,6 @@ void CollectionModel::PostQuery(CollectionItem *parent, const CollectionModel::Q
 }
 
 void CollectionModel::LazyPopulate(CollectionItem *parent, bool signal) {
-
   if (parent->lazy_loaded) return;
   parent->lazy_loaded = true;
 
@@ -761,7 +759,6 @@ void CollectionModel::LazyPopulate(CollectionItem *parent, bool signal) {
 }
 
 void CollectionModel::ResetAsync() {
-
   QFuture<CollectionModel::QueryResult> future = QtConcurrent::run(this, &CollectionModel::RunQuery, root_);
   NewClosure(future, this, SLOT(ResetAsyncQueryFinished(QFuture<CollectionModel::QueryResult>)), future);
 
@@ -1033,13 +1030,13 @@ CollectionItem *CollectionModel::ItemFromQuery(GroupBy type, bool signal, bool c
       item->key = QString::number(bitrate);
       item->sort_text = SortTextForNumber(bitrate) + " ";
       break;
-      
+
     case GroupBy_Samplerate:
       samplerate = qMax(0, row.value(0).toInt());
       item->key = QString::number(samplerate);
       item->sort_text = SortTextForNumber(samplerate) + " ";
       break;
-      
+
     case GroupBy_Bitdepth:
       bitdepth = qMax(0, row.value(0).toInt());
       item->key = QString::number(bitdepth);

src/collection/collectionquery.cpp

@@ -31,11 +31,12 @@
 #include <QSqlQuery>
 
 #include "collectionquery.h"
+#include "core/logging.h"
 #include "core/song.h"
 
 QueryOptions::QueryOptions() : max_age_(-1), query_mode_(QueryMode_All) {}
 
-CollectionQuery::CollectionQuery(const QueryOptions& options)
+CollectionQuery::CollectionQuery(const QueryOptions &options)
     : include_unavailable_(false), join_with_fts_(false), limit_(-1) {
 
   if (!options.filter().isEmpty()) {

src/collection/collectionview.cpp

@@ -298,7 +298,7 @@ bool CollectionView::RestoreLevelFocus(const QModelIndex &parent) {
         if (!last_selected_song_.url().isEmpty()) {
           QModelIndex index = qobject_cast<QSortFilterProxyModel*>(model())->mapToSource(current);
           SongList songs = app_->collection_model()->GetChildSongs(index);
-          for (const Song& song : songs) {
+          for (const Song &song : songs) {
             if (song == last_selected_song_) {
               setCurrentIndex(current);
               return true;
@@ -338,9 +338,9 @@ void CollectionView::ReloadSettings() {
   QSettings settings;
 
   settings.beginGroup(CollectionSettingsPage::kSettingsGroup);
-  SetAutoOpen(settings.value("auto_open", true).toBool());
+  SetAutoOpen(settings.value("auto_open", false).toBool());
 
-  if (app_ != nullptr) {
+  if (app_) {
     app_->collection_model()->set_pretty_covers(settings.value("pretty_covers", true).toBool());
     app_->collection_model()->set_show_dividers(settings.value("show_dividers", true).toBool());
   }
@@ -437,7 +437,7 @@ void CollectionView::paintEvent(QPaintEvent *event) {
 }
 
 void CollectionView::mouseReleaseEvent(QMouseEvent *e) {
-  
+
   QTreeView::mouseReleaseEvent(e);
 
   if (total_song_count_ == 0) {
@@ -494,7 +494,7 @@ void CollectionView::contextMenuEvent(QContextMenuEvent *e) {
   int regular_elements = 0;
   int regular_editable = 0;
 
-  for (const QModelIndex& index : selected_indexes) {
+  for (const QModelIndex &index : selected_indexes) {
     regular_elements++;
     if(app_->collection_model()->data(index, CollectionModel::Role_Editable).toBool()) {
       regular_editable++;
@@ -559,8 +559,7 @@ void CollectionView::ShowInVarious(bool on) {
     QList<Song> all_of_album = app_->collection_backend()->GetSongsByAlbum(album);
     QSet<QString> other_artists;
     for (const Song &s : all_of_album) {
-      if (!albums.contains(album, s.artist()) &&
-          !other_artists.contains(s.artist())) {
+      if (!albums.contains(album, s.artist()) && !other_artists.contains(s.artist())) {
         other_artists.insert(s.artist());
       }
     }
@@ -586,7 +585,7 @@ void CollectionView::ShowInVarious(bool on) {
 void CollectionView::Load() {
 
   QMimeData *data = model()->mimeData(selectedIndexes());
-  if (MimeData* mime_data = qobject_cast<MimeData*>(data)) {
+  if (MimeData *mime_data = qobject_cast<MimeData*>(data)) {
     mime_data->clear_first_ = true;
   }
   emit AddToPlaylistSignal(data);

src/collection/collectionviewcontainer.cpp

@@ -43,11 +43,6 @@ CollectionViewContainer::CollectionViewContainer(QWidget *parent) : QWidget(pare
 }
 
 CollectionViewContainer::~CollectionViewContainer() { delete ui_; }
-
 CollectionView *CollectionViewContainer::view() const { return ui_->view; }
-
-CollectionFilterWidget *CollectionViewContainer::filter() const {
-  return ui_->filter;
-}
-
+CollectionFilterWidget *CollectionViewContainer::filter() const { return ui_->filter; }
 void CollectionViewContainer::ReloadSettings() { view()->ReloadSettings(); }

src/collection/collectionviewcontainer.ui

@@ -6,7 +6,7 @@
    <rect>
     <x>0</x>
     <y>0</y>
-    <width>400</width>
+    <width>300</width>
     <height>300</height>
    </rect>
   </property>