From b8eecc05fd3c5deed08941e33c15f0acf97c07ae Mon Sep 17 00:00:00 2001 From: Jonas Kvinge Date: Fri, 21 Apr 2023 20:29:43 +0200 Subject: [PATCH] AlbumCoverLoader: Use own NetworkAccessManager instance Since AlbumCoverLoader runs in it's own thread. --- src/core/application.cpp | 2 +- src/covermanager/albumcoverloader.cpp | 4 ++-- src/covermanager/albumcoverloader.h | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/core/application.cpp b/src/core/application.cpp index 06a8c17eb..53c864889 100644 --- a/src/core/application.cpp +++ b/src/core/application.cpp @@ -149,7 +149,7 @@ class ApplicationImpl { return cover_providers; }), album_cover_loader_([app]() { - AlbumCoverLoader *loader = new AlbumCoverLoader(app->network(), app); + AlbumCoverLoader *loader = new AlbumCoverLoader(app); app->MoveToNewThread(loader); return loader; }), diff --git a/src/covermanager/albumcoverloader.cpp b/src/covermanager/albumcoverloader.cpp index 5abaadf46..fbf5f506d 100644 --- a/src/covermanager/albumcoverloader.cpp +++ b/src/covermanager/albumcoverloader.cpp @@ -53,9 +53,9 @@ #include "albumcoverloaderresult.h" #include "albumcoverimageresult.h" -AlbumCoverLoader::AlbumCoverLoader(NetworkAccessManager *network, QObject *parent) +AlbumCoverLoader::AlbumCoverLoader(QObject *parent) : QObject(parent), - network_(network), + network_(new NetworkAccessManager(this)), stop_requested_(false), load_image_async_id_(1), save_image_async_id_(1), diff --git a/src/covermanager/albumcoverloader.h b/src/covermanager/albumcoverloader.h index 7bb578113..8c1152298 100644 --- a/src/covermanager/albumcoverloader.h +++ b/src/covermanager/albumcoverloader.h @@ -51,7 +51,7 @@ class AlbumCoverLoader : public QObject { Q_OBJECT public: - explicit AlbumCoverLoader(NetworkAccessManager *network, QObject *parent = nullptr); + explicit AlbumCoverLoader(QObject *parent = nullptr); enum class State { None,