Change to const QString&

This commit is contained in:
Jonas Kvinge
2019-06-23 18:34:03 +02:00
parent f9cd2639ff
commit b9f4407815
9 changed files with 26 additions and 26 deletions

View File

@@ -45,7 +45,7 @@ const int ChartLyricsProvider::kMaxLength = 6000;
ChartLyricsProvider::ChartLyricsProvider(QObject *parent) : LyricsProvider("ChartLyrics", parent), network_(new NetworkAccessManager(this)) {}
bool ChartLyricsProvider::StartSearch(const QString &artist, const QString &album, const QString &title, quint64 id) {
bool ChartLyricsProvider::StartSearch(const QString &artist, const QString &album, const QString &title, const quint64 id) {
const ParamList params = ParamList() << Param("artist", artist)
<< Param("song", title);
@@ -58,7 +58,7 @@ bool ChartLyricsProvider::StartSearch(const QString &artist, const QString &albu
QUrl url(kUrlSearch);
url.setQuery(url_query);
QNetworkReply *reply = network_->get(QNetworkRequest(url));
NewClosure(reply, SIGNAL(finished()), this, SLOT(HandleSearchReply(QNetworkReply*, quint64, QString, QString)), reply, id, artist, title);
NewClosure(reply, SIGNAL(finished()), this, SLOT(HandleSearchReply(QNetworkReply*, const quint64, const QString&, const QString&)), reply, id, artist, title);
//qLog(Debug) << "ChartLyrics: Sending request for" << url;
@@ -66,10 +66,10 @@ bool ChartLyricsProvider::StartSearch(const QString &artist, const QString &albu
}
void ChartLyricsProvider::CancelSearch(quint64 id) {
void ChartLyricsProvider::CancelSearch(const quint64 id) {
}
void ChartLyricsProvider::HandleSearchReply(QNetworkReply *reply, quint64 id, const QString artist, const QString title) {
void ChartLyricsProvider::HandleSearchReply(QNetworkReply *reply, const quint64 id, const QString &artist, const QString &title) {
reply->deleteLater();
@@ -122,7 +122,7 @@ void ChartLyricsProvider::HandleSearchReply(QNetworkReply *reply, quint64 id, co
}
void ChartLyricsProvider::Error(quint64 id, QString error, QVariant debug) {
void ChartLyricsProvider::Error(const quint64 id, const QString &error, QVariant debug) {
qLog(Error) << "ChartLyrics:" << error;
if (debug.isValid()) qLog(Debug) << debug;
LyricsSearchResults results;