Use static QRegularExpression

2024-08-24 17:23:10 +02:00
parent a2cae06582
commit bc667a6474
31 changed files with 121 additions and 67 deletions
--- a/src/osd/osddbus.cpp
+++ b/src/osd/osddbus.cpp
@@ -145,7 +145,8 @@ void OSDDBus::ShowMessageNative(const QString &summary, const QString &message,

  QVariantMap hints;
  QString summary_stripped = summary;
-  summary_stripped = summary_stripped.remove(QRegularExpression(QStringLiteral("[&\"<>]"))).simplified();
+  static const QRegularExpression regex_illegal_characters(QStringLiteral("[&\"<>]"));
+  summary_stripped = summary_stripped.remove(regex_illegal_characters).simplified();

  if (!image.isNull()) {
    if (version_ >= QVersionNumber(1, 2)) {