Change to const references, make search progress and status pass search id

2019-06-20 16:33:28 +02:00
parent 9d222e2c57
commit bf4001968e
22 changed files with 499 additions and 482 deletions
--- a/src/subsonic/subsonicrequest.cpp
+++ b/src/subsonic/subsonicrequest.cpp
@@ -722,15 +722,8 @@ void SubsonicRequest::FinishCheck() {
      album_covers_received_ >= album_covers_requested_
  ) {
    finished_ = true;
-    if (songs_.isEmpty()) {
-      if (no_results_) emit Results(songs_);
-      else if (errors_.isEmpty()) emit ErrorSignal(tr("Unknown error"));
-      else emit ErrorSignal(errors_);
-    }
-    else {
-      emit Results(songs_);
-    }
-
+    if (no_results_) emit Results(SongList(), QString());
+    else emit Results(songs_, errors_);
  }

 }